Received-SPF: pass (google.com: domain of linux-kernel+bounces-65372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <078a6305-415a-4c89-9c5e-096adafded1b@amd.com>
Date: Wed, 14 Feb 2024 09:59:48 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214111555.GHZcyg6y_CdpA42a91@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214111555.GHZcyg6y_CdpA42a91@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?US9EZEZrMTYyZGpmUndmQXBQUllKcjAyaWd0MkVZaTEvNjBIR2RTemJxYmZW?=
 =?utf-8?B?eVJNM1hETHU4cExlVCtZL2hjY2tvbGI2ODlGRkpJeXlVc05tQVZyRmlVKzlM?=
 =?utf-8?B?Z2hTUEVmNWpwMFY5b2w1b24wb2xiU3pBYVdwZjRuTTVudVQ0bHdCdzk4c2Rj?=
 =?utf-8?B?OC9CVEx3UlU1R08vZmhWS1B2bExobGU3bTZRd2pSQVgvR05XNDBCMDB0b2Nh?=
 =?utf-8?B?cyt5bXZOTDRWQmF5YnlBOUpRNVdQQmZhZFMycEhycThXcHBFMStGQ1h6TVpx?=
 =?utf-8?B?aXovNVRnNmVqZFExdC83M3lJWkNQaEIzcVhpeitCVTlPN3RWVWNmMExkeE5T?=
 =?utf-8?B?V0tQR1F2VWtDOWtYcTR5N0tVV1h4YmQwdmxXN3ZrV1FYMDJlY1JaaDRubHpj?=
 =?utf-8?B?bVkySXZpS0k1U1cyL0FOSkx0OUx4S1FFemY4eTBRTCtHQndmOWVCdEhEMXkr?=
 =?utf-8?B?UGR6Vjh6UDhHQXhNNE9nZXd2bTJ2Z09VdU9waytTN2Y4Rk9BSFhZZGlWTGFl?=
 =?utf-8?B?OEd4VDJUbms5OGIxT0lpZmpQcmRXSG1SZzRjUzdoTjlxT0JKbGlNWGRxNTcx?=
 =?utf-8?B?UGttOW93RlN0NEk0OUJXa1VPT2VoeE14czdCRUs2WDlqcy9ZT05yY1NBSDRU?=
 =?utf-8?B?aUVFSjBVL1lVbmFnejVrMjBENmd3U2JiWWNiNXVRK3U1QnpwdTZ3NnM0ejh1?=
 =?utf-8?B?M2FwZWlOSWxhSmpMa0pjaU10bG5UWWJUZjVTUTZkN29tZTRqdDRpQ1Y3K2hB?=
 =?utf-8?B?RG5nMUhlZTBVbm5QS3FyM0tuazVmSlh2U2pHczQ2dlhYbDZoNFEydFJNMjVa?=
 =?utf-8?B?N3l6bWpUTTdyei81cjEyWTFrcnk5YVlWa2drYnkvY3c3cStHQzFFKzBTQ0cw?=
 =?utf-8?B?RG1pNUt6ZHJoUWdNWHQ1RjNRUW9lNU1YMy9CYnZvQzNqK3ZLRU5reDNwbUpI?=
 =?utf-8?B?UUswKzNham51cEJxQ0FwNnIva3gvK3kwWjdIaDhwcTlCT2E1OXd6RFR5ckV6?=
 =?utf-8?B?TlB5MStiS05yT2M4K2d6eWw0Vko2d3V4YjdUdkJPSFZIaVNXdDRxOG9zSTg5?=
 =?utf-8?B?MXNmMlBnUTVMTzhHQjQ1R3NxM0xWYWFBT0NjaTJBRm5GUkNoMDVzOVBMd3M4?=
 =?utf-8?B?cGJnMjVzQmNtaVVIUXVTRkdzNFVRaUowZHBtMS9kSzNCYTFERjRKSDhGeXZU?=
 =?utf-8?B?ZVZ4U1BtUERyY0JCYldUWE9qYTd0aWVuYjRXK3RRSU1MWkZJVmhsTXBLV2VN?=
 =?utf-8?B?ZlZRMXdDZkJxY0hISi9WRDJobTd0L2VRTVNJNS8wWHhIcmJmTk1oRHZ5T3p4?=
 =?utf-8?B?Ni9RbkQ3djZZWTZIYjNSNXEyR0tVWE01cGgxZ1c0QSswNkdjeUdJM1loVHpz?=
 =?utf-8?B?bCs2bW1BTWZzWXh6RXNud0tDcCt3OWlHcTZPRzJ5SmxEWldjaDFsT2kzSFph?=
 =?utf-8?B?SjlaVk11aFhGbnZ1bzZJLzQ4OUpQWWhDTHhocndzaDRzOWN2bXhMd2VqakFu?=
 =?utf-8?B?dWMrRkgzSGVRZmdGSFZ4QmNuT0hlcHlHMW1tcW0ydFk0elFLRmVYN3ZZNmlk?=
 =?utf-8?B?TFN4V2JscXhBdTJWNEpkS05jMzE0VHlpRFdXSTlQSWlLYmN0cDRhUkZIOWg2?=
 =?utf-8?B?SnRDVXlqVzNkSm4rclBGZTlWRkdMclRtUnRZK09xRHJ4MjFtMTREUGVPNWpp?=
 =?utf-8?B?QVNKTklpSjNpc1RtaHlNOEJuUk13SWVkMnNJckQyL1FpWi9LaUN0UTNUeGto?=
 =?utf-8?B?VWNJUGhoMG00bTNlcWRjWERsdHRsNmxDVEsrcVlUdE9aYjgzR3FzQXhST1pC?=
 =?utf-8?B?NVdqSWVyejBVVzdNVE12Qzk0T3NnS3V6NTlDbzF6WWd5cVBnM3VxQ2VaNlVE?=
 =?utf-8?B?MElmcmVzSHZwaEpncmk0Nm1DT1RDL0VSRkVaT3UrNFVUN0t2MDF2NFpjVUxx?=
 =?utf-8?B?QjhFQWZhM1NqTDJrQlovMnNqWFQzcU1WTHN4emR6ZHh5eUdFYk1UQ0U0eGZh?=
 =?utf-8?B?Q0lsWXdqdG4xcmwvbG5sRUVkY2ZkNTh5eWdtUWdTYUNxSHVKaFhxWmZVVHE4?=
 =?utf-8?B?dnZJWXJkZEZpdjd4d0xqazJEQ1hWb2NSMUZWNGQvTWtvS2kvWkhjVjZOUnJt?=
 =?utf-8?Q?1rxTnRlEdtamYh05/H7tp6nKK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f24cc168-7cee-4c92-c44b-08dc2d6d9850
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 14:59:51.0757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N5ESt6lo5jnqkGkQ0Rf8W7AjV7Wi/eZrllLs02VKg0Q9tC4RqWKYbQLdQoPer9VKR1q4z0hPQ/zuqpA2JeOvoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4155

On 2/14/2024 6:15 AM, Borislav Petkov wrote:
> On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
>> +static bool has_valid_entries(u64 valid_bits)
>> +{
>> +	if (!(valid_bits & FMP_VALID_LIST_ENTRIES))
>> +		return false;
>> +
>> +	if (!(valid_bits & FMP_VALID_LIST))
>> +		return false;
>> +
>> +	return true;
>> +}
> 
> Rename:
> 
> diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
> index 090b60d269e7..3da3f40f1efe 100644
> --- a/drivers/ras/amd/fmpm.c
> +++ b/drivers/ras/amd/fmpm.c
> @@ -221,7 +221,7 @@ static int update_record_on_storage(struct fru_rec *rec)
>   	return ret;
>   }
>   
> -static bool has_valid_entries(struct fru_rec *rec)
> +static bool rec_has_valid_entries(struct fru_rec *rec)
>   {
>   	if (!(rec->fmp.validation_bits & FMP_VALID_LIST_ENTRIES))
>   		return false;
> @@ -286,7 +286,7 @@ static void update_fru_record(struct fru_rec *rec, struct mce *m)
>   	fpd.addr	= m->addr;
>   
>   	/* This is the first entry, so just save it. */
> -	if (!has_valid_entries(rec))
> +	if (!rec_has_valid_entries(rec))
>   		goto save_fpd;
>   
>   	/* Ignore already recorded errors. */
> @@ -397,7 +397,7 @@ static void retire_mem_records(void)
>   	for_each_fru(i, rec) {
>   		fmp = &rec->fmp;
>   
> -		if (!has_valid_entries(rec))
> +		if (!rec_has_valid_entries(rec))
>   			continue;
>   
>   		cpu = get_cpu_from_fru_id(fmp->fru_id);
> 
> ---
> 
> and this one:
> 
> ---
> 
> diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
> index 3da3f40f1efe..813cc6a4f435 100644
> --- a/drivers/ras/amd/fmpm.c
> +++ b/drivers/ras/amd/fmpm.c
> @@ -255,12 +255,12 @@ static bool same_fpd(struct cper_fru_poison_desc *old, struct cper_fru_poison_de
>   	return true;
>   }
>   
> -static bool is_dup_fpd(struct fru_rec *rec, struct cper_fru_poison_desc *new)
> +static bool rec_has_fpd(struct fru_rec *rec, struct cper_fru_poison_desc *fpd)
>   {
>   	unsigned int i;
>   
>   	for (i = 0; i < rec->fmp.nr_entries; i++) {
> -		if (same_fpd(get_fpd(rec, i), new)) {
> +		if (same_fpd(get_fpd(rec, i), fpd)) {
>   			pr_debug("Found duplicate record");
>   			return true;
>   		}
> @@ -290,7 +290,7 @@ static void update_fru_record(struct fru_rec *rec, struct mce *m)
>   		goto save_fpd;
>   
>   	/* Ignore already recorded errors. */
> -	if (is_dup_fpd(rec, &fpd))
> +	if (rec_has_fpd(rec, &fpd))
>   		goto out_unlock;
>   
>   	if (rec->fmp.nr_entries >= max_nr_entries) {
> 

Okay.

Thanks,
Yazen