Received-SPF: pass (google.com: domain of linux-kernel+bounces-65406-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7f1a6ae5-be6a-4ea2-b103-8a4a7e34bf44@sdfg.com.ar>
Date: Wed, 14 Feb 2024 12:19:01 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] tools/nolibc: Fix strlcat() return code and size
 usage
To: Willy Tarreau <w@1wt.eu>
Cc: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 linux-kernel@vger.kernel.org
References: <20240129141516.198636-1-rodrigo@sdfg.com.ar>
 <20240129141516.198636-3-rodrigo@sdfg.com.ar> <20240211104817.GA19364@1wt.eu>
 <52c52665-35f5-4111-a9d4-f8669c79bf70@sdfg.com.ar>
 <20240213070243.GB9530@1wt.eu>
Content-Language: en-US
From: Rodrigo Campos <rodrigo@sdfg.com.ar>
In-Reply-To: <20240213070243.GB9530@1wt.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/13/24 08:02, Willy Tarreau wrote:
> Hi Rodrigo,
> 
> On Tue, Feb 13, 2024 at 12:16:06AM +0100, Rodrigo Campos wrote:
>> On 2/11/24 11:48, Willy Tarreau wrote:
>>> Hi Rodrigo,
> I've read it as well and I don't interpret it the same way. I'm reading it
> as "if dst doesn't contain a NUL char before size, its length is considered
> to be size", and the reason is explicitly explained just after:

Very true, I mixed dst and source. Thanks!

>> How are you measuring it there?
>>
>> Sorry, I'm not familiar with this :)
> 
> Oh, sorry for not providing the detalis! I just remove "static" in front
> of the function. 

Thanks for the examples and heuristics to keep code small :)

>> I've been playing, but as I can't measure the size, I'm not sure what is
>> really better. I'd like to play a little once I know how to measure it :)
> 
> Be careful not to spend too much time on it, nm --size and objdump are
> quickly addictive ;-)

Haha, it is definitely addictive.


I'll share some new versions in a minute.