Received-SPF: pass (google.com: domain of linux-kernel+bounces-65409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 linux-mm@kvack.org, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Mcgrof Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 2/7] mm/page_owner: use order instead of nr in
 split_page_owner()
Date: Wed, 14 Feb 2024 10:21:09 -0500
Message-ID: <C3807575-1599-44A2-80AA-AA67FDC5FCDE@nvidia.com>
In-Reply-To: <73b550a1-05f2-46b2-a0bc-574fabe8460a@redhat.com>
References: <20240213215520.1048625-1-zi.yan@sent.com>
 <20240213215520.1048625-3-zi.yan@sent.com>
 <73b550a1-05f2-46b2-a0bc-574fabe8460a@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_5952DDB1-30AF-47A2-991D-4607F38B8F69_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ndFZQEQ2Whs2kpgS3e/Ent0andbycVW4FLE3spdthHd3PfwnwhIEOpNxZ8Dn?=
 =?us-ascii?Q?HmO1FsrTA8bGkGfBqO8T+wGP51QD4KUHIcZfesocdK/oaPTygzLdcxP5PxpL?=
 =?us-ascii?Q?IXrxg0zglO187FPyl6caXclh2+nsm2bPZ2n2wP0uv+QBVqNlbFeuJkQ2yuFZ?=
 =?us-ascii?Q?VKsDkR6XMc273P0TJb0fQHchOA8rf1hgGIfoRkQ0PRQDn1aWCWK0lJwf+sjP?=
 =?us-ascii?Q?aHQr6Dqx3SXViFJk0uKl+kwF7odQ9SbnDxB17bHxzbSuHoFDj1Zgcxa0OG75?=
 =?us-ascii?Q?KcmsDnZsw8W1ALODusLNqh75B8DOMUXFN0RclQkdP8gLOkRBLygnrWA9lkfc?=
 =?us-ascii?Q?rc3cQEc347mwyLV0kRa6KehY2+BgZR4XTfPrg7OVj+sunen+ly4qr1lsRRdA?=
 =?us-ascii?Q?LxcZaIDH8B0Q59ynzfyFQz79v7ZteX+BS4wbe3hnTbnVVu9GTIuEqzu4NiNT?=
 =?us-ascii?Q?i++xPjpZVxUtjNoYegxZ0XboI/3nSZu+rDUVopPl0WPBlwhAyJCr9CBoJhEw?=
 =?us-ascii?Q?tOUr+wINB+kKDY72A2cJsYPIJFfcUVPHtKrnLPI1kVMCDYz7/hklwvjsPcY9?=
 =?us-ascii?Q?eS4vM4rvKqABKIO7AS1gBZyP7uoy6NQSa1mWFvoXLn7dseCHAfFReh2rWBTy?=
 =?us-ascii?Q?/hXHFcUHQSbuE1qSSdL31wJ2lOE0h22GbgC6t1g5xu9Exls9cFhNbDi20Ewq?=
 =?us-ascii?Q?qq9idXsEdjrN0Y6bybgdlZeejq1n6cmULZkLzhOb3dRe170cMmU+eEjmCQDm?=
 =?us-ascii?Q?ZnQ6bw/xuSvP12uxQVw9AzazklTpP/RzlaEl96Lc8CxD5BJDzMRSTY9Lzszi?=
 =?us-ascii?Q?fRHM228AM/pK8bjpbMx3dvWLMi1vPaHLpEbV7EuPbR0nQtdmj+ciD8YVYsP5?=
 =?us-ascii?Q?VDdabTkTl/Ljg5Okf4Mf9VQ5IIa14A99mcFFOpbaSUqiDCTpBGMN/VtqwkUQ?=
 =?us-ascii?Q?2xV6ukOpSxp/951hKyCheVLesu0aFDCRWfY3AmpRy1IEPAFL847OiRoQL50j?=
 =?us-ascii?Q?vhmvQmqCLVgCVsdqckg/F4/Ytbusq/ERkyJbkNz+iYdq8qdwySDe7YMvEM35?=
 =?us-ascii?Q?gBZKYsP76QkDdK22JRwNeoOjE7FTTV23sBT4zfaa9st8AtUrh2xGkOg7wbUq?=
 =?us-ascii?Q?H0SxYZG6EW1ZYzcFoj2Vqq8zkG0TdhLK1U++2cjN0vrQcF0AJgWmPys2y5MM?=
 =?us-ascii?Q?aNoX/jeDvJTjLeRerTNYnS7MessygMcAEvuSu93hzJdSEKeqlZ65VZ/7Ne+4?=
 =?us-ascii?Q?cnVq733m21LGcTkwKEGhu/gJkUKWkDIKGh+VJmELEOC9tUAMaHUFEJLXdT0L?=
 =?us-ascii?Q?3hr4xu4K/GjPOsudDUsf6NPYTsLW7y0C/OKFP+Xz1ZnoKB5DRBAOz8m6wrV1?=
 =?us-ascii?Q?H1dJOrDuhAmV93mRyQhRL0aDm5thY3USDV00Ue3l5Qw3o1V/TPfEIw2hMg8D?=
 =?us-ascii?Q?Cwi6qNuvxigM5LHZoJ88DSq8SlbeFs1lCqo1I0ZXikURuj6OlrALJTjQoq6C?=
 =?us-ascii?Q?dYFrToDsMkSMo67vWNldiywTXyF8e6U3+g1Kh+47Sx5SxbUZRmRHh2uvknB+?=
 =?us-ascii?Q?zvYbop3f1CLcee8oMeMLQ5LOxLE+97gTKr2q/Lm4?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 975a3cd7-42fa-423a-1a6f-08dc2d7093eb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 15:21:12.2480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I4C9S7ZhA2LSjJXCEuX+8U5ZoNOPWQFwwpFxkMOfBsTyh4avAB5wdN/hgj0ysR2P
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6609

--=_MailMate_5952DDB1-30AF-47A2-991D-4607F38B8F69_=
Content-Type: text/plain

On 14 Feb 2024, at 4:14, David Hildenbrand wrote:

> On 13.02.24 22:55, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> We do not have non power of two pages, using nr is error prone if nr
>> is not power-of-two. Use page order instead.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>   include/linux/page_owner.h | 8 ++++----
>>   mm/huge_memory.c           | 2 +-
>>   mm/page_alloc.c            | 4 ++--
>>   mm/page_owner.c            | 3 ++-
>>   4 files changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h
>> index 119a0c9d2a8b..d7878523adfc 100644
>> --- a/include/linux/page_owner.h
>> +++ b/include/linux/page_owner.h
>> @@ -11,7 +11,7 @@ extern struct page_ext_operations page_owner_ops;
>>   extern void __reset_page_owner(struct page *page, unsigned short order);
>>   extern void __set_page_owner(struct page *page,
>>   			unsigned short order, gfp_t gfp_mask);
>> -extern void __split_page_owner(struct page *page, unsigned int nr);
>> +extern void __split_page_owner(struct page *page, int order);
>>   extern void __folio_copy_owner(struct folio *newfolio, struct folio *old);
>>   extern void __set_page_owner_migrate_reason(struct page *page, int reason);
>>   extern void __dump_page_owner(const struct page *page);
>> @@ -31,10 +31,10 @@ static inline void set_page_owner(struct page *page,
>>   		__set_page_owner(page, order, gfp_mask);
>>   }
>>  -static inline void split_page_owner(struct page *page, unsigned int nr)
>> +static inline void split_page_owner(struct page *page, int order)
>>   {
>>   	if (static_branch_unlikely(&page_owner_inited))
>> -		__split_page_owner(page, nr);
>> +		__split_page_owner(page, order);
>>   }
>>   static inline void folio_copy_owner(struct folio *newfolio, struct folio *old)
>>   {
>> @@ -60,7 +60,7 @@ static inline void set_page_owner(struct page *page,
>>   {
>>   }
>>   static inline void split_page_owner(struct page *page,
>> -			unsigned short order)
>> +			int order)
>
> I assume this will fit into a single line now.

Sure.
>
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks.

--
Best Regards,
Yan, Zi

--=_MailMate_5952DDB1-30AF-47A2-991D-4607F38B8F69_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXM2mUPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUO7MQAJIw3V18hQZLRE71hgMC0xvuHC0wVVdxnS5W
ILnh+/PQ5iRGKPVGXZN5ymyrZ4yfkfRy1m6EaWH60lS2NmMHl9yxIo+ytbCOFa3W
mCGlcJSWrqP6LUmNUnkcw2y8QlTvFKIr8Do/1tHcNcXtDl0cDb9xcJvPfjnRcvvk
EIEFZvCOG7TImJz+fvmAArekkuRD0TJEsSdVX59k3On+N/oyiw4v8PjJsek4GJIr
+A4vsCBhvdDqNiSQB+OMhEM3vphg0LETNcsYBKTxDZWv9D5h57zoBDGu5zwmwSJv
7Ua0Wpby7N304SDGaJtOrscVLi18i9SD91OMXFK0YuT/TV+GriPvmdxL7Ub9+FH8
L9LgPJewpbH469eMYR3ZDbQFczrASKNfdMFJtWRAQOuCFawz4dMZMLnf77NiEuKJ
tczHT5bH1s6i1SfN3C7EsaNeNASH4EZpggjbCtGeb+e6IiWTbn99yuTcuG6BQ1F1
FCKUi2y0TO/o072jky7SiS5WtWD2D1alX5W+x+2NomwzoqD51OaFA8Gsvxaazpkq
MkpxutmPBrqgc+jqjHVFL2NbAmtc1YdXYouW4iZgsiIP7zR55FQVoN0UNcVg4x3D
5rMBfZcQ9m6RiDqAGqrzbp1MbXEYtLNdkmYOtrTgO59R7fyYaK0Q4nPXY/6e5WCf
RkBpPg1q
=CbfZ
-----END PGP SIGNATURE-----

--=_MailMate_5952DDB1-30AF-47A2-991D-4607F38B8F69_=--