Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbXLYL74 (ORCPT ); Tue, 25 Dec 2007 06:59:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751223AbXLYL7s (ORCPT ); Tue, 25 Dec 2007 06:59:48 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:43373 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbXLYL7s (ORCPT ); Tue, 25 Dec 2007 06:59:48 -0500 Date: Tue, 25 Dec 2007 11:59:46 +0000 From: Christoph Hellwig To: marcin.slusarz@gmail.com Cc: LKML , Ben Fennema , Jan Kara , Christoph Hellwig Subject: Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function Message-ID: <20071225115946.GB8296@infradead.org> References: <1198455022-27674-1-git-send-email-marcin.slusarz@gmail.com> <1198455022-27674-4-git-send-email-marcin.slusarz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1198455022-27674-4-git-send-email-marcin.slusarz@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 54 On Mon, Dec 24, 2007 at 01:10:19AM +0100, marcin.slusarz@gmail.com wrote: > @@ -53,6 +53,7 @@ > #include > #include > #include > +#include linux/*.h always before asm/*.h > +static int __must_check udf_sb_alloc_partition_maps(struct super_block *sb, __u32 count) I think __must_check is primarily for public APIs. But if it really helps you here I won't complain. Also please use u32 over __u32 (dito for the other similar types) > +{ > + struct udf_sb_info *sbi = UDF_SB(sb); > + sbi->s_partmaps = kzalloc(sizeof(struct udf_part_map) * count, GFP_KERNEL); > + if (sbi->s_partmaps != NULL) > + sbi->s_partitions = count; > + else { > + sbi->s_partitions = 0; > + udf_error(sb, __FUNCTION__, "Unable to allocate space for %d partition maps", count); > + } > + return sbi->s_partmaps != NULL ? 0 : -ENOMEM; > +} But please don't introduce new overlong lines in entirely new functions. Also the code look rather odd, I'd rather write it as: static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count) { struct udf_sb_info *sbi = UDF_SB(sb); sbi->s_partmaps = kcalloc(count, sizeof(struct udf_part_map), GFP_KERNEL); if (!sbi->s_partmaps) { udf_error(sb, __FUNCTION__, "Unable to allocate space for %d partition maps", count); sbi->s_partitions = 0; return -ENOMEM; } sbi->s_partitions = count; return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/