Received-SPF: pass (google.com: domain of linux-kernel+bounces-65443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 14 Feb 2024 16:41:50 +0100
From: =?UTF-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Luis Chamberlain
 <mcgrof@kernel.org>, Russ Weight <russ.weight@linux.dev>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki"
 <rafael@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Oleksij Rempel <o.rempel@pengutronix.de>, Mark Brown <broonie@kernel.org>,
 Frank Rowand <frowand.list@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Heiner
 Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 devicetree@vger.kernel.org, Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v3 10/17] dt-bindings: net: pse-pd: Add another
 way of describing several PSE PIs
Message-ID: <20240214164150.5be591d0@kmaincent-XPS-13-7390>
In-Reply-To: <20240214141310.119364c4@kmaincent-XPS-13-7390>
References: <20240208-feature_poe-v3-0-531d2674469e@bootlin.com>
	<20240208-feature_poe-v3-10-531d2674469e@bootlin.com>
	<20240209144349.GA3678044-robh@kernel.org>
	<20240214141310.119364c4@kmaincent-XPS-13-7390>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 14 Feb 2024 14:13:10 +0100
K=C3=B6ry Maincent <kory.maincent@bootlin.com> wrote:

> Hello Rob,
>=20
> Thanks for your review!
>=20
> On Fri, 9 Feb 2024 14:43:49 +0000
> Rob Herring <robh@kernel.org> wrote:
>=20
> > On Thu, Feb 08, 2024 at 02:08:47PM +0100, Kory Maincent wrote: =20
> > > Before hand we set "#pse-cell" to 1 to define a PSE controller with  =
 =20
> >=20
> > #pse-cells
> >  =20
> > > several PIs (Power Interface). The drawback of this was that we could=
 not
> > > have any information on the PI except its number.   =20
> >=20
> > Then increase it to what you need. The whole point of #foo-cells is tha=
t=20
> > it is variable depending on what the provider needs.=20
> >  =20
> > > Add support for pse_pis and pse_pi node to be able to have more
> > > information on the PI like the number of pairset used and the pairset
> > > pinout.   =20
> >=20
> > Please explain the problem you are trying to solve, not your solution. =
I=20
> > don't understand what the problem is to provide any useful suggestions=
=20
> > on the design. =20
>=20
> Please see Oleksij's reply.
> Thank you Oleksij, for the documentation!!
>=20
> > >=20
> > > Sponsored-by: Dent Project <dentproject@linuxfoundation.org>   =20
> >=20
> > Is this a recognized tag? First I've seen it. =20
>=20
> This is not a standard tag but it has been used several times in the past.

Not so much used indeed:
$ git log --grep=3D"Sponsored" | grep Sponsored    =20
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored-by: Google Chromium project
    Sponsored: Google ChromeOS
    Sponsored: Google ChromeOS

Is it ok to keep it?

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com