Received-SPF: pass (google.com: domain of linux-kernel+bounces-65473-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 14 Feb 2024 15:58:27 +0000
From: Conor Dooley <conor@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Support Opensource <support.opensource@diasemi.com>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Steve Twiss <stwiss.opensource@diasemi.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells
 required
Message-ID: <20240214-divorcee-backside-3a3767d054e9@spud>
References: <2212567f4c17251011e5e0bfa4ea0126d9815d39.1707922672.git.geert+renesas@glider.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="DGn9G3gGimok5V3Z"
Content-Disposition: inline
In-Reply-To: <2212567f4c17251011e5e0bfa4ea0126d9815d39.1707922672.git.geert+renesas@glider.be>


--DGn9G3gGimok5V3Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Wed, Feb 14, 2024 at 04:03:42PM +0100, Geert Uytterhoeven wrote:
> '#interrupt-cells' is a required property for interrupt providers, hence
> make it required.

I actually meant to send this patch yesterday but I forgot, thanks for
doing it - the only riscv violation of what Rob reported was also a
da9063..

> While at it, move '#interrupt-cells' in the example to match common sort
> order.
>=20
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I think:
Fixes: 361104b05684 ("dt-bindings: mfd: Convert da9063 to yaml")

and
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Docu=
mentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -87,6 +87,7 @@ required:
>    - reg
>    - interrupts
>    - interrupt-controller
> +  - '#interrupt-cells'
> =20
>  additionalProperties: false
> =20
> @@ -99,10 +100,10 @@ examples:
>        pmic@58 {
>          compatible =3D "dlg,da9063";
>          reg =3D <0x58>;
> -        #interrupt-cells =3D <2>;
>          interrupt-parent =3D <&gpio6>;
>          interrupts =3D <11 IRQ_TYPE_LEVEL_LOW>;
>          interrupt-controller;
> +        #interrupt-cells =3D <2>;
> =20
>          rtc {
>            compatible =3D "dlg,da9063-rtc";
> --=20
> 2.34.1
>=20

--DGn9G3gGimok5V3Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZczjIwAKCRB4tDGHoIJi
0ls2AP9kHzeiP4ColiDDTjA9ec9ni5ouN6qt1khCu44ICoTLAwD/RZ8bWYVG4fFL
TJb0YDw6dvhg1LWXJ9QRXE7GUtt6zgM=
=7Kaf
-----END PGP SIGNATURE-----

--DGn9G3gGimok5V3Z--