Received-SPF: pass (google.com: domain of linux-kernel+bounces-65461-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8b469fca-e1bd-4c7b-9311-cf4d2270f8cd@sdfg.com.ar>
Date: Wed, 14 Feb 2024 12:52:10 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] selftests/nolibc: Add tests for strlcat() and
 strlcpy()
Content-Language: en-US
To: Willy Tarreau <w@1wt.eu>, =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?=
 <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org
References: <20240129141516.198636-1-rodrigo@sdfg.com.ar>
 <20240129141516.198636-5-rodrigo@sdfg.com.ar>
From: Rodrigo Campos <rodrigo@sdfg.com.ar>
In-Reply-To: <20240129141516.198636-5-rodrigo@sdfg.com.ar>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 1/29/24 15:15, Rodrigo Campos wrote:
> +		/* For functions that take a long buffer, like strlcat() */
> +		char buf[7] = "foo";
> +

I've improved this to not be the same length as the other buffer (we 
can't catch mistakes like confusing the src and dst buffers like that) 
and added some trailing chars, so we also test that the \0 is added at 
the exactly right position.