Received-SPF: pass (google.com: domain of linux-kernel+bounces-65475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4107582e-03e7-4edf-8c50-6bf693f2d18e@amd.com>
Date: Wed, 14 Feb 2024 11:01:36 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214090630.GAZcyClhFloQfHEqrC@fat_crate.local>
 <9a82e9af-24c0-4277-b4d0-a708bba2cc88@amd.com>
 <20240214154909.GCZczg9Zfb_PXu2qV2@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214154909.GCZczg9Zfb_PXu2qV2@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WFRUUVJSU2czdnEwTkJPWFNSaTU0MXVpVDR4T0JvSjI4Y1FjYkk1RCtNdlhk?=
 =?utf-8?B?QzJkMm9qUFdCcmxjaFFtcm5XR0FOUlNnaDN5T3lrdldXNlJlRHpDNEtEbXpj?=
 =?utf-8?B?OXJRTVloZXNhMDdLVTdwOTR5L2I2VmR3Y1VscHBSc0dkbVBJNGRSbGJnd296?=
 =?utf-8?B?NFgzQnRybEE2T1p1emU5cjdMUndPRjQveCtMOU9MRmNBSDh1RURwWGhxRG5k?=
 =?utf-8?B?OXRNRENIa3lsV21sUHpzZlMwVXBRNE1vZlI2UnpYVHBya0ZnSlJ5cTFWV2Rh?=
 =?utf-8?B?eVVmcWQ3RFZsSVM4NXUxL2F0M1BpWmh4TFc4UHdBeVZiYW0wUXZ1NGljK2Zh?=
 =?utf-8?B?OFp2V1kyQzdWSXJJR29QVlNqcmtXZVRETTlaSjBBZjMxOEk5VXFISzdWTGJx?=
 =?utf-8?B?Uld0cWs2M2w3TjhtUUdZSCs4cFYyUVdTUC8yWU1GaTdXWGhLRWV3S2FZS3Fx?=
 =?utf-8?B?eldtRElyUmtDYXp4MmJLQXAyeW1iK0Z1M0g4cXM5bE42Z3hLdmd0cXdpNHFa?=
 =?utf-8?B?MG00eWREcUtmUmk5N2NSbzJCQWEzTnRRYzBLSzB4dk0vQkZSQmsyNUpHVDBF?=
 =?utf-8?B?YTUzNUFqdW1PQ1hhYTdjdXg3ZURJMXZ4Yko0UlBHVzFqcTh2RkpvVzFxblFB?=
 =?utf-8?B?eGpvaEtZdWJLdmRwMmZ6MWpHLytodHBGRHYvandRWVdKZ1k4N2VTb0xtMHFQ?=
 =?utf-8?B?QTlEMFNtVklBbkx2Qk1SN2lZSytoMHdhc1I5dldHSkV4Y2hHZXJEc1dRVit4?=
 =?utf-8?B?NVpsbkYrRGFQNXpESXk0a1BVOHluRVJ1azFvUW1yNHVsd0pqbXk3cTRCTWhH?=
 =?utf-8?B?WFBscU0zNUV5VzRYWmcrbG5mMUpNVnBoMmw5SGlMc2traCtOSmVPSVI5UDN1?=
 =?utf-8?B?ZVBmdEhDQ3hGam53VnRDYlNqakdmUU9FQ3FvUjA2KzlaaU8rWXFVbTB1TEw5?=
 =?utf-8?B?cXcvRWJYWWxsbTNIMEErQTBnNyswd1RhTk56M01pVmhRMFBiNkE2cFEvblVT?=
 =?utf-8?B?bVFIa2grY2tTbUd3K2hSNlR2N1BoVkhSV0ZZU2tRSVVuMVRkd3g2ekkyT2dK?=
 =?utf-8?B?amJ5ODM5aUZXSmhpZE9qZDh1b0E2b2JBNk52ei95R1BBamlGZDQ3b05SdW9E?=
 =?utf-8?B?OXRuSVlpU3p3SmNYTit1bnNtcG1KcTZXK2RTWlZKV29ORkJxU2dYS3hNMHF6?=
 =?utf-8?B?em8xOUlnazJ6YzVJbGtEbFlpcjR0STFxQUZvcjdaZzFJUHJHWXJDQzhzeGps?=
 =?utf-8?B?RitQUVduY3B1dW5jUmprZ1lpSnZJUW9IQlBRV2JrRTFTVlRlSTBGMkxUbzNV?=
 =?utf-8?B?RmNZQkRQTU9uK2RXY2RSWDRrSnpxWTJieUJXMXJkUUpadElsa0tYVDIzMUNX?=
 =?utf-8?B?OThER1J1TG04VC9ydGtERGs5VmtCRXpldkdSdFhqcFBOQ1drTjZpT1c3K1dB?=
 =?utf-8?B?ejZIZFZUSVlZdjF3eE5odkVQWUw0RVNHQUU1YmsvTlhsSnhFSXlseDdoL2xM?=
 =?utf-8?B?aTJSdDNTUytHREJxMndYSkppSmU0bFZrQnN5SzYyU1NnTGM4NXVWclczMzFW?=
 =?utf-8?B?QlFDQ1N3SnBHS2tIY25vdHA5VmNqaFgrY0pNRFVmRUVEeUZIc0ZaODRlbjVD?=
 =?utf-8?B?RVdrN0VuQnhBQ2F0UjBJR0trR3hFeExXYytvZHlwOWNxQVEwQXhZUXM3NEVC?=
 =?utf-8?B?SCtRSWViak9MZnFrQlp1YXNkR00yZ1I4aUxIc1pyak5CTHBnbSs2OTkyWFhq?=
 =?utf-8?B?eUl6M0JBVkdKOG9XR25ybHpqbWRPRXFDeWpCNHVHdkZUSm9VSGVrTGZHU2Vw?=
 =?utf-8?B?NXpHSCtEV250SklKSkZNbnpnNm9oYmNCUURXV2syRUpMUW5zekxKbTVDYWVw?=
 =?utf-8?B?dlQzWlpUTlhMcXMydG9GQ3Rpc0Z5UDU5K0hjL1NNL1MxVWcycUlZMWFGdzZm?=
 =?utf-8?B?cmVLL0lscXBiV2VNZlFFZi80Z1M2YXFtbU5ZSkJaZkx1TnJYZWVQcGNVK0VE?=
 =?utf-8?B?VnZvQkZPRGVkZ09sOTRNQlFWREpSNXRaU25rNnpsNGRncnE1djJFR2NvMkpl?=
 =?utf-8?B?OE9LVFRncWk0VXJkdmFpMDZHeUZHalVFbGY1TEZESmJ4dEErK3NwSm1aQXNk?=
 =?utf-8?Q?FCdvtyYEr4L3jfBcWWUHuEbQJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5764d135-4ab7-4beb-0b64-08dc2d763a4c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 16:01:38.8023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lDPxEBG5VxHOr8F5X22qkuHJKpQ/RSU5m9PyFrmtpuwjcowl6kay/1tOX442jLlQ7dEafcCdjMy/eX+kLEm3/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6603

On 2/14/2024 10:49 AM, Borislav Petkov wrote:
> On Wed, Feb 14, 2024 at 09:21:45AM -0500, Yazen Ghannam wrote:
>> Do you mean this should be left out of the commit message?
> 
> Yes, the text should talk only about what the patch does. What can and
> will and won't happen in the future doesn't matter.
>

Got it.
  
> IOW, here's what I have now:
> 
> RAS: Introduce a FRU memory poison manager
> 
> Memory errors are an expected occurrence on systems with high memory
> density. Generally, errors within a small number of unique physical
> locations are acceptable, based on manufacturer and/or admin policy.
> During run time, memory with errors may be retired so it is no longer
> used by the system. This is done in mm through page poisoning, and the
> effect will remain until the system is restarted.
> 
> If a memory location is consistently faulty, then the same run time
> error handling may occur in the next reboot cycle, leading to
> terminating jobs due to that already known bad memory. This could be
> prevented if information from the previous boot was not lost.
> 
> Some add-in cards with driver-managed memory have on-board persistent
> storage. Their driver saves memory error information to the persistent
> storage during run time. The information is then be restored after

"then be" -> "then"

> reset, and known bad memory will be retired before the hardware is used.
> A running log of bad memory locations is kept across multiple resets.
> 
> A similar solution is desirable for CPUs. However, this solution should
> leverage industry-standard components as much as possible, rather than
> a bespoke platform driver.
> 
> Two components are needed: a record format and a persistent storage
> interface.
> 
> Implement a new module to manage the record formats on persistent
> storage. Use the requirements for an AMD MI300-based system to start.
> Vendor- and platform-specific details can be abstracted later as needed.
> 
>    [ bp: Massage commit message. ]
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Link: https://lore.kernel.org/r/20240214033516.1344948-3-yazen.ghannam@amd.com
> 

Otherwise, looks good.

Thanks,
Yazen