Received-SPF: pass (google.com: domain of linux-kernel+bounces-65480-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e752d061-0e94-48c2-ba17-3111a847785d@redhat.com>
Date: Wed, 14 Feb 2024 17:04:07 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [REGRESSION] `lis3lv02d_i2c_suspend()` causes `unbalanced
 disables for regulator-dummy` and `Failed to disable Vdd_IO: -EIO`
To: Linux regressions mailing list <regressions@lists.linux.dev>,
 Mark Brown <broonie@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
 =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
 Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
 Liam Girdwood <lgirdwood@gmail.com>, LKML <linux-kernel@vger.kernel.org>
References: <5fc6da74-af0a-4aac-b4d5-a000b39a63a5@molgen.mpg.de>
 <ZcTmdg2qTq0bP0ul@finisterre.sirena.org.uk>
 <6e20e772-e50e-4600-8325-1878badbbdc8@leemhuis.info>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <6e20e772-e50e-4600-8325-1878badbbdc8@leemhuis.info>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi,

On 2/14/24 16:34, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 08.02.24 15:34, Mark Brown wrote:
>> On Fri, Feb 02, 2024 at 12:38:04PM +0100, Paul Menzel wrote:
>>
>>> Testing commit 2f189493ae32 (i2c: i801: Add lis3lv02d for Dell XPS 15 7590)
>>> [1], it’s very likely this commit, it turns out, that Linux logs the warning
>>> below during ACPI S3 suspend:
> 
> Mark, many thx for your reply:
> 
>> The driver is just buggy here AFAICT,
> 
> /me reads that as "buggy even before 2f189493ae32, that commit just
> exposed the problem"
> 
>> it's powering off the device in
>> both runtime suspend and runtime resume so if the device is runtime
>> suspended when system suspend happens then it'll power off the device
>> again.  The runtime suspend and system suspend need to talk to each
>> other here.
> 
> Well, that was 6 days ago and nothing further happened. Makes me wonder:
> Who will look into this? And when?

I have a laptop with a lis3lv02d where I can try to reproduced Paul's
problem. I expect this to reproduce on any Dell with the lis3lv02d 
so reverting 2f189493ae32 won't help, it fixes the problem on
Paul's model but not on other Dell models which use the lis3lv02d
driver.

Anways I plan to look at this sometime next week.

Regards,

Hans