Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp680954rdh; Wed, 14 Feb 2024 08:19:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUwAQO1K/f04j56LZk6hmQgnSJU8umyjb6CN31Y7uEzN9EzOEmsXPZks2CpXTrcVi0hsXldrcpHeKafxMR5sS5I1ca1KrwWaos/CYhfig== X-Google-Smtp-Source: AGHT+IEChny3DakNhs2sXSuR3eD+xm+Li/T/BOVSAxset3NoHJsK2J541gTqNohXQiFOxdZf6gHj X-Received: by 2002:a05:6a00:4194:b0:6e1:1c:1125 with SMTP id ca20-20020a056a00419400b006e1001c1125mr3571513pfb.14.1707927571859; Wed, 14 Feb 2024 08:19:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707927571; cv=pass; d=google.com; s=arc-20160816; b=hMSBYaDXYffzf3Cvzx27VcU6hdyvWsALRbZLor12Snqy4UDKUTYJZumXpXvpa1cnDz /qvmJn/4H+MnoYfAuQ8GbDbTanzs3mkTANp7iBZYVZbV5hcmzRTNsaMFVtdxTZAD8J1a UD1WIdV0vzBclIdv/6CuwW1xB27rK7kvolVxxgbm00PT1Z6YURRL3K7Mkw80jgBOHDL5 8v1U6a3aGaU577aQoMKGcfEQeLEiHstE1yN/PYOzILJJEQH5mZeph8KjczXTHblHwpgf 2Rkh/cpzqxDVuDwvDTCrisOY7VKsZNEjzeHt/+hY61LbGg8ZuZsrOnDPzlbUoVGpxXuB 9CVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=WvW8w5yUCB+T24tws0BE+nRUAXqLznpxXzLB9RssHjE=; fh=/V/Ap5M7UF6q2evri6TlaT0s8B44KHwomG1fn1dGtks=; b=iPnssuKL/f6KpdxeihXjKyf7lNNEq4VGpniyxy8NgWJ51NUhe+sqyftlJ4CU2dhP1U bkbBgJiDW3Z/b8+Wx0N3q3W3tgnhAc7Jt75P6Yh+lQbOB72In56ukL6CYCHOwLMkyKtF Rgtlq49HHXpFhzcnhq2sV5vl0C4zzy+JAJ9l71h5ctTHI92WmcWxzXSEJDQoFd8p9wyy D0WbjZ8ThlLvBsyPzn7abEKNrNdh2Q8m0QcUCK6zZAseK4LcOLZbtoetC9pYFK49zUgS HZRByPgyy0cOEYJ/J35F2O2Fo73erYNlCfpgDUUJNB2vRJBo7C6OrsXnDp5eJ6pUv3Ik k7kw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=If7KvAk3; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-65502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65502-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev X-Forwarded-Encrypted: i=2; AJvYcCW9PvDK8ArId13yQo1DtmfaWq0hGBZDhVxf4TGUEQd0w/ibNNPEODhngkYkSQqZ2X/51GXekR2szU55EKTvBex3XdsBOsd8NvqHYojulQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ls53-20020a056a00743500b006e07c7be258si8615027pfb.39.2024.02.14.08.19.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:19:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=If7KvAk3; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-65502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65502-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8ABB428AF04 for ; Wed, 14 Feb 2024 16:17:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D5E35FDD9; Wed, 14 Feb 2024 16:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="If7KvAk3" Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C3965FF00; Wed, 14 Feb 2024 16:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707927455; cv=none; b=ew5yX8J5xqwOuHZEA74X9PBjwc0G3Ss1S+IoHOGcVm5kyrVyD7J7Ca6SN+i38iGJB1qY+nSQwdbiQ3raSuo2AHq0s6MgYdwov+l+N0Db6uNeOO8C77FPNKOvv2pETWGHes897w9muqmseKEqXX3TF/xUk3DUK/RrFKRL2K9t9Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707927455; c=relaxed/simple; bh=BMkf3NLk/iLQr+WYsIcfjcR7/4kHgrAc/NsrN13AxP8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fKlo8vDAfWeUikhWaH5kZlzTKliONVxkZcuvbn8Ce3rI7nttKlxKEdq/wmg118x/toqnYJSyfX9S1M30ScS1sTFdFzjtM38S5w7ddKjjbUD6229yoRszvFOu5nLNf7Lx616bmz97Th3MKAXpb7n0BnGUG5S8B1GJGAHld4lBeEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=If7KvAk3; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Wed, 14 Feb 2024 11:17:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707927450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WvW8w5yUCB+T24tws0BE+nRUAXqLznpxXzLB9RssHjE=; b=If7KvAk3S44JHt8xTRFRLZGFB9HhXr9yTjM5WxyEi5xNjIqcYGBYlgszfmKzpB+BaRdtGZ n3N+YeR7XUwHyIMey1lTARWNjfYN024v3AgKYdiCjuLtH6AdMtTaqstAHFyfDaYzOPE5KS nEweGtuqjPMrA6xlO/8Dh+ORbNs02fU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Johannes Weiner , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 00/35] Memory allocation profiling Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240214062020.GA989328@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, Feb 14, 2024 at 05:02:28PM +0100, Michal Hocko wrote: > On Wed 14-02-24 10:01:14, Kent Overstreet wrote: > > On Wed, Feb 14, 2024 at 03:46:33PM +0100, Michal Hocko wrote: > > > On Wed 14-02-24 01:20:20, Johannes Weiner wrote: > > > [...] > > > > I agree we should discuss how the annotations are implemented on a > > > > technical basis, but my take is that we need something like this. > > > > > > I do not think there is any disagreement on usefulness of a better > > > memory allocation tracking. At least for me the primary problem is the > > > implementation. At LFSMM last year we have heard that existing tracing > > > infrastructure hasn't really been explored much. Cover letter doesn't > > > really talk much about those alternatives so it is really hard to > > > evaluate whether the proposed solution is indeed our best way to > > > approach this. > > > > Michal, we covered this before. > > It is a good practice to summarize previous discussions in the cover > letter. Especially when there are different approaches discussed over a > longer time period or when the topic is controversial. > > I do not see anything like that here. Neither for the existing tracing > infrastructure, page owner nor performance concerns discussed before > etc. Look, I do not want to nit pick or insist on formalisms but having > those data points layed out would make any further discussion much more > smooth. You don't want to nitpick??? Look, you've been consistently sidestepping the technical discussion; it seems all you want to talk about is process or "your nack". If we're going to have a technical discussion, it's incumbent upon all of us to /keep the focus on the technical/; that is everyone's responsibility. I'm not going to write a 20 page cover letter and recap every dead end that was proposed. That would be a lot of useless crap for eveyone to wade through. I'm going to summarize the important stuff, and keep the focus on what we're doing and documenting it. If you want to take part in a discussion, it's your responsibility to be reading with comprehension and finding useful things to say. You gotta stop with this this derailing garbage.