Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp682337rdh; Wed, 14 Feb 2024 08:21:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW4N1YQFaR5yx8FkCvgO/zj/PGirPByGaaFGMmdF2otbCvz/CGcMqmJGtWZh0FxFwyg1ecu/WOYu9zsDZ9ewJb+IkCnotwvTuP1I6sUyQ== X-Google-Smtp-Source: AGHT+IHlNi9QRI2G8kmXamZHcmIgo0cSr6Y1vVhDw4J1oH+gX18QXKyF+cFaktnlxcd4c0oLk54Q X-Received: by 2002:a67:f490:0:b0:46e:c752:16e7 with SMTP id o16-20020a67f490000000b0046ec75216e7mr2885414vsn.24.1707927684405; Wed, 14 Feb 2024 08:21:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707927684; cv=pass; d=google.com; s=arc-20160816; b=pJ5yC+Scv68oVFRS2Fkyg3M0debBdRCx0o3U7rlmiptWaWVIFa9i1uZ6F6V22lzTee P8zzoiQNa+viyMVeMwlxVorUJ1mGD9qf8TtpcmTlcc0tcUXRVPrHZtcRxnl9xJXOv+h7 oQYKWsCU6eIGn5Tp+u6TZiMysfQ16q7RuwkO288w7npKLhsjJbXg554wrelkgGzxtRop TWyZufqAV0OHzlc2VJe4Bxwm17DrtbsLTnQpAEn3aH0BzkY64VrVX6Bfus4sLKQ6oF8J Wvxge6WKmbeoUtdD1lAnxctPk5wg/EwH3LxUoM0O4VNttYcF2fgoHusQ2JiFNdwXqD/p ADzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=UYB+HoT6dXR3Q4alz/s7RxFLW6sCTSYU0ADxHCZfdsQ=; fh=/4Nv8mKnmrfcwSvQiLElLJtGRPV0qUWby17RW/aui0s=; b=QAN1sAs0Wqzo47DVi7B64TqFfjdg2jikgBBnZuNysRrmjJggV13VZSoOY7j2xNhKbS ya8svXFvD9YYdVDhxKu3MvS2swzYHiIm74DTiDaYiXlCNleaUr/XrrnLCu4XrkFEZIZV mDc7gCt+4DiUUXiJuHaJNWalE6Z2s50ZoKWtZw3FvwH2HJLQJ7HXU0lbZihCVDT//sMA 3Tz7bRdv81mfUa2rmfFWdPERY7yFpSVjTFCaUgimLzDMQaf2+SqbptcdRlxXZFEW/bHK StBncqiyWIHtFs7nSILPu35gzjnp6ffcnOrBeV6xVYB7EOKxLHdN87NAQ0aJtQPsFxOY 8RiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-65509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65509-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVVArhEHPPE3ugL6A3/l/Pg/84hatN8yjGUmVlOtKmmjpcyh/KgVOOeTkwyuKpamc3esvLUubjndIQITlCoZg7XDRN11WWVrgXaslGoWA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s5-20020a67eac5000000b004699c590f6asi1519405vso.493.2024.02.14.08.21.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:21:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-65509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65509-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2A1501C2074D for ; Wed, 14 Feb 2024 16:21:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29F3B6025D; Wed, 14 Feb 2024 16:20:56 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A01395FF03; Wed, 14 Feb 2024 16:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707927655; cv=none; b=BTITpPxAkqGfwD2lg9S3nvtxWPovPwF8iJWfZxFIJ2I90T4eGNxDQDMtZdk9jLT7LwmEMdmEKahplagJOZd7JHuTNiaVIwKXbDRT92RSaAUUeM8RpOGfv2xB6Ko8GM9Z/xEF9sdVXV5Cq0vUdG3/fQ3sxxFO8m++4fN2UC7sINU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707927655; c=relaxed/simple; bh=UYB+HoT6dXR3Q4alz/s7RxFLW6sCTSYU0ADxHCZfdsQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AeFoqRhWwIVkectvoks089USgU81wtzebWXap0eU0nxo1+jG13MQVKryeMaArN1cQuoqyIXPOyHqawQbMrylFJBnFqxOMxr6QUi90XTF2OKGvYPJFeKk1+4ic2NzVmnFGj0eDL+RFCNlkZRJiyZHskJkzOIRA1Ws/8NSkc6i9ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F0D7C433C7; Wed, 14 Feb 2024 16:20:54 +0000 (UTC) Date: Wed, 14 Feb 2024 11:22:25 -0500 From: Steven Rostedt To: Kalle Valo Cc: regressions@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Jeff Johnson Subject: Re: [regression] tracing: kmemleak warning in allocate_cmdlines_buffer() Message-ID: <20240214112225.088484da@gandalf.local.home> In-Reply-To: <87mss3njvj.fsf@kernel.org> References: <87r0hfnr9r.fsf@kernel.org> <20240214094617.1e6ec684@gandalf.local.home> <87mss3njvj.fsf@kernel.org> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 14 Feb 2024 17:30:40 +0200 Kalle Valo wrote: > Although the patch didn't apply for me as in my tree the functions are > in kernel/trace/trace.c. I don't know what happened so as a quick hack I > just manually added the three lines to my version of trace.c. Let me > know if there's a git tree or branch you would like me to test, I can do > that easily. I sent out a v2 that should apply and I added your Tested-by tag. But you may want to verify that it does indeed still work, as I decided to swap the order of adding kmemleak_alloc() with the memset(), so it's not exactly the same. Thanks, -- Steve