Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp693053rdh; Wed, 14 Feb 2024 08:38:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVHHMjJzEnpjXWEAOGHXKAIYzwu75ZkNkqC3ta3HO6+FsEJNz7OY7E/Vgv1hcwsQ3yRIndNaVWeKQIPWp46gtRu5doXuEc3ZJSgL7Bl7A== X-Google-Smtp-Source: AGHT+IGAUbumvFx6jjpPayz11Jh1QotGuSawgA8Qczxjn8PeQEj8YwSIK5LEd47UDuEtBgroucHH X-Received: by 2002:a17:906:dfc5:b0:a3d:48d0:d519 with SMTP id jt5-20020a170906dfc500b00a3d48d0d519mr1513232ejc.7.1707928708920; Wed, 14 Feb 2024 08:38:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707928708; cv=pass; d=google.com; s=arc-20160816; b=NqTkwnrVNtboA8EqOp8KeUg+190qJt7bTc/CDjDxM+lis9OJt0iEDvrCC5rD+mH6HF qrbptqpPV3FgGgBxNRJf1SoppnyE5RDKUJ0VWUgXQc5WoTKeMlC3Sigw71EXCIprcLJP aELPjWFtX5KfXkVyeBlCTQKPsjJhrBlopqAxlY08qGh5AxbUKJyWyOThDp4okiDHa7tK yMQPCShMTiizVetMIUo842WdyMvvIucQ5RHUQIFLCfUiZBVB9w1I1K1Xtty0pyhtji5i gGPVTNFaklilZE5RYSU5HAMUYc4SAl48mMky/tk5VQMZiK1n/1OZiz33o2VqFV87CiLg MTMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature; bh=bMxxga2VHnzrtlcmhAP4lYYYdLUQfpODd3rzmO3uM1s=; fh=t4/bxc8o00eWb6f+pPB+PLFZ7tSdc20bLhVsQyd75zU=; b=nF27uUvHsmrEDuJdTICqsb6m0u0xhVFHeZdFK5y1ZaFvDv9icaulAGiLWKRtGXc/p+ 42EV9WCc1zEmL0qYbuYcm373ZGXKdn/2NNZM7Rlqqa1njoTm0UU1aHAbkPuGjF0WgTUy ntc0BrLoNf/num11oIrnPIJ+09kecjNdvx+vVHnsSZCk0H86d7abnZmelGmqKtRGBwmv yOHkZMHEYSklRiqziFOI0y1eceVtfUBpTpBbE8QrZ/eMr4BaRujDuhKzTmPYVqac+Awj 156ph8Zh8BJlaqfbkJ75JtHhjT4IdXGqaILw38JKYYI95Bgzb74QBskvTMHaAKXo3MQs QIdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=shCq8Cxx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-65559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXfeasi5dM0+VY869TDX2gRENu/NS93+JlzFG0FzwArGnfj3clb1b7Oilp3n5MLzNnnHnacTvX0J5GQKAmr2yxxn1eOZ9hmjTyugrrV7w== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e19-20020a170906249300b00a3ca204bbfcsi2379003ejb.361.2024.02.14.08.38.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:38:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=shCq8Cxx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-65559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A6D731F21553 for ; Wed, 14 Feb 2024 16:38:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EAD306026E; Wed, 14 Feb 2024 16:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="shCq8Cxx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1568E111A2; Wed, 14 Feb 2024 16:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707928521; cv=none; b=MDstfzXRWYbFxJyADCiJUw0w548Hs5XQq7YdmucjkaAo2PppyTcs+Uu96JovG7GpIKZjLsLnvAnPZK2Kv2UFEfmNQDYfoHxbiaZu8OsiBCSiTRnK59vWhWMpyZ6NKYly7kmNXZei03IMQtjRldB2fDncWWJCWYP24gif7HlLfIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707928521; c=relaxed/simple; bh=J72t8M3F1TWeIhPf3FrS60pdxQgA9gj+2aAtGhv9dQk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=E7bRGtgTCzsLeX7cpIeGz+hHCRUGnjYuedOEfpZsGOPNO5TabmMBsVsht2izttzU8tFUDD5+F4zYwFpyxoy3on0jrWFL87vvt5gGmSmZe80EuUSOVyEjXlkqOXs33LxbHevrcjwcq0PRMYUsfqT4DWFuZEca61UFWcAUP8oKxFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=shCq8Cxx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78FCEC433C7; Wed, 14 Feb 2024 16:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707928520; bh=J72t8M3F1TWeIhPf3FrS60pdxQgA9gj+2aAtGhv9dQk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=shCq8CxxHFUGHgF+r+BblplT3Jvs9aE7a2Q1RuR82WMwKY1liVxwyAODYC1tdr5B0 A6Imr8ZxwKnYceSQb22b4+LGaVI+VIHGMOO9wfJ5SJZzNpUQixCIZkN/XRmIVEEFqJ pm5BhiW+9FRVGfLb3qduGVlqsvmosyRULHlAfr9HHwUtpS8Kg9eoYGHqr4st7ysX42 HayUYIbxc/o0bT920Eb9dCH05ANQPNBDE74WSAnvy8riEXmxWrZCg9XrwgFB9q+4Do YlQuGpVSU2RTNZ2Nw6vge8+N64OhJa7Ff6PtwBgqJ6EzcyZRLxzpKNDM2QBnqjelhB akzkKj5gg2JZw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1raIEA-003CWI-3t; Wed, 14 Feb 2024 16:35:18 +0000 Date: Wed, 14 Feb 2024 16:35:17 +0000 Message-ID: <8634tv57i2.wl-maz@kernel.org> From: Marc Zyngier To: "Arnd Bergmann" Cc: "Randy Dunlap" , linux-kernel@vger.kernel.org, "Geert Uytterhoeven" , "Rob Herring" , "Philipp Zabel" , "Peter Rosin" , devicetree@vger.kernel.org Subject: Re: [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it In-Reply-To: References: <20240213225619.11726-1-rdunlap@infradead.org> <867cj75q52.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: arnd@arndb.de, rdunlap@infradead.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, robh@kernel.org, p.zabel@pengutronix.de, peda@axentia.se, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 14 Feb 2024 16:06:06 +0000, "Arnd Bergmann" wrote: > > On Wed, Feb 14, 2024, at 10:52, Marc Zyngier wrote: > > On Tue, 13 Feb 2024 22:56:19 +0000, Randy Dunlap wrote: > >> > >> diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig > >> --- a/drivers/of/Kconfig > >> +++ b/drivers/of/Kconfig > >> @@ -80,7 +80,8 @@ config OF_ADDRESS > >> > >> config OF_IRQ > >> def_bool y > >> - depends on !SPARC && IRQ_DOMAIN > >> + depends on !SPARC > >> + select IRQ_DOMAIN > > > > > > This seems to be moving is the right direction. > > Can we move the 'select IRQ_DOMAIN' under CONFIG_IRQCHIP > then and remove the individual selects from the irqchip > drivers? It looks like CONFIG_OF (other than sparc) now > unconditionally enables OF_IRQ and IRQCHIP anyway. As long as it also works ACPI, it should be OK. M. -- Without deviation from the norm, progress is not possible.