Received-SPF: pass (google.com: domain of linux-kernel+bounces-65506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 linux-mm@kvack.org, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Mcgrof Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 6/7] mm: truncate: split huge page cache page to a
 non-zero order if possible.
Date: Wed, 14 Feb 2024 11:19:18 -0500
Message-ID: <1C274CBB-C809-442E-9575-858460C0F62D@nvidia.com>
In-Reply-To: <cbb1d6a0-66dd-47d0-8733-f836fe050374@arm.com>
References: <20240213215520.1048625-1-zi.yan@sent.com>
 <20240213215520.1048625-7-zi.yan@sent.com>
 <cbb1d6a0-66dd-47d0-8733-f836fe050374@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_61BFBE49-0C64-490F-8FAA-24E0AA16EAC7_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uyH1KNfomN6kmPf030lTA1cnjrfuhcc1VP0xxoQKuLnt9Le24MACgzDs3fN0?=
 =?us-ascii?Q?QBPYZLUG5gY2f8YjngAf5avJaRJne0riOd5Xz65FWBp+kGxk3MUqZJy3iEkq?=
 =?us-ascii?Q?YChHbOjKe3j8u7hoTGjuRrmrLoUCGT85pr2UO7eXTZjg+gOLrgiX/HGfL5wE?=
 =?us-ascii?Q?kusHMIz5zVfC4xG6sTrNCxOsnYWFQqLTvM5vpJzxXEB1sL0RaYX9s9sGDb37?=
 =?us-ascii?Q?cOPsFCneCJsk8XbnM3vjGBsmUU1OpzXSAmej20wL1k/FSSQevhGREUYOpAdJ?=
 =?us-ascii?Q?5b+ZxqSvvsqDC6kl5DRpr6A8B1MBEIs/IljDMsRmSZ9v1XBbyug7HrkRxAoV?=
 =?us-ascii?Q?A3gjCbMUVTKWXAl8VGGOC/xgtRzvChcNcVrtRfFZSvT0bY8NVLuYFwJOdniC?=
 =?us-ascii?Q?httX6r3aigC0RL6wyklWmlzqjjpyv0Bf5iOy4JTv8q6mDqRgr5WTAZUDKb2/?=
 =?us-ascii?Q?NGwaFpupInxwweAmjUVV1pR2Rx3dkvgJHlqwS2ZilqGZ2MJRjab1mzMZWNGK?=
 =?us-ascii?Q?2K5ej49W4BGxLxH2ju38QnRdPOa+yR3Cw8KBtgX82m+gZ7IrfuVt3BA/VwEl?=
 =?us-ascii?Q?kx1tz1Esw4SGNG1QOAG519wIoc6OwK6bRF5uf3LLfvqfy55QxPRfpnzn8GZz?=
 =?us-ascii?Q?T0O3DygO0Km6EkQFod2JEkbQOehWJx28+MF6tV0KYRgUnA3LW9UPUVzOjAX7?=
 =?us-ascii?Q?8hBE5eymJENCPWEDZ4pBRBl2yD5BpAQ8AGU7gVOUX/uNtZs6kodXBTnWM8O/?=
 =?us-ascii?Q?4Zf1SFpzEIuqDvhiPidxavbpNK1V5QSCwdlxkRGT/L873/sx0z/eukCrr47c?=
 =?us-ascii?Q?UOkCY5FwHzMva0o+X8Uyeu+eWbcWh8P+AL/T3BAK0pIrnq7XXJSue0nM7p7H?=
 =?us-ascii?Q?cG2hQCWJetczBY+C6VY9l+ZLWxLJ5rAvEZNiMR14z0ega2VQFDBeEE89ucWN?=
 =?us-ascii?Q?xLeg6kGCXz/gWsYPJuxd8uc944LVw1BDQy67qxMdKdHibon9lV55Wm2TrGFm?=
 =?us-ascii?Q?4LHuL4vKLIvPZIYnWg88wqQITqCuGTJGETIbrwg2bYoVxWN7LZAzoJrxuiau?=
 =?us-ascii?Q?9hJKy04ivtliTkmFL5NfA31I95bmzjfkA5+GU+m34cmCIg8klNm049fHOZbi?=
 =?us-ascii?Q?c1na16nTmXw7SY5ChS6tvxkyZYFkavmAwLzgpetolocstvhhRS/kx6NZCGjs?=
 =?us-ascii?Q?Xf3vhPd73/hC4IXZrtqfoApPXO4kw3XmcaacqCQmWFD/9b3JJweZIfCXNMgR?=
 =?us-ascii?Q?CvIWQmERNGdwwV6PobNog3XtU4bkujBNx9hDJHuhicHnCJ8QZffPc7Bep1N1?=
 =?us-ascii?Q?M6Ham7VtTAbHly0tadCR8jYtlmF511U6S+Ceq7DERrTztHM57DcaoUMjm8t8?=
 =?us-ascii?Q?EF8Nw15OPMI8Zsu3ExO/MjZprHVpQ8Az2gHGAYtBfWXqNfUv6o0XuUxLX1mL?=
 =?us-ascii?Q?Ho4w5CnzL1RxacKbXLSqGq26iBwgGmeSqhPdyOqdhbVL/DI/H414kOvEuI8o?=
 =?us-ascii?Q?u5D60RF1Ixz1rE8FpFo0wEL2H3hhq8rXDQzA0haBsu4z0DvaP3DLRjTvXgU1?=
 =?us-ascii?Q?7T2Ox0i3yykwv0Z/v760AHDr7kHoALMhWcjgdf5H?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1814d39b-145a-4d71-9562-08dc2d78b32f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 16:19:20.6514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8A2nrujJxa3yPj1JH6uelMW45H4Rh75eRLWgfK+Va2wlKtz04ii8Pi/Y3bR5DlJA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5181

--=_MailMate_61BFBE49-0C64-490F-8FAA-24E0AA16EAC7_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 14 Feb 2024, at 5:43, Ryan Roberts wrote:

> On 13/02/2024 21:55, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> To minimize the number of pages after a huge page truncation, we do no=
t
>> need to split it all the way down to order-0. The huge page has at mos=
t
>> three parts, the part before offset, the part to be truncated, the par=
t
>> remaining at the end. Find the greatest common divisor of them to
>> calculate the new page order from it, so we can split the huge
>> page to this order and keep the remaining pages as large and as few as=

>> possible.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>  mm/truncate.c | 21 +++++++++++++++++++--
>>  1 file changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/truncate.c b/mm/truncate.c
>> index 725b150e47ac..49ddbbf7a617 100644
>> --- a/mm/truncate.c
>> +++ b/mm/truncate.c
>> @@ -21,6 +21,7 @@
>>  #include <linux/task_io_accounting_ops.h>
>>  #include <linux/shmem_fs.h>
>>  #include <linux/rmap.h>
>> +#include <linux/gcd.h>
>>  #include "internal.h"
>>
>>  /*
>> @@ -210,7 +211,8 @@ int truncate_inode_folio(struct address_space *map=
ping, struct folio *folio)
>>  bool truncate_inode_partial_folio(struct folio *folio, loff_t start, =
loff_t end)
>>  {
>>  	loff_t pos =3D folio_pos(folio);
>> -	unsigned int offset, length;
>> +	unsigned int offset, length, remaining;
>> +	unsigned int new_order =3D folio_order(folio);
>>
>>  	if (pos < start)
>>  		offset =3D start - pos;
>> @@ -221,6 +223,7 @@ bool truncate_inode_partial_folio(struct folio *fo=
lio, loff_t start, loff_t end)
>>  		length =3D length - offset;
>>  	else
>>  		length =3D end + 1 - pos - offset;
>> +	remaining =3D folio_size(folio) - offset - length;
>>
>>  	folio_wait_writeback(folio);
>>  	if (length =3D=3D folio_size(folio)) {
>> @@ -235,11 +238,25 @@ bool truncate_inode_partial_folio(struct folio *=
folio, loff_t start, loff_t end)
>>  	 */
>>  	folio_zero_range(folio, offset, length);
>>
>> +	/*
>> +	 * Use the greatest common divisor of offset, length, and remaining
>> +	 * as the smallest page size and compute the new order from it. So w=
e
>> +	 * can truncate a subpage as large as possible. Round up gcd to
>> +	 * PAGE_SIZE, otherwise ilog2 can give -1 when gcd/PAGE_SIZE is 0.
>> +	 */
>> +	new_order =3D ilog2(round_up(gcd(gcd(offset, length), remaining),
>> +				   PAGE_SIZE) / PAGE_SIZE);
>
> Given you have up to 2 regions remaining, isn't it possible that you wa=
nt a
> different order for both those regions (or even multiple orders within =
the same
> region)? I guess you just choose gcd for simplicity?

Right. You raise the same concern as Hugh[1]. I am minimizing the call of=

split_huge_page_to_list_to_order() and you and Hugh want to minimize the
number of folios after the split. Yours will give better outcome after sp=
lit,
but requires either multiple calls or a more sophisticated implementation=

of page split[2]. We probably can revisit this once splitting to any orde=
r
gets wider use.

>> +
>> +	/* order-1 THP not supported, downgrade to order-0 */
>> +	if (new_order =3D=3D 1)
>> +		new_order =3D 0;
>
> I guess this would need to change if supporting order-1 file folios?

Right.

>> +
>> +
>>  	if (folio_has_private(folio))
>>  		folio_invalidate(folio, offset, length);
>>  	if (!folio_test_large(folio))
>>  		return true;
>> -	if (split_folio(folio) =3D=3D 0)
>> +	if (split_huge_page_to_list_to_order(&folio->page, NULL, new_order) =
=3D=3D 0)
>
> I know you are discussing removing this patch, but since you created
> split_folio_to_order() wouldn't that be better here?

Sure. Will change the patch locally.

[1] https://lore.kernel.org/linux-mm/9dd96da-efa2-5123-20d4-4992136ef3ad@=
google.com/
[2] https://lore.kernel.org/linux-mm/0AC0520E-1BD2-497E-A7ED-05394400BFC9=
@nvidia.com/

--
Best Regards,
Yan, Zi

--=_MailMate_61BFBE49-0C64-490F-8FAA-24E0AA16EAC7_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXM6AYPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhU+4YP/0kcuWm88beYa88Ri/oQZ/05vk4uQRaM0NCX
tIt4f7LWzye/ZfDK1/rjK2C8eT8Q4eDhP6dVJ1JccPZfg78RsAkwt/3Av72U/ShY
meVf0zgMEjL39TZgA87DTt9tk3SW815Om+eHiu5GvfM+9hQULsuL9kBcVvfms84z
N7mnhBUG8n0v9zAiNBMucG1oJDtLhC2rRWd0u7D+WcQheYIeY5t3rBKwAuTZUvlt
mN3vC/pawbs630LPb+fieixGno9KFi6vFhYhexQPSIc2iyh4xzC1VubiIB627ZYP
XJJrgdIFKyNoMdMIMBstn5bWL5Iy3Erj6tj3QZWyCbWa/ELWNWLgXyjG8JYiJtRY
Bpq08LsbI8EsN9yc6608Hdf0aP0bsiIx7PJJHgGDE69XvvUW7jXthAF3Hrxn/REo
ZBFAvcJP6STN2BJcUFTKvAeW3mAtJU50O/xcjKb7L5tF9oBZOVMzk0Dn6zVgeKHi
BBSuAMyv/tfy24OIRVdcXU/zLWPQWsshSDd9boAPfawE5iRKleFjWdTMj1NXFh3u
yqQvN5HzHbkXXW7klQDKo3cOvw/g7NVyoDCRx8q9wFxnrVG39Le7Lj7iIic8eGaE
bgByG+IfE40F6R9uqmPJrnXXxJVGXU50VgqVfbejnENQ7lfFA5kLUDloZ8st9iKt
0vwuFykP
=pOsi
-----END PGP SIGNATURE-----

--=_MailMate_61BFBE49-0C64-490F-8FAA-24E0AA16EAC7_=--