Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp698994rdh; Wed, 14 Feb 2024 08:48:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWEoA4A+cjiwayPubLDFujjX6/fZKmIGkAVio16B0V3bcWhQCnp/Xl1Ajn9CtrnvFCswpABhnbgqJdYxzNGoOg5vZ49++gF+ON+CEJXyA== X-Google-Smtp-Source: AGHT+IGrFgq3NAiRdoKikqXzONfi36K3YaxzzO3uYXs2/0xJBm5acMLQ5zFnr3bQOy3vQoRZkQIr X-Received: by 2002:a92:cb02:0:b0:363:b273:618a with SMTP id s2-20020a92cb02000000b00363b273618amr3780856ilo.14.1707929333494; Wed, 14 Feb 2024 08:48:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707929333; cv=pass; d=google.com; s=arc-20160816; b=XRR6lEK7401C2YML9DYUKSOaRLAafE4MhmzHw+IAnVc6K8smSec0yWPRM/vki53iRx RSnaK4pjl0wCVRrH7uMv83//THy21Fy0bRbtuA/TChzZY0BKDgxR7neUoKe0DvbilSpB y7HWApIgXyl+eaaKFF30mhvrQVUzFFP31x3yVQYXtagQmpHxmst92MFKbLRkeFsxyBeS PACJ17VF6o22gC6zQO+M5azVZeUMxB9lposU9/HLV7aTTAFK6r69UfIL7gF2KKU7F8jK qWf3JkyoxIR7kqkxt94np5yTxBJ85DkG4YlMe2WQM5siC5kyJ04DQ7gVCG2kS0GbkE1D nZOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=i8xijf4NZ5WFUdCaf6/YmN7ADcXmbEJvq3++TEBupTU=; fh=AJESYAPfJMA+UZlPlw5eaHX8NouwmKmcAH3EUC/8NfI=; b=B8PB8RF4CwhCPMVWWNSYviXxjoty/OQkQinPX9WWRwoFYCYaroqoV0q6v8/NQb9s9P xyquOjCMFFXMJlxGGtsJ1sq5ODQdyMW/mocEAnBSuDQDK9kBJuarEKQLVBQo26+53vMK ek5wbC8Bfw0Dyizsy16TLSfDqaJfN/dQ3mWKZRGF/NANwQDHWBRnBrSrH00lKIQW/Ord 4rGtJDVI89a1MYLbWqbQjTMyA3ioAifJtB5INvkVZ5PwNmE03Q106oFV1HFGnYghCrvw r0fyZkVcqS/tyRiatpohAR3sDL3VPIPRfyKXRIndObHuHt2RGW/KATOfAgVYa/aVkDyN fyeg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-65581-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65581-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCWilUHnObBSW1aCDaROYsuiKOI1UXRlwBJvHlnv/DuKIzL1BUwhEOGjEufH3wFC60wmEy7FE4kjPDruriTpOOyu94O53cSqMvGECVpbUA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h7-20020a632107000000b005cfd72d0bc7si3845328pgh.246.2024.02.14.08.48.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:48:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65581-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-65581-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65581-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DA6AD283F2F for ; Wed, 14 Feb 2024 16:45:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 642C760B9B; Wed, 14 Feb 2024 16:45:19 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79562605DF; Wed, 14 Feb 2024 16:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707929118; cv=none; b=F8Cebg936ch+f55ea4y4rrqxlODxnz7iQpP1lecy04uE5tgaN+XcNHEFSU19DWifBDGAS+frkEnrU/xx08rjgVUgcjrijVM6zYTcY9qfl/Xde/AQQ+XXQEf+KyZMcGmSRmYvvYq0eNLYD4bVU6QOmoQoMaUxzwEuNhNDWpCmr4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707929118; c=relaxed/simple; bh=loxfsSL7zxInO0eCeagCCwayO51o50MXlBy3g5U0WeM=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=UxJDYB8YQjAFkRKQFNgqaX9e50GftbxnVmrYcaaEiGaIa4iWl8xkPgCppCic7NFKnxiFivubcg3BK4/JqwMl/+WDYX0WZD7iV5Ewaf3aCvLeXc3S/6AtQbGYKE4IztZZuMIqJFDBXHBftysGocgJnlwiJ+tEtIJknLfbTdJo4zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (178.176.73.178) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Wed, 14 Feb 2024 19:44:58 +0300 Subject: Re: [PATCH net v3] net: ravb: Count packets instead of descriptors in GbEth RX path To: Paul Barker , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Yoshihiro Shimoda , Wolfram Sang , Nikita Yushchenko , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Claudiu Beznea , Lad Prabhakar , Biju Das , , , References: <20240214151204.2976-1-paul.barker.ct@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <041656ca-6029-ade3-97b5-659f73be216d@omp.ru> Date: Wed, 14 Feb 2024 19:44:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240214151204.2976-1-paul.barker.ct@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 02/14/2024 16:30:26 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 183446 [Feb 14 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.73.178 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.73.178 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;178.176.73.178:7.4.1,7.1.2,7.7.3;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: {cloud_iprep_silent} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.73.178 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/14/2024 16:35:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/14/2024 2:42:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 2/14/24 6:12 PM, Paul Barker wrote: > The units of "work done" in the RX path should be packets instead of > descriptors, as large packets can be spread over multiple descriptors. > > Fixes: 1c59eb678cbd ("ravb: Fillup ravb_rx_gbeth() stub") > Signed-off-by: Paul Barker Reviewed-by: Sergey Shtylyov [...] MBR, Sergey