Received-SPF: pass (google.com: domain of linux-kernel+bounces-65584-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>, linux-mips@vger.kernel.org, Jiaxun
 Yang <jiaxun.yang@flygoat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir
 Kondratiev <vladimir.kondratiev@mobileye.com>, Tawfik Bayouk
 <tawfik.bayouk@mobileye.com>, Alexandre Belloni
 <alexandre.belloni@bootlin.com>, =?utf-8?Q?Th=C3=A9o?= Lebrun
 <theo.lebrun@bootlin.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v7 03/14] MIPS: Allows relocation exception vectors
 everywhere
In-Reply-To: <ZcTE8nKCaKuaUvAe@alpha.franken.de>
References: <20240205153503.574468-1-gregory.clement@bootlin.com>
 <20240205153503.574468-4-gregory.clement@bootlin.com>
 <ZcTE8nKCaKuaUvAe@alpha.franken.de>
Date: Wed, 14 Feb 2024 17:48:51 +0100
Message-ID: <87plwzj8jw.fsf@BL-laptop>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Thomas Bogendoerfer <tsbogend@alpha.franken.de> writes:

> On Mon, Feb 05, 2024 at 04:34:49PM +0100, Gregory CLEMENT wrote:
>> From: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> 
>> Now the exception vector for CPS systems are allocated on-fly
>> with memblock as well.
>> 
>> It will try to allocate from KSEG1 first, and then try to allocate
>> in low 4G if possible.
>> 
>> The main reset vector is now generated by uasm, to avoid tons
>> of patches to the code. Other vectors are copied to the location
>> later.
>> 
>> gc: use the new macro CKSEG[0A1]DDR_OR_64BIT()
>>     move 64bits fix in an other patch
>>     fix cache issue with mips_cps_core_entry
>>     rewrite the patch to reduce the diff stat
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>> ---
>>  arch/mips/include/asm/mips-cm.h |   1 +
>>  arch/mips/include/asm/smp-cps.h |   4 +-
>>  arch/mips/kernel/cps-vec.S      |  48 ++-------
>>  arch/mips/kernel/smp-cps.c      | 171 +++++++++++++++++++++++++++-----
>>  4 files changed, 157 insertions(+), 67 deletions(-)
>> [..]
>> diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
>> index dd55d59b88db3..f4cdd50177e0b 100644
>> --- a/arch/mips/kernel/smp-cps.c
>> +++ b/arch/mips/kernel/smp-cps.c
>> @@ -7,6 +7,7 @@
>>  #include <linux/cpu.h>
>>  #include <linux/delay.h>
>>  #include <linux/io.h>
>> +#include <linux/memblock.h>
>>  #include <linux/sched/task_stack.h>
>>  #include <linux/sched/hotplug.h>
>>  #include <linux/slab.h>
>> @@ -25,7 +26,34 @@
>>  #include <asm/time.h>
>>  #include <asm/uasm.h>
>>  
>> +#define BEV_VEC_SIZE	0x500
>> +#define BEV_VEC_ALIGN	0x1000
>> +
>> +#define A0		4
>> +#define A1		5
>> +#define T9		25
>> +#define K0		26
>> +#define K1		27
>> +
>> +#define C0_STATUS	12, 0
>> +#define C0_CAUSE	13, 0
>> +
>> +#define ST0_NMI_BIT	19
>> +#ifdef CONFIG_64BIT
>> +#define ST0_KX_IF_64	ST0_KX
>> +#else
>> +#define ST0_KX_IF_64	0
>> +#endif
>
> please move this together with the other defines in arch/mips/kvm/entry.c
> to a header file (arch/mips/include/asm/uasm.h sounds like a good fit).


Jiaxun Yang sent a series to address it [1]. I managed to rebase my
series on top of this one.

Do you agree with these 8 patches?

Can I send my next series with the assumption that it will be merged?

Gregory

1: https://lore.kernel.org/linux-mips/20240209-regname-v1-0-2125efa016ef@flygoat.com/


-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com