Received-SPF: pass (google.com: domain of linux-kernel+bounces-65597-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
From: Balint Dobszay <balint.dobszay@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: op-tee@lists.trustedfirmware.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 jens.wiklander@linaro.org, sumit.garg@linaro.org, corbet@lwn.net,
 sudeep.holla@arm.com, gyorgy.szing@arm.com
Subject: Re: [PATCH 3/3] Documentation: tee: Add TS-TEE driver
Date: Wed, 14 Feb 2024 17:56:41 +0100
Message-ID: <40BCD479-90FC-4B32-AA97-A7B39CA8A3FC@arm.com>
In-Reply-To: <bbb40718-9bfa-4431-a3b0-c09d068fd6cc@infradead.org>
References: <20240213145239.379875-1-balint.dobszay@arm.com>
 <20240213145239.379875-4-balint.dobszay@arm.com>
 <bbb40718-9bfa-4431-a3b0-c09d068fd6cc@infradead.org>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original:
 TYWtitNlEbaFOtR/Fk2LCIQNdTfH5O/iU5yvUaQp8oA7C2SU2NCVgp2ZhsGj5pWmpKHkIeDfdpthkZ+1jGC8MSCreEHpEsnLq8qS0nF2/gct5ma2tZIpUv7FM0F0K/QND2WxogMtmWXm4RCUeQ5l/wxM6bZ7ppBliAdMFf8DntjoBeIUAT7KUg25dpHEoWOCgnN2VB28aSV7tCimaGHIodU5V2h4Mto8hh1kunnu+o5C4XPk63gaXvXg1Kzg7VdvLm1CCKzrDk91WRZoUZ66Yt2jRgwgQ0rTuFAkPgPxIwXwwSoRk3BfShqCfqqTMRYJFeLt0Wi79PXkMSBNn03ojTqH3lSOL5PfjfmJm1pJpGyYc24bsD65VKtycpc8jN3RteRDIoU2hh7kdcDQgA+9ei1RMBpNCF/qketIbiXyPiKpao3Osr0oHxt24Kds9suUXYSr9uH7a6yN+LZnZqjtNsfRAer+/j/ed9SWualb6alhNxmnTREgF7HZjb0kt8Du2NH8m0QZk4pRnl0zJTA7xEox/FeBv1OtCsWjzDU8tsXgHT+o395/bCubNuKWgTrQ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6093.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(376002)(346002)(396003)(366004)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(2906002)(44832011)(478600001)(53546011)(6916009)(66476007)(6486002)(6512007)(4326008)(26005)(66556008)(6506007)(8936002)(5660300002)(66946007)(8676002)(33656002)(36756003)(2616005)(83380400001)(41300700001)(6666004)(316002)(38100700002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8626
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5PEPF00014B9D.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ae395060-0e67-440e-278e-08dc2d7dec95
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	58uVhAiHnHV4Xe9/vEPnT8FZ+yz4On7WnHEbIVMeS75hWCF2SVkwugMtMpr5QqxTPdEDEaFz8gRn5ehoeNYa3wkLgHdVWGULmGRNqxrlZRyQhRz6hAI1txL7Pj2YnRWUcbnGQG8vk+lgvEQ5XchA9R7sN3oX/CvUcBPJRe1vXzOD0EJC7ERejlqvfKZrrN1gS5aP/TCQuW6B3Bl6SITJC5LJVZKHrZrD0rnosy/789gMv/f9g6tBAWzZUOo+p2pHeGvpQ5DlhWf5R4LU+IvhWIgak6lS+ChlOCVgNHzt8BtC2FGt8DMMPwTCrCE1rs1cpzpTVLIXmyB9k+In5qtuIntOnbU2yTc8fQ0EAh4XPKefqaqBWdgVIfa+diqAKAdPUq3M6P20cUX0yZ3IhkKHIV2GPUC/wCE3H6HjdFAbCT1XRrXHdvAuPA+pOo2rqUXS3IKJs39Zu7exumMdnJ0Y6lDbeSUkQoH9oDIBo3KxYlobcVz08lLDyvwICa79fqoaBLvLch2Rxghv8WLnwEEZBD51VQQy8IwYSbinymgNFgO3nQUYnJd3jCnpmerCrJ7jChmOfjg04qGymYsZDEpjvtnfaCBQuPgWtGJHveKyRYI=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(136003)(39860400002)(396003)(376002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(82310400011)(40470700004)(46966006)(36840700001)(316002)(70206006)(70586007)(41300700001)(2906002)(5660300002)(8676002)(6512007)(450100002)(4326008)(86362001)(33656002)(6862004)(8936002)(44832011)(478600001)(6486002)(6666004)(53546011)(6506007)(26005)(2616005)(36756003)(82740400003)(83380400001)(336012)(81166007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 16:58:06.1932
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c30a2162-5619-4ce5-1ea5-08dc2d7e1d63
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5PEPF00014B9D.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10598

Hi Randy,

On 13 Feb 2024, at 22:44, Randy Dunlap wrote:

> Hi--
>
> On 2/13/24 06:52, Balint Dobszay wrote:
>> Add documentation for the Trusted Services TEE driver.
>>
>> Signed-off-by: Balint Dobszay <balint.dobszay@arm.com>
>> ---
>>  Documentation/tee/index.rst  |  1 +
>>  Documentation/tee/ts-tee.rst | 70 ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 71 insertions(+)
>>  create mode 100644 Documentation/tee/ts-tee.rst
>>
>
>> diff --git a/Documentation/tee/ts-tee.rst b/Documentation/tee/ts-tee.rst
>> new file mode 100644
>> index 000000000000..e121ebbbfab7
>> --- /dev/null
>> +++ b/Documentation/tee/ts-tee.rst
>> @@ -0,0 +1,70 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +=================================
>> +TS-TEE (Trusted Services project)
>> +=================================
>> +
>> +This driver provides access to secure services implemented by Trusted Services.
>> +
>> +Trusted Services [1] is a TrustedFirmware.org project that provides a framework
>> +for developing and deploying device Root of Trust services in FF-A [2] S-EL0
>> +Secure Partitions. The project hosts the reference implementation of the Arm
>> +Platform Security Architecture [3] for Arm A-profile devices.
>> +
>> +The FF-A Secure Partitions (SP) are accessible through the FF-A driver [4] which
>> +provides the low level communication for this driver. On top of that the Trusted
>> +Services RPC protocol is used [5]. To use the driver from user space a reference
>> +implementation is provided at [6], which is part of the Trusted Services client
>> +library called libts [7].
>> +
>
> Fix run-on sentences:
>
>> +All Trusted Services (TS) SPs have the same FF-A UUID, it identifies the TS RPC
>
>                                                     UUID. It
> or
>                                                     UUIT; it
>
>> +protocol. A TS SP can host one or more services (e.g. PSA Crypto, PSA ITS, etc).
>> +A service is identified by its service UUID, the same type of service cannot be
>
>                                           UUID;
>
>> +present twice in the same SP. During SP boot each service in the SP is assigned
>> +an "interface ID", this is just a short ID to simplify message addressing.
>
>       "interface ID." This
>
>> +
>> +The generic TEE design is to share memory at once with the TEE implementation,
>> +which can then be reused to communicate with multiple TAs. However, in case of
>
> "TA" is not defined.
>
>> +FF-A, memory sharing works on an endpoint level, i.e. memory is shared with a
>> +specific SP. User space has to be able to separately share memory with each SP
>> +based on its endpoint ID, therefore a separate TEE device is registered for each
>
>                          ID; therefore
>
>> +discovered TS SP. Opening the SP corresponds to opening the TEE device and
>> +creating a TEE context. A TS SP hosts one or more services, opening a service
>
>                                                      services. Opening

Thanks for the comments, I'll address them in the next version.

Regards,
Balint