Received-SPF: pass (google.com: domain of linux-kernel+bounces-65625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 14 Feb 2024 09:11:19 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, Dan Williams
	<dan.j.williams@intel.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, <linux-acpi@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Dan Carpenter
	<dan.carpenter@linaro.org>, Steven Rostedt <rostedt@goodmis.org>, "Masami
 Hiramatsu" <mhiramat@kernel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>, <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held
Message-ID: <65ccf437ec4ee_cc44c29485@iweiny-mobl.notmuch>
References: <20240206-cxl-cper-smatch-v2-1-84ed07563c31@intel.com>
 <20240214121153.00005c97@huawei.com>
 <65cced1753256_cbc9b29490@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65cced1753256_cbc9b29490@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SP6La1u3r8rZNUk6ItuBXhmXzJiYMWkha/Otzyj73VLSF5Jz+alKsZk20PAe?=
 =?us-ascii?Q?CGVOY2T3JT2ZdF1Jit644hToYp6Dt1tSl/CZ5jTImXrhbq7983Fon/sxIQWT?=
 =?us-ascii?Q?pGrVsBFEfsN+ttl1wxNddiL+IAr71+ediM8+nXMY9OsuYuXaGpV8Spp32e/n?=
 =?us-ascii?Q?OfNFfi5mhTGvXJIj/rXHYYk3F1TMnVsb1U22T2Hf+Zwse2vDaB65rzC72HP8?=
 =?us-ascii?Q?4gKsSv3GxFLRMrWZynAK35hJXr+ie9raiA5684PMoYkfScfVR24FK/XGWLuK?=
 =?us-ascii?Q?b9jPJ12jRgm8LsdjPJW2fhDuoeYsRgFbwSQnAGkjKJudnf3cRhd7oc6be8yh?=
 =?us-ascii?Q?AizyJfq3wIBnEoZxmoPiy4QJcuW0UeX2sQFYnb0xfgPg2trgRNG3u9VUPjVF?=
 =?us-ascii?Q?INIOQzoXjRrtfdQbfbtSepHak7paCDWzWVTijIJFgtQGDuSHmNPw74pyQZ5B?=
 =?us-ascii?Q?spyIFQcHSux/SkkymsZb8VbmyJGVzt5ZiUq8byY49vtQ0hE9ouY2YnJtqqK8?=
 =?us-ascii?Q?Xg9lTjjovRuE1/b6gaRqSDIO95vU3uGdFAHKitDBanEAq2ZZkEBozOLfOEtm?=
 =?us-ascii?Q?zd2aL1Uj60TWDu1g28jSC/n6kKnjTopqyyU6SNY53qjdO+iRrjnY69FredQU?=
 =?us-ascii?Q?uu+dpL22mgzRy4BrVc2pVU6q4XiPQhW/B0VzLEq1KCpC9pow/AGdgWly+Fiv?=
 =?us-ascii?Q?z56LuL3l5s7DVseUt8i3WmLOJmh8RBXqz7FtOTXEBmKNEYg4b/Sw6L+cCxxc?=
 =?us-ascii?Q?LHM9F1M5Y5NnmbTcLvR7UUEgwFPRcPpcgtpeUrLYJ42WJmBrPUcUJ1TJDsOx?=
 =?us-ascii?Q?cRJyrwd02KDMcx6Y+U1F+LUrcXpZheJ0FzdMvaucxsbXdF3/nBDaFA1ajuUt?=
 =?us-ascii?Q?dnf6HWg0P2xnMzpOZUbLOOalgsr9R7wkUIZ74wUf3yCvKi6LZxH1DTkgXPMR?=
 =?us-ascii?Q?WULMMt8Wrs1MelExjVaT1MkrXjt5By64CK2O49Lpiky/oZ5zTesh1ErBTsKP?=
 =?us-ascii?Q?92AqDf4dzrdEhf0kdsaRVXzQujafbtBcpNTiV5PeVOxSelUZ/I0TVlEqf1+s?=
 =?us-ascii?Q?VQPjML9ek1wq5395qKvaiLyoOctMe22BgkaBv6zbX93WyXvpYqpibIvCTaRL?=
 =?us-ascii?Q?nQkzuGWfd8J/Pz3oIvY735olyKEdvV9W7rOqwcfwVVSFoRSUZihN5Ht6vLYp?=
 =?us-ascii?Q?gi/oiWSPUbGdVydB3YHsGHW6W1fyN/UtMIXUJAA2/v/eAvJ0TlYgLAHhqb29?=
 =?us-ascii?Q?OCrQla1veG2hW0X53AM/tUb2AeNexsrearVYKN+ZXTOgQOO5rmrsUhWVLX8y?=
 =?us-ascii?Q?3DY7NR/oft7lX1XPboTE/km0ZDPZ8alM2mwgAU5P515IARrm7ovbk3PgrU4E?=
 =?us-ascii?Q?L3v1W6+1VVNCO3+sa26wxvgH0ToBsMLZezcmvgz/zJuTbRIfUibMBtpCsR84?=
 =?us-ascii?Q?DjGJficPdBEwOZD6JzRL+GZlKWCU/Ipbp93S9BAcj8mHcqWc3UIv1RrxZov5?=
 =?us-ascii?Q?LfHh7Cxho4xsY7H0TE23nLZdcuXd7OH1+LTAlU/+jiu2WF0m+W93U3KUC1a+?=
 =?us-ascii?Q?f564ld3ijGze9NsIpl/KveQ6m90W3oodhs3w1PsV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccada1c-7831-46e2-c474-08dc2d7ffcc6
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 17:11:30.6461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AX6uVSvMSJPL51DxuO6PtOWaTC5IiGWUCKNfrvJCpYNtzv7AIYmPxTnTtVURRbeFZ1HUa4SCq8kKGhtJ5yryzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6889
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> Jonathan Cameron wrote:
> > On Tue, 06 Feb 2024 14:15:32 -0800
> > Ira Weiny <ira.weiny@intel.com> wrote:
> > 
> >

[snip]

> > 
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 9ff8a439d674..7ee45f22f56f 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -2957,7 +2957,7 @@ static void output_printk(struct trace_event_buffer *fbuffer)
> >         iter->ent = fbuffer->entry;
> >         event_call->event.funcs->trace(iter, 0, event);
> >         trace_seq_putc(&iter->seq, 0);
> > -       printk("%s", iter->seq.buffer);
> > +       printk_deferred("%s", iter->seq.buffer);
> > 
> >         raw_spin_unlock_irqrestore(&tracepoint_iter_lock, flags);
> >  }
> > 
> > My assumption is similar views will apply here to Peter Zijlstra's comment on
> > not using printk_deferred.
> > 
> > https://lore.kernel.org/all/20231010141244.GM377@noisy.programming.kicks-ass.net/
> > 
> > Note I also tried the hacks Peter links to from there. They trip issues in the initial
> > CPER print - so I assume not appropriate here.
> > 
> > So I'm thinking this is a won't fix - wait for the printk rework to land and
> > assume this will be resolved as well?
> > 
> 
> Or could we avoid the situation entirely by using a static call?
> 
> The work queue still needs to be created because of the atomicness of
> ghes_do_proc() but it avoids cxl_cper_rw_sem.
> 
> I think the hardest thing may be writing the commit message to explain all
> this.  :-(
> 

Never mind, I already went down that path.  I was surprised I did not
mention it in this commit message.  I did in V1.  :-(

"A static call was considered but ARM does not select HAVE_STATIC_CALL
and in that case setting the function pointer uses a RW semaphore."
	-- https://lore.kernel.org/all/20240202-cxl-cper-smatch-v1-1-7a4103c7f5a0@intel.com/

Should have carried that through.

So should we revert ...

	Fixes: 671a794c33c6 ("acpi/ghes: Process CXL Component Events") 

.. and wait for the printk fix or just move forward with this patch?

Sorry for the noise,
Ira