Received-SPF: pass (google.com: domain of linux-kernel+bounces-65680-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 14 Feb 2024 17:29:36 +0000
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andrey Skvortsov <andrej.skvortzov@gmail.com>,
	Icenowy Zheng <icenowy@aosc.io>, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: magnetometer: Add DT binding for
 Voltafield AF8133J
Message-ID: <20240214-boat-drapery-3f957d393ccc@spud>
References: <20240211205211.2890931-1-megi@xff.cz>
 <20240211205211.2890931-3-megi@xff.cz>
 <20240212114738.0000535b@Huawei.com>
 <i2q2vntbhilrpwppzl367ndoetbyd6guyti4t4n7vtg5pwq7bi@tjkio7zpwrfw>
 <20240214163116.000031b5@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZURdXPkQnAo0vG8A"
Content-Disposition: inline
In-Reply-To: <20240214163116.000031b5@Huawei.com>


--ZURdXPkQnAo0vG8A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 04:31:16PM +0000, Jonathan Cameron wrote:
>=20
> > > > +
> > > > +  dvdd-supply:
> > > > +    description: |
> > > > +      an optional regulator that needs to be on to provide DVDD po=
wer (Digital
> > > > +      IO power, 1.8V~AVDD) to the sensor.
> > > > +
> > > > +  mount-matrix:
> > > > +    description: an optional 3x3 mounting rotation matrix.
> > > > +
> > > > +required:
> > > > +  - compatible
> > > > +  - reg =20
> > >=20
> > > Any power supply that is required for operation should be listed here=
 (even though
> > > we can rely on the stub supplies if it isn't in the DT).
> > > I used to think this wasn't necessary, so lots of bindings upstream d=
on't yet
> > > have it. =20
> >=20
> > By stub supply you mean dummy supply created when the *-supply property=
 is not
> > specified in DT? Or something else?
>=20
> Ah yes. I got the term wrong.
> >=20
> > Because DTC_CHK prints a warning if I make the proerty required in bind=
ings and
> > not specify it in DT
> >=20
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2b.dtb: magnetomet=
er@1c: 'avdd-supply' is a required property
> > 	from schema $id: http://devicetree.org/schemas/iio/magnetometer/voltaf=
ield,af8133j.yaml#
>=20
> Provide one, or don't worry about that warning.=20

For the sake of the platform maintainer, please choose option 1.

Thanks,
Conor.

> Various discussions have taken place on this over time and end
> result is bindings should require them to differentiate from power
> supplies that are actually optional.
>=20
> Jonathan
>=20
>=20

--ZURdXPkQnAo0vG8A
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcz4gAAKCRB4tDGHoIJi
0t2XAP4nJHA2b9GYmFqXkv+07/EH+A0d1pTP+qFxL6MbEPfAnwEA3fFVoQUTBNDE
m/cQ44UUEixiyx9FrScrbk45rvjqEAc=
=0zCn
-----END PGP SIGNATURE-----

--ZURdXPkQnAo0vG8A--