Received-SPF: pass (google.com: domain of linux-kernel+bounces-65712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 14 Feb 2024 18:48:00 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Raag Jadav <raag.jadav@intel.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, 
	andriy.shevchenko@linux.intel.com, lakshmi.sowjanya.d@intel.com, linux-pwm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] pwm: dwc: drop redundant error check
Message-ID: <en2sbqjmqvo5ka5l5wz4qgqmiv3ivjy7zsjtwc3cgi7nlcgkv7@kuammu3tbjez>
References: <20240212130247.9985-1-raag.jadav@intel.com>
 <20240212130247.9985-3-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fyfi2hhyykxly2x4"
Content-Disposition: inline
In-Reply-To: <20240212130247.9985-3-raag.jadav@intel.com>


--fyfi2hhyykxly2x4
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Feb 12, 2024 at 06:32:44PM +0530, Raag Jadav wrote:
> pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> check for failure if the latter is already successful.
>=20
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/pwm/pwm-dwc.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index a4a057ae03ea..b9e18dbf7493 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -50,10 +50,6 @@ static int dwc_pwm_probe(struct pci_dev *pci, const st=
ruct pci_device_id *id)
>  	}
> =20
>  	dwc->base =3D pcim_iomap_table(pci)[0];
> -	if (!dwc->base) {
> -		dev_err(dev, "Base address missing\n");
> -		return -ENOMEM;
> -	}

As just written in reply to v2, I'd like to have a comment here saying
that pcim_iomap_table() won't fail after pcim_iomap_table() to prevent
someone sending a patch that undoes this change with the reasoning that
pcim_iomap_table()'s return value should be checked.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--fyfi2hhyykxly2x4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXM/M8ACgkQj4D7WH0S
/k5eVwgAo8+fgjlPKlOVwdu4zufeEVTAJWo/ckkPRL12W2oWFVezhopw9ddhT6KI
A879ca/VmSc6GJjtLxClCi4cKtuCnKJ0cslZJt4uXIWXcPxSiuoQijspBLjHl2wo
I2V1dA7M23LXHsuhq+Goz9K2f6rAuLZ6oxHPARpNKBAZUcTdUp2Sz1rJ46lN9GBe
vnFwKTc0wgWn06bPkTKl7XUTwYLyoddbTxw5MIHLy0FsSwzq556tycMCm4bsLYwd
IAK2e78vsVgrK+q9QyfrivhiWxwVA47N5L3SG+8u1dYlBo2fXTv7/SQ9kTowykey
OS+oV7Zr8h+1BCBht5BT2FByeIhhqw==
=NEiF
-----END PGP SIGNATURE-----

--fyfi2hhyykxly2x4--