Received-SPF: pass (google.com: domain of linux-kernel+bounces-65794-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9250d604-61d9-4fad-a83c-719851980ba0@oracle.com>
Date: Wed, 14 Feb 2024 12:48:09 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 1/3] vhost-vdpa: flush workers on suspend
Content-Language: en-US
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, Si-Wei Liu <si-wei.liu@oracle.com>,
        Xie Yongji <xieyongji@bytedance.com>,
        Stefano Garzarella <sgarzare@redhat.com>
References: <1707758174-142161-1-git-send-email-steven.sistare@oracle.com>
 <1707758174-142161-2-git-send-email-steven.sistare@oracle.com>
 <CAJaqyWdOYHA21A2JUwnTmWfSro7H0ZTTTkkH7Ot9F8hwK+TKXw@mail.gmail.com>
From: Steven Sistare <steven.sistare@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CAJaqyWdOYHA21A2JUwnTmWfSro7H0ZTTTkkH7Ot9F8hwK+TKXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TW43YmZkR1JQeTVNYnVqQld2U0tGejc2NWI4YWxiSlVOQk1HTzY4WlNxY1Jj?=
 =?utf-8?B?a0JBc05uc3RYYmxrK1VmWG9pTktUWjBNRlgyZjVqNDE5WTNaZlgvSEpDM0dM?=
 =?utf-8?B?RHJkU3BpdTJUblVGR2hhU0RiZ1lsZkxTUkxDa1V1enEvSkpGMlM2dGJuZ3NN?=
 =?utf-8?B?UndITHNHdUtna1NNM0tIOTVrTU0vbktrM2RKRVpTeU1JcXdWaENWQVFjQTVn?=
 =?utf-8?B?cVVHMjRUNHVSUTRSdzY3Zmp2b1dKZlFiOHB2SThySjd6djJLTmpCbTFtU0lw?=
 =?utf-8?B?aUF1eU9zU042U1BHTEJhNmNkVEE4YU5ZVjlMcC9PUkJmWk0xRjdmSEhvSE1N?=
 =?utf-8?B?MDNtbEt2SXNyN1hhTDIyL0VCcTFya0xrQ1BUNHNWeEd3aWxKUzNLZVVkelZ5?=
 =?utf-8?B?SDBhelBZL3lBT3NGK3ZlNEUrUE1iZDdZeVFaTTZuaG5rVStCOTg0aThoLzlF?=
 =?utf-8?B?VEFMVDJRRGpTakE2VURnMHByVlg3V0QvOXNubHV6dXV3ZmJCUjl5aEl6VjZu?=
 =?utf-8?B?VG1ackVaTGFrTWlOeXRUbHg5b1B2RFBPWjFRdlVBaFVtZ0JRcGZlZE5sRTFK?=
 =?utf-8?B?b0dyV0JXSXBwWWlmWVlrVzZIUDJQN0d2MUxBSDZMSG9FNmdObkRGM2RmV1Mx?=
 =?utf-8?B?L0xhejVXeUZwV0tJNjloQkNmSlh5T3hNUlVlU0dDdzlQcXExdFhEWjc4aGdJ?=
 =?utf-8?B?OGwzWFcyekV5ZjlTZ2dwL1FFZEJwTFBEUXBsNHVVYXV2Rm1pQ3hQVkJURG5T?=
 =?utf-8?B?MW8wNUlEU0xUNkNSQVpxWkt5bEIrRWIra2h6YVhxdTN0SmRpcGFoMzR4L25C?=
 =?utf-8?B?alpQaVowR2JMQlI0eEtJUE8wMjZFS05zV09rdnBDSExhVGphQ3RtajV6SlpE?=
 =?utf-8?B?eHh0TEpaY1ZrUUtQUEVBeFl6alpCUmV0Qk4wRTRQWm5EN3Jwc1RicGJBa1k3?=
 =?utf-8?B?U2FKdjJ3cWhzdjhJbE81ZGpGeDNoYTlGanhrakFFb2VUL0RRVTh5Q3BuR1E1?=
 =?utf-8?B?QXlSeEdIckZOdnQ5WjRsNVcyL3ZuWW1Zc24wd3FJb1pJdHhOVjV4ekNrZjd2?=
 =?utf-8?B?VGtQeEZYQ08xZTVSd2dMMitXY1NZWXZmdTJuQ2pFbEsvdEcxeG9vbFMyR01w?=
 =?utf-8?B?WVBTKzRpNEM2OEVkYVo4Znk4YjVJeXlEODRDYTBCMUxtWkdxbUJaamY1VmxD?=
 =?utf-8?B?b1k3S0dQMm94czJxU1RkY3ZNZVRtMjk3OHhnWmFRUnNzc0ZoN1NiZjJJMTFl?=
 =?utf-8?B?QVR3ZWF4ZjZtSDZjVGREN3RBR2dwY01lUU5NUncvaTJWNENwaVh1NmExUUN1?=
 =?utf-8?B?QVpLUHFGTTVIL0xKbERGU2Z0NjZvRGJYVmgvb3NmZG51VEVyV0FkOUhGeW5h?=
 =?utf-8?B?UlRwNTFubUZkOEsybURxUzRuM0FQaGI5VE1PT0VMelMvaHlQVEpXeU1YQUhT?=
 =?utf-8?B?MGVMSmRITWJXVUZXcTV6ZU5rMkhQZ2gyWG9pOHFxZGpjTXpHb0gzR3IwaldY?=
 =?utf-8?B?T1RJdWVwSXdPODVZMEMwcXk3cDMzSVJabWdWTmlNem5ncU5IK1Y0UklvVnBv?=
 =?utf-8?B?UFJib3grOE5oS1U1UDhzQ2t5am5RLzk0QmZqcGVmMWFTQ0JKc1dtK01NR2ZT?=
 =?utf-8?B?UEphN0tLQlR0SXhzNFFwWFJMUWd3Q2hlRlBHMHNWVFRDMitkeTYzY3VsMjVN?=
 =?utf-8?B?TUV3QkJjaVpMOWlEaStYd1paZDliT2QyMzhUTnQ3akNHY05UbXpNNFM3WVN5?=
 =?utf-8?B?YVdidGxQYXRlb1YrTW1veTVHUFZkQ0RrdHFTZFVmOG9RMjk5MEs3cTNWN0xz?=
 =?utf-8?B?T0pxVUsvZElicm1rNWphallFM2tkRTF5YlFlSGtNWEpGRW5abC9LM1lIRXhQ?=
 =?utf-8?B?em9rL21rS0lxdFo1RUFGeWk1MzdOTy9tZjlUQXFsRS9oOVIzZDBQSHRwYytS?=
 =?utf-8?B?Y1d0alNFWElWOXRud2pPc05CeWJYQjd3K0t3cFByR1JqOFlRYytzT0tvWWhw?=
 =?utf-8?B?Rm1ZeFlrb2FXQ3pSRG4wa0lQa2hZZUNhemtQRjl5M3VQTWtTdjRrTUhPNHlX?=
 =?utf-8?B?eWRGOWdTbE1XSVMzWU03L2ZERWkrN25oL2NvR0FibEJOcmV2bmxKOFU1Nldm?=
 =?utf-8?B?aHNCVjVFbWU5dVlZQUIyaGlRbW5zb0V3b2wydGlPQXZaYlJzTCtJUTNPN2dO?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	WNbwjBEfRbfLwGsPsHG6MEtrgijJlwbPWkgpL/xfxMruCcf095o2Et4tjwE/H9bHHrTsCXkleJqV9LK0XFi9cUC/8lDh9/tVA75eoRynLeyssMEbfVps9gW0qXU616fh0Us7RUJB1JiXeAFBWIk7q8hVGIdEJWkz849+d8geTzZ0eDw+3EpbYTiyQYfgPQBvpHGdnmA8yev5Wm2MrhdPaaifWJHG8WnmK8KQk/+ibQtNUXb4IAB5QrzD+gl4G2YBNn3Yt1v1ut915eqo439nn5O3QcvRnr03aG8VfFjPMfE7SuI0Y3TdlWcMNt1dTPG/wJIMr3lH4NGkGA89UDbNNZyk7W2d5m+oEE3AhIWQmmnXK4jP6fK0SjpJyl+eom9oID7UZ16u2ciTjeYcRjXBlbc/EI3gWvsiisWfuRICZkMskYwKd+1Y2dl4r0Obr/SKazR5p5Ofkgrc90sA6ya3B43NndHUEr0WAQsE8aGKEyrHf3u1PjeobaOzSH9a3dACa0u6G7HaCOpWnHFDK5/OxteOfBVs6Lk9k8g+mt3SBrZgzh1cO7/7I+LWXX/icTuTZtBSVNAS8329zNo0vn9lhN9GehvAApgZ1XU1IvdfEjI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36a0590c-7a88-49a3-30ee-08dc2d851e45
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4684.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 17:48:14.3028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h0yYel8wyYXuSvhMiGFJnXXiViUlftbeLj1BTod1LWCxTpU5yWH1E6Qc6ARNQPKuqTG6m8woHZjzRqLoSTUjqG4mXCgyldVKEyivF71o4Rc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7356
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-14_10,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402140139
X-Proofpoint-ORIG-GUID: 7G9Q1f3AP0kDVYM-C0SrUvoexwgczZx0
X-Proofpoint-GUID: 7G9Q1f3AP0kDVYM-C0SrUvoexwgczZx0

On 2/13/2024 10:58 AM, Eugenio Perez Martin wrote:
> On Mon, Feb 12, 2024 at 6:16 PM Steve Sistare <steven.sistare@oracle.com> wrote:
>>
>> Flush to guarantee no workers are running when suspend returns.
>>
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> 
> Acked-by: Eugenio Pérez <eperezma@redhat.com>
> 
> Should this have a Fixes tag?

Sure, I will add:

Fixes: f345a0143b4d ("vhost-vdpa: uAPI to suspend the device")

- Steve

>> ---
>>  drivers/vhost/vdpa.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index bc4a51e4638b..a3b986c24805 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -594,10 +594,13 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>>         struct vdpa_device *vdpa = v->vdpa;
>>         const struct vdpa_config_ops *ops = vdpa->config;
>>         int ret;
>> +       struct vhost_dev *vdev = &v->vdev;
>>
>>         if (!ops->suspend)
>>                 return -EOPNOTSUPP;
>>
>> +       vhost_dev_flush(vdev);
>> +
>>         ret = ops->suspend(vdpa);
>>         if (!ret)
>>                 v->suspended = true;
>> --
>> 2.39.3
>>
>