Received-SPF: pass (google.com: domain of linux-kernel+bounces-65816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 14 Feb 2024 14:37:55 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andy Gospodarek <andrew.gospodarek@broadcom.com>,
	Christoph Hellwig <hch@infradead.org>,
	Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Leonid Bloch <lbloch@nvidia.com>, Itay Avraham <itayavr@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	David Ahern <dsahern@kernel.org>,
	Aron Silverton <aron.silverton@oracle.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver
Message-ID: <20240214183755.GH1088888@nvidia.com>
References: <20240207072435.14182-1-saeed@kernel.org>
 <Zcx53N8lQjkpEu94@infradead.org>
 <ZczntnbWpxUFLxjp@C02YVCJELVCG.dhcp.broadcom.net>
 <20240214175735.GG1088888@nvidia.com>
 <20240214101126.0c3681ee@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240214101126.0c3681ee@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YbvtAa8r6pZQ8IoYVn9GsmKlTps31wcBGtUeR/KUgwD4U0oWjwpwWAtjKT8K?=
 =?us-ascii?Q?QkPK2G/az32FtCuUSS+zIDmL51Kq36EVagEEdc6jkMOp/G5jczeo9KuhLM+0?=
 =?us-ascii?Q?Mtdotpcd5Vdsh/J1KDtRjnfBBRy/Ujr5Zc4oLxvGLYx1YwarQ3A0Majuxzn4?=
 =?us-ascii?Q?Uo++Pvknm1GLaKCTeB7Z2/4rTEUCLNdawBitjRk2wl2Iiy637Ar0jxvUUUE+?=
 =?us-ascii?Q?muK71Hnav3ASjgPld93A3NicoO97lIjOGmUmlGED37ZYnIe2qGx6AEzob9xP?=
 =?us-ascii?Q?2bpLwj1rv81uW1JFi932MuutiBJWtheAoxtL8ul6NpeO9unRNZmicdxv5Fdo?=
 =?us-ascii?Q?ociBsRrNKG54iBTgHo3uEEVmGl2VJki13AMQFQXirgK65+Aq3ihpJt/Gu+1Q?=
 =?us-ascii?Q?O7YzGQxAXD0UprjJ9OYYnoDPESdhP+Xo4YQygJ0ANEfqhfnd/+n77KafO20G?=
 =?us-ascii?Q?D6rY9AqnGSv0U3dzt3tH1cq7xzgj+vmtm9AXaGvhQNLQobmgQ1XcXtP1/Y0m?=
 =?us-ascii?Q?RElUDAn1A+j/fRtlFKh1+Ucj9FlEcyzOEkoP/OB6+wZ5aFWTk2lskX6lxK8L?=
 =?us-ascii?Q?KnsQR4msILkISbMdFGgs2uOo5POy89uZXNqa1p54Wufc+Nd2ELX+KrjslQoO?=
 =?us-ascii?Q?1JL17uVJI43uWz+Sd+JQ8wIbPBVRp7XBQZ7607O/r5VP8Zx+Ut6wsRk8TwWW?=
 =?us-ascii?Q?/aR62wYH4mVzPXPLWrc61MWdVhvKWFxz0iw0mMhUtuojAZRgvEo9JU7v1vJp?=
 =?us-ascii?Q?IYrxu1KywPoSjXKyRrACHq6edva4zyRI1JYTBtxsfVLMd8ACJ+RqhBVGcApy?=
 =?us-ascii?Q?U6LNUYwOnY7zECLcoAB6cl7SsYObPmQxH60NHWgl+mDhJV3MxBBC1y9aTm1Z?=
 =?us-ascii?Q?I9f4Mb0bkgvG38Y8SJ/JigcSY5ywYWKP+ns62q0eFArb+oBoKGXX0Wy24G46?=
 =?us-ascii?Q?FH0Jygyyk/q13FPs/jwtsDKenrX5RTMq34nLw48iMOy98JuByjf5VwDX0Wyq?=
 =?us-ascii?Q?7k+B+Dz88DBFXAN8mw6U64gYAR5Bo7gHSlgirk2RmTwN90AB9Qsi6aRt5mjc?=
 =?us-ascii?Q?IdZBShV2EYoJcvnyPGuFFsbbadmg+R0WS8GbLPb9eiXAsTRD7LotEjvKHiJc?=
 =?us-ascii?Q?qyiwgfCV13M4OT+xFZblAGocWiLfcFTXPhm9NXSFRwLfmvmPLqg5G6f0cR0v?=
 =?us-ascii?Q?PlnxqxODDrMAqbuXYnlV7e/VLNXCsrolYcE2FVVKss3uBq40yMpfHuZUSmFW?=
 =?us-ascii?Q?pTFvn9r9C8jqHMlthwW9ptjTLHcMAqxIOzSqJMwadeM/kc1/TBhpM0IKh3aH?=
 =?us-ascii?Q?aq+1Hz050M58n5PiMzL6OlHYLFeP8GNjkaxGoAwfEyPuMarKVgQMiRiDkRDo?=
 =?us-ascii?Q?xlIrsib8XuGmt92DyYi9RZKHF5xwcr7V2tR2bdmdyWf/9nwOZrIaQoFynokk?=
 =?us-ascii?Q?d3wwRl/5vJ+CpJh/YeL1dkqPV1TEe69hsYUfb0VHSd5iiAOmWxCdIc6YwF54?=
 =?us-ascii?Q?NqSxntorJKTkjuw/TVIL+DLpVFNuR7Q7Mi0bNX2IZF8ndjx3+SomSK8MeESA?=
 =?us-ascii?Q?cTtfLB6U53G7OdjekyQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17ec4bb9-63c9-449c-e2f2-08dc2d8c0fb4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 18:37:56.3345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJZe2pJ7ugtqxcByhcJTcGlrE4Jix/hOFt1XgCv0IDTA9WDqReFupj8dTJJrkfvo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6160

On Wed, Feb 14, 2024 at 10:11:26AM -0800, Jakub Kicinski wrote:
> On Wed, 14 Feb 2024 13:57:35 -0400 Jason Gunthorpe wrote:
> > There is a clear split in my mind between:
> >  - inspection debugging
> >  - invasive mutating debugging
> >  - configuration
> 
> Yes there's a clear split, and how are you going to enforce it on 
> an opaque interface? Put an "evil" bit in the common header?

The interface is opaque through a subsystem, it doesn't mean it is
completely opaque to every driver layer in the kernel. There is still a
HW specific kernel driver that delivers the FW command to the actual
HW.

In the mlx5 model the kernel driver stamps the command with "uid"
which is effectively a security scope label. This cannot be avoided by
userspace and is fundamental to why mlx5ctl is secure in a lockdown
kernel.

For example mlx5's FW interface has the concept of security scopes. We
have several defined today:
 - Kernel
 - Userspace rdma
 - Userspace rdma with CAP_NET_RAW
 - Userspace rdma with CAP_SYS_RAWIO

So we trivally add three more for the scopes I listed above. The
mlx5ctl driver as posted already introduced a new scope, for example.

Userspace will ask the kernel for an appropriate security scope after
opening the char-device. If userspace asks for invasive then you get a
taint. Issuing an invasive command without a kernel applied invasive
security label will be rejected by the FW.

We trust the kernel to apply the security label for the origin of the
command. We trust the the device FW to implement security scopes,
because these are RDMA devices and all of RDMA and all of SRIOV
virtualization are totally broken if the device FW cannot be trusted
to maintain security separation between scopes.

Jason