Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp6010rdb; Wed, 14 Feb 2024 10:56:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUs+RLjSh2ZbCAKAfliB2qbyLSCCW24EmAXTkWCDhxxYLE0CpOFxne+lixEHcDuFFMX3qY1PFAdDd0YfBRkK3e69PaiLVCwA3xThgWssA== X-Google-Smtp-Source: AGHT+IFhyjHvHfBBw4H1+pAEOT4XCWDcVIve20wtDlInS+tUS8wJO1ViwcAPbdqyOTCvVCZ3YZF6 X-Received: by 2002:a05:6402:150f:b0:561:ca31:a52a with SMTP id f15-20020a056402150f00b00561ca31a52amr2117239edw.36.1707936971276; Wed, 14 Feb 2024 10:56:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707936971; cv=pass; d=google.com; s=arc-20160816; b=1K0jI87XTVGC52CoNsntJDuAhxCtgEHkxvRcXrIB39nXHxVq2MaQwGQZxloxwRTAPl JSKAht1WY9L52KSyezx59ugGmex3daomoo1HDRCSjpGrMjfvE2cPIhkydp/FGDia3H8N 6r++/FLK858E3HR4N5p8YCN0Q/tgnErN5aIWVwcJ3f9cqaCiP8rVfV9UvMwskYFmGcIL K8LCTBgrvy27Chrm4dGdh5D5X20GdvlGxc1trdXNszpQ27p5xW9ZBgIHI5DoI5sVjD8s 3boslFU1ykxQ/zM0U9DZ9JdahJ1bYF840KMq4QpUgulWWNvOymc+c1LfYHVTJ8nRqElK YIiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=F8pBojG5Ph+1av2r+/vw8N+d3NzUsR2t80fTE8XJw6Q=; fh=huz4bdNjrnY38uuKu/DgBJPSb8uGrJiANkNiT3DcJYo=; b=d1PfAbO2MQwBzVKWyXrXQEhfoyJ8GHp9nKC5DJ1qgIUtdlvHb3rBkBvsRxfj3BEfin 9COqP3vL2NG5Dd3KeYazxW9aN2QA8ea0UntYn2rDxjNz40syurxALwSitx0a4UlRTT51 rH2zd3M+9eAXlUQT3TJPjz2OOdlitOq2o+YzTYzcTAmUZG0LCIvsbrQAYRsxmARA3wIW Oq5AnWBWCm/bUs0oq5ULaMGPD+p9ypGv7gxAF3pMCkpEiGjLbmm2csDfFqv1VzrAfk7+ pTfq1KsrjJ12JBYV05v3kFuZlDh0NlZF8lnem+roOz5I6hv5jGsc1sv9eJRxANaW5toU uAhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=apMZOWPT; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-65846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65846-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCX22aeWFGh95eBwKOZeMlhqHoW0ac1jT/+YH27W4MKFB0+wbE9AW91QtYoEC6FXNBnU7kFl1lsiStGmi2W8sqKxGf3PyYgb2pOZ0AYIcw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id r24-20020a056402035800b00561e66420a5si2178410edw.625.2024.02.14.10.56.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 10:56:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=apMZOWPT; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-65846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65846-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AEB5D1F2B294 for ; Wed, 14 Feb 2024 18:55:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC2F612D768; Wed, 14 Feb 2024 18:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="apMZOWPT" Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E681139571 for ; Wed, 14 Feb 2024 18:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707936921; cv=none; b=ns82qG83geCya8cHTxmK5pTfb2EkoThL7T4pHtpQa0DTE1KAZ8jIX0Yejkc498HacmMc1ith/aTZNtIiVnAwxq5daXmXXHIOncs8TPdHwx3EBbxOwynn/ipiSvSjrnOsqaoHb2uQu3keJ3D2UjEIrByR/lL8Qa4Ihz6r9RbSWFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707936921; c=relaxed/simple; bh=E7A23eVB+QcyjJSOnbTsqesKEv7J7rv4FPLXbNWF3hQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=mqQy4JB0w7Dor0DLXqsDSpCbsR9mFRRDXaqEaYl5hl/xbvihoGyjOeD5kSgJwVV4cmqU7FYT9ioI8I22EMyCXeIzHDVs/ZXtNweNN11uLyvGQ2w2PhPhHWinBp5TJdPP+Oyu1eNBzz2u+5RSvuOV4GsWnF30QcPCV2buti/w9pI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=apMZOWPT; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d95d67ff45so300865ad.2 for ; Wed, 14 Feb 2024 10:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707936919; x=1708541719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F8pBojG5Ph+1av2r+/vw8N+d3NzUsR2t80fTE8XJw6Q=; b=apMZOWPTwgeOLexNgyWnsfghV1LNjfW2KFmLSFsB9LClBl+Stf9Rm43fz2mKAazusc mLcOABBdvdeJKeBUX2a4eKdaKG2eMiubVJ9ul5zl+J4dn7LcnSLiqmY1Kc0rS6K37llp l4AqlGgGVaypx6ub6O6/AoOaGrKmT6+EPcEq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707936919; x=1708541719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F8pBojG5Ph+1av2r+/vw8N+d3NzUsR2t80fTE8XJw6Q=; b=Re5MuTnaR0DX8ffJevKxmsbbOG62x13XewxgXangLQ18hakbWRd6AwRlftG1f9d1za bGO9ZPEXxFMwg7q0KgWxFq+LlCBKWfWYkn98q8BTfoxr0/z5DCLHCPBEQB1ul+CQsmaT JLvYH6pCBQ35cjjizHPDU2rBezRcnnmfy91oIAI7yWBpYec+h1Csf83kCXxzQ5KT7Dgc nrDGmD71Up4UkTFaBTqR7aifApG6eeY2jVwyvZIe57bkaK3SCWnZ5jMJEBLJ5wH28Amr 4DjQD5nOLpnGDcONLa5cdvVZOr1prXSAOu0AzM23ApvLhE2ScUrlh8JQmCSqlOXaK1fh +3Gw== X-Gm-Message-State: AOJu0Yy/CnY8QKvFOmqJQiTFj7f64rj+3tQ/TDHVE8tnmAmB2wmRim6e mUBIEOqL54XvnFnBbcR4AkCEV141EruP4n7aTNYe1L053oSroLCOIuPa4sTaZQ== X-Received: by 2002:a17:902:7044:b0:1d9:ba26:effc with SMTP id h4-20020a170902704400b001d9ba26effcmr3411990plt.51.1707936919056; Wed, 14 Feb 2024 10:55:19 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUIb5NLL6559qfZE28qLRIzmeD3VhVml04Dzqs16AulJBMBcmPRRCEnoPRpLkvAc2kYT6ICn4/qJtTFoAQVBsBdr+P0Dbt2rNWUVM0ETBARtBPEiQwG1/l1XL6XnCWWKdB+mutCCh4IUN0ddAmU Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id r10-20020a170903410a00b001d8e4de7a44sm4035449pld.127.2024.02.14.10.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 10:55:18 -0800 (PST) From: Kees Cook To: linux-kernel@vger.kernel.org, Andy Shevchenko Cc: Kees Cook , Michal Wajdeczko Subject: Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits() to wordpath.h Date: Wed, 14 Feb 2024 10:54:58 -0800 Message-Id: <170793689581.601125.11846352168094586184.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240214172752.3605073-1-andriy.shevchenko@linux.intel.com> References: <20240214172752.3605073-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 14 Feb 2024 19:26:32 +0200, Andy Shevchenko wrote: > The wordpart.h header is collecting APIs related to the handling > parts of the word (usually in byte granularity). The upper_*_bits() > and lower_*_bits() are good candidates to be moved to there. > > This helps to clean up header dependency hell with regard to kernel.h > as the latter gathers completely unrelated stuff together and slows > down compilation (especially when it's included into other header). > > [...] Applied to for-next/hardening, thanks! [1/1] kernel.h: Move upper_*_bits() and lower_*_bits() to wordpart.h https://git.kernel.org/kees/c/9aa3bb490404 Take care, -- Kees Cook