Received-SPF: pass (google.com: domain of linux-kernel+bounces-65847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i083147f8:Fastmail
Date: Wed, 14 Feb 2024 10:57:01 -0800
From: Boris Burkov <boris@bur.io>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>, Christoph Hellwig <hch@lst.de>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] btrfs: use the super_block as bdev holder
Message-ID: <20240214185701.GB377066@zen.localdomain>
References: <20240214-hch-device-open-v1-0-b153428b4f72@wdc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240214-hch-device-open-v1-0-b153428b4f72@wdc.com>

On Wed, Feb 14, 2024 at 08:42:11AM -0800, Johannes Thumshirn wrote:
> This is a series I've picked up from Christoph, it changes the
> block_device's bdev holder from fs_type to the super block.

Applies and builds on my for-next, and LGTM. A few non-urgent inline
comments in the patches, but assuming this has gone through CI again,

Reviewed-by: Boris Burkov <boris@bur.io>

> 
> Here's the original cover letter:
> Hi all,
> 
> this series contains the btrfs parts of the "remove get_super" from June
> that managed to get lost.
> 
> I've dropped all the reviews from back then as the rebase against the new
> mount API conversion led to a lot of non-trivial conflicts.
> 
> Josef kindly ran it through the CI farm and provided a fixup based on that.
> 
> ---
> Christoph Hellwig (5):
>       btrfs: always open the device read-only in btrfs_scan_one_device
>       btrfs: call btrfs_close_devices from ->kill_sb
>       btrfs: split btrfs_fs_devices.opened
>       btrfs: open block devices after superblock creation
>       btrfs: use the super_block as holder when mounting file systems
> 
>  fs/btrfs/disk-io.c |  4 +--
>  fs/btrfs/super.c   | 71 ++++++++++++++++++++++++++++++------------------------
>  fs/btrfs/volumes.c | 60 +++++++++++++++++++++++----------------------
>  fs/btrfs/volumes.h |  8 +++---
>  4 files changed, 78 insertions(+), 65 deletions(-)
> ---
> base-commit: a50d41606b333e4364844987deb1060e7ea6c038
> change-id: 20240214-hch-device-open-309ef9c98c62
> 
> Best regards,
> -- 
> Johannes Thumshirn <johannes.thumshirn@wdc.com>
>