Received-SPF: pass (google.com: domain of linux-kernel+bounces-65775-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 14 Feb 2024 19:04:59 +0100
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
	john.allen@amd.com, muralidhara.mk@amd.com,
	naveenkrishna.chatradhi@amd.com, sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Message-ID: <20240214180459.GLZc0AywYypIVV1IQ7@fat_crate.local>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214102926.GCZcyWBuEBe7WRXWYO@fat_crate.local>
 <2a83026c-ea36-44ca-a101-74a8b3a2ea89@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2a83026c-ea36-44ca-a101-74a8b3a2ea89@amd.com>

On Wed, Feb 14, 2024 at 09:45:14AM -0500, Yazen Ghannam wrote:
> Yes, we keep a local copy of the records within the module. That way
> we just need to update the local copy and write it down to the
> platform. This saves time and avoids interrupting the platform to do
> an extra read.

I guess this:

diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index 901a1f0018fc..99499a37e9d5 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -142,8 +142,9 @@ static unsigned int max_nr_fru;
 static size_t max_rec_len;
 
 /*
- * Protect the local cache and prevent concurrent writes to storage.
- * This is only needed after init once notifier block registration is done.
+ * Protect the local records cache in fru_records and prevent concurrent
+ * writes to storage. This is only needed after init once notifier block
+ * registration is done.
  */
 static DEFINE_MUTEX(fmpm_update_mutex);
 
I'm still don't like the module param...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette