Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbXLYWHM (ORCPT ); Tue, 25 Dec 2007 17:07:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752553AbXLYWG0 (ORCPT ); Tue, 25 Dec 2007 17:06:26 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:36930 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbXLYWGZ (ORCPT ); Tue, 25 Dec 2007 17:06:25 -0500 Date: Tue, 25 Dec 2007 14:05:04 -0800 From: Andrew Morton To: James Morris Cc: David Chinner , lkml , linux-security-module@vger.kernel.org, Eric Paris , dhowells@redhat.com Subject: Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning Message-Id: <20071225140504.f4c255d3.akpm@linux-foundation.org> In-Reply-To: References: <20071219093834.GW4396912@sgi.com> <20071220014413.GK4612@sgi.com> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 23 On Thu, 20 Dec 2007 15:11:40 +1100 (EST) James Morris wrote: > > > +#ifdef CONFIG_SECURITY > > > +extern unsigned long mmap_min_addr; > > > +#endif > > > + > > > #include > > > #include > > > #include > > > > Fine by me. > > I'll queue it for -mm & 2.6.25. I don't think we need the ifdef. If someone incorrectly refers to this then they'll get a link-time error rather than a compile-time error (bad). But we lose an ifdef (good). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/