Received-SPF: pass (google.com: domain of linux-kernel+bounces-65931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fc83e824-f37e-4164-95b3-e57bee60b2a9@amd.com>
Date: Wed, 14 Feb 2024 15:23:11 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
 Tony Luck <tony.luck@intel.com>, James Morse <james.morse@arm.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>, Robert Richter
 <rric@kernel.org>, linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/7] EDAC/amd64: Remove amd64_pvt::ext_nbcfg
Content-Language: en-US
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, bp@alien8.de
References: <20240213112051.27715-1-jirislaby@kernel.org>
 <20240213112051.27715-2-jirislaby@kernel.org>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240213112051.27715-2-jirislaby@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkdHcWU0TUtXTnlxUFE3Nm1uZW9sZWxqdHdhaCswajgwTnE0RjhsclBuSWw0?=
 =?utf-8?B?NmJOZ0JLOHd3NDhrdkZNSHJrWW1vSG9KbU94aTlkTmtnT2U2UWFsdWROQjRi?=
 =?utf-8?B?T0pmYlpRaDhGbVdYZzFMV29mTkJ1NkFic3hNb2V6YU8vaTlDQVdKNGc1akV6?=
 =?utf-8?B?VzlVSWtBa3IrekJqSzFxMElDeVl2SFBtc0MxWXg3U0pxU0NLV2JhZkpxQVRo?=
 =?utf-8?B?ZWk1WW0vdjlIeDZTMndvNjhCNHc4T3NMbWJZMU9xRjhYL0ZiMXhhZEN5TEZV?=
 =?utf-8?B?dlFuK28zM0pXRXlweWhOQm9kNHNOWkdublI1V2l1N2VNU282L0w2NXlaeCtT?=
 =?utf-8?B?ZStQYkFwejRwVStPOEpjRDFVZkU1cVM5NTRXQ2dsU0pHQjBnMDJ2cU13c3d0?=
 =?utf-8?B?ZWtDS2lMYTVhYkpyU0MwYktMSkpiNE9NMEhnS29pT0U3UFpaL2pGWlcxSlVO?=
 =?utf-8?B?ek9lbVBDOEY3ODlzNWVpcDhSRHN1NWdDbFdMam1sdm1CMkVQcmUyL1lRclBo?=
 =?utf-8?B?UGZEczgzTE1JK3pVM2R1OE1nWjVtQWVldm5FTVZwUGlMc1JOUzRvK3daQTZT?=
 =?utf-8?B?Yi9pa3J0bGNOczcxMXpFNU84NUtnMU95U2EydDVOYkVpYmF4dnJPTkI2RjNz?=
 =?utf-8?B?RDhuTkZxaWlyYndFY3M0RGllZER3dEdSSUtJZ1JPR2dLN3JCdGNkVmtDSDBM?=
 =?utf-8?B?cTdoNm1QeVExMXZIS29zNTlESlZmazR5QVlrL3hjaUo3K0NhM0UzczBYcEtv?=
 =?utf-8?B?Z1JOMDNhNlhRcStFZ2FXZld6cWZDMDBKckZISTkwTTlCNUlsSjhSN3BhdXRI?=
 =?utf-8?B?MnprbklCcjJ6a0d5WFJDV3BxK2ZwM1pSRzNHUGNMeVAwYTFmd0N0S2hhWUtL?=
 =?utf-8?B?Nmtaa0h4RGxId0hBQlpkQ0IvZi9aeHJjeWJ1WEh5YXE0bWRFbm0rcS9QLy9O?=
 =?utf-8?B?NkRCL0xjSDhYMVFScUx0MEVENmhwWi9xb08za1IzaHd5VVg4TGhlMVBwd2Yv?=
 =?utf-8?B?Z0xFcGh0akJjeFF0TDFVaTFuZDFEYS9vMlZITXpHb0d2SGJFSGpTWDBSM2Q0?=
 =?utf-8?B?eXBvUU9wTllFT2tJUUd4SzhaNnhVa2JQbndBK1QrM3J4S0JIUWJTYmU3c2lp?=
 =?utf-8?B?SnZ4N3pWRFRQSXlmbS9rMUNSbnpKUnZqdlVNbGNaNitRMDBTaUhYb3NPVUJZ?=
 =?utf-8?B?Z1ZkclNKRVBzUFhiNElXQnhVTFdmaWhNZlRrNFZudmU4SjZHdkZEcEpxdmt3?=
 =?utf-8?B?SElBaS90bDErOHE2TnlCYi9INTJ3WnBleDVTa0NRZ1dkL2tqZGJXcTlGVHAz?=
 =?utf-8?B?QnR2c3JWZG4ybjRjRFhzUnJmZTVJTm0rVThjcGZQT1ZFcVVZd1JMSWwwNURx?=
 =?utf-8?B?ekJSWVhvMWdhM0doN1N0eGN1MEpaRWZVajFYdyt0WXk0eXplYllCU2NiV0dR?=
 =?utf-8?B?b3MxOUhMRUU2SVhYY3pYWG1GcWxLck9DeWUzSHpuaDlWcFduQnRxa2tTUGFZ?=
 =?utf-8?B?QXpYMHRUVStCb28wZFhmMURhVG5ndzVRejBZc0IxaWpTSmw0b1Z2eU93ZWNz?=
 =?utf-8?B?ZExMUGx3aFZUdFc3UCtrWU96ckF5Y0VYS1hNSThhWUFMbTNjL0ZFcGZzVmZL?=
 =?utf-8?B?QVpKcWpEc1ZlTFpXdFIyY1o1ZUFzcFp5N0toak1WQ1EzQUIrWFpIM1B6cFpO?=
 =?utf-8?B?cDFuUDdnN01TWGFadkdvcnlGUGRNSnFBaDVaMHZxK3hpajVCTWNCbkRkc3Zz?=
 =?utf-8?B?d3RPaGsxa3V6cFhYZFRycS9uQnpUN1NjTngwS3p3WDlhb3Y5NXN6UFUzZTk0?=
 =?utf-8?B?ejdoTTFuUlVDdHNONHQrdC9QcDMrU2RDaThlSEUzWU1HRDFvbE1jTzJPNzNq?=
 =?utf-8?B?YjFhZ3ZDOTdycEN3dk40L3U4V3pHcFI3dmZld3hyaUxVTGVpRTZYS2dUL2ls?=
 =?utf-8?B?WXZNeWFja1BqNnRZalYwekJ2VWhjeEdTODdpZ1VVRURVdkVvUlZ4VFhCWDRi?=
 =?utf-8?B?OXhqZzZKb25yWDFzeVhKVG5RN3M2VUh3a1luenYwZjVUNzB6bEtXUllIdjZT?=
 =?utf-8?B?aEhYd3hoVFZ6UnRZRjErenBPdDd1dkU1ZUZlbmEvOEI1OUdCKzdZNkNERHFQ?=
 =?utf-8?Q?1lue1OUvMwDm3g8+KbbWv/NbB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6e758c-e4ae-4e05-c357-08dc2d9ac517
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 20:23:13.6093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1REgjI3eScKmI2o4YXoDVRCDtMUM6z6VzHiMk912yMtwlrZMmUUuAmHGtFzYQpBzstUQ3LShRPJuXHkomACBGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7287

On 2/13/2024 6:20 AM, Jiri Slaby (SUSE) wrote:
> Commit cfe40fdb4a46 (amd64_edac: add driver header) added amd64_pvt
> struct with ext_nbcfg in it. But noone used that member since then.
> 
> Therefore, remove it.
> 
> Found by https://github.com/jirislaby/clang-struct.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Yazen Ghannam <yazen.ghannam@amd.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Robert Richter <rric@kernel.org>
> Cc: linux-edac@vger.kernel.org
> ---
>   drivers/edac/amd64_edac.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index 1665f7932bac..b879b12971e7 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -345,7 +345,6 @@ struct amd64_pvt {
>   	u32 dchr1;		/* DRAM Configuration High DCT1 reg */
>   	u32 nbcap;		/* North Bridge Capabilities */
>   	u32 nbcfg;		/* F10 North Bridge Configuration */
> -	u32 ext_nbcfg;		/* Extended F10 North Bridge Configuration */
>   	u32 dhar;		/* DRAM Hoist reg */
>   	u32 dbam0;		/* DRAM Base Address Mapping reg for DCT0 */
>   	u32 dbam1;		/* DRAM Base Address Mapping reg for DCT1 */

This field likely was intended to be used with the EXT_NB_MCA_CFG definition.
But I agree it's not used and can be removed.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen