Received-SPF: pass (google.com: domain of linux-kernel+bounces-65932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <db7932ed-24d6-4645-9fb3-a7c5b743e0b5@intel.com>
Date: Wed, 14 Feb 2024 12:23:52 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH stable 5.4 v3] net: bcmgenet: Fix EEE implementation
Content-Language: en-US
To: Florian Fainelli <florian.fainelli@broadcom.com>, <stable@vger.kernel.org>
CC: Russell King <rmk+kernel@armlinux.org.uk>, Jakub Kicinski
	<kuba@kernel.org>, Doug Berger <opendmb@gmail.com>, Florian Fainelli
	<f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net>, "open
 list:BROADCOM GENET ETHERNET DRIVER" <bcm-kernel-feedback-list@broadcom.com>,
	"open list:BROADCOM GENET ETHERNET DRIVER" <netdev@vger.kernel.org>, "open
 list" <linux-kernel@vger.kernel.org>
References: <20240212014859.3860032-1-florian.fainelli@broadcom.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240212014859.3860032-1-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3hEWTR6ZW4yN2lUVFhSK01TeDBaUTlUeHYybFFwRjdkR1ZJaEdaQmFNd0Jh?=
 =?utf-8?B?Z3dIKzU4NHNObkg3SUsxMzJ4NGJDYkNkTHdZc050KzhiU2NsNU5hWXdnUnZE?=
 =?utf-8?B?aFg5WGZTMjhFNVFMdThqSnBUKytvZXc0YURaeS84Z1dtOE80QkxRbjhVSDBj?=
 =?utf-8?B?bGs1Qk91L3F6dlVCL0hYeG5GSThMc2gza1BWajZ5ek5qZ3l0djR1dTcrOFQv?=
 =?utf-8?B?KzdpZEQ3S0VoMVZabE5nVlFIbGpRQWUrd0sxVHBubnZYbmdFbUxzR3I4OXNK?=
 =?utf-8?B?QW1ZdnR6STJkdjJ2ei8yeGNWSUZUK21xeERNZFdERE5yTy9EYU1ranNFYU9m?=
 =?utf-8?B?K3FZbmp3UytjNjZuRENVbjZXL2ozYytVQUxtSUNVVUNqaUpqdVUvcS9PeHdp?=
 =?utf-8?B?YU1LV25YNEFGNG03VWkzaGtRQS85Rys5dUFDaElSZUw4YTFmUWFYcEZnTnp3?=
 =?utf-8?B?OXVSZWM5ZGdiNTE5WW9TRmgxTkhXVU1CWnJzaDQwOFkxemNzU2pKaG1kdWw4?=
 =?utf-8?B?Mld6WXRZQTBEazdMODdNeHNaUkNZRlA4WExxQjJXUU9GZ1o1eE5oeHIvR2xv?=
 =?utf-8?B?aFVHMTdZOTVldnU0MTJPamZ3NEtVdW5hcytPV2NmQlNvQ0R3MDNESmQ3SmdM?=
 =?utf-8?B?UlZrOTVtQmJZU0duR3FvaVJMUkJRbTUyNXEzaXpRNkNibmRxL2NSTkdnOVNp?=
 =?utf-8?B?eUFsQ2RvZWtPdzA4ekE2dkxPMFNKYnZ5RXdJTXBEcVhxSE5hcTNkZStqYVZZ?=
 =?utf-8?B?NHNzenA1ZkltYW5IckhaR2wyRENwUTR6ZmYvRWl5Z3NSWUVOaU4wZG9yMjh2?=
 =?utf-8?B?VWZTeCtMcVNSYTdzZWZYR0N0R3lGOXlsL3VVOElNMFZHUFJBcm9JbDd0Yzlq?=
 =?utf-8?B?QkR1cDBFMm1FaHVxcXVQOHZpMEN5bFJnNkx4OEY5ZzlUZXNCVks0R0F4Nld1?=
 =?utf-8?B?TWI0eTMvSEsxdFg5ZWlOcFJxMHpqRHFEYnF2VC8xVmgzaDZjWncyZGwzaW9i?=
 =?utf-8?B?TWtYVGdKRWE0dWxJeis0ZC93SjdObnVpQkdyMzhUVkRWV1Vkem13eWlHa0c1?=
 =?utf-8?B?U3ZWMWhpbG1DeHhZNlYxU1E3T1ZMOGtKNHNiQW1iQVRpN2RoSS9RZmFEVlBt?=
 =?utf-8?B?QWR3dHYyWkJ4Sm9wWjcxRHZYeTNNcmdrTldmekVrWTFwVVFRcklzMllLbnhC?=
 =?utf-8?B?QjZRc25tM09rZWRiKzVBOUFNWXdXY1hMUUN5cThVRXRJb3I0NVVQWUY1cDJH?=
 =?utf-8?B?ZjhsVGQ0TFZGZmRhN1dnMC91aDFlMW1sVGFaZnVjVWhqZTArdHlvNjIzcUc5?=
 =?utf-8?B?ekxnRTk5TWk2b0hUVFZJaUl4WEdrMnFudEtKRGtOSkw0V2hKc1FxL0ZvTXM3?=
 =?utf-8?B?MlVGSW0yWUpObytqRXVubEh4bmJvZEllNVUra1N6Ty9vaWVSRFNONzhQYkxI?=
 =?utf-8?B?N1gwb0t2SkNEZjJsa3pYcGQ2MXQya25kQmdRaTNoUnRabkdYUnNVek9SRzhw?=
 =?utf-8?B?NlNMVGN5ejhZdVlwbzMyWTVUckIxVGVUVHdQUGFNcTM5Z1YzSVZ2YlRiRUpT?=
 =?utf-8?B?Q2c5NEVlZldlWXBNQmFBUm54K1U3MmVrRHg2WDFpQlVjV0pwbDlBbytKbmFm?=
 =?utf-8?B?QW5oNkV4OTVrT0srYXBmcTdyQTk5K1VCaHZJVEsySlJuS2YyWXYyc05McUdD?=
 =?utf-8?B?VUo5UFUwb1hncEhYdXBLTDBrVEZTSjlRbDVuR0RpVmM5NUlXTWQ4UmxrT2o3?=
 =?utf-8?B?aHpVbjFhbmxqUGh3T0kySGIvZCthS1IvaTRIOWpGRmFERzBZYUh3YndOOGxY?=
 =?utf-8?B?WEMvTjZKdnc5YkVBOS9oQ0h5T1hZbjZBa2JtSEU4eTR6UE5WdFk4d0o0SWUy?=
 =?utf-8?B?Tis0YmRuQ3B1VEh2WHJaZDZwMFM0QjExT3YreG5RdUtqcEN1M090Z1BLTElk?=
 =?utf-8?B?RlFhK0ZMOTBBRVVjM05sT2kyU09QTjlRSFRQN2RuOUNGNHNhUmNFa2lzek9P?=
 =?utf-8?B?ZGxBeUlBdWhMcnpwQlIwMFZIMlV0ZVlEdmtZaXRwMjYxU2R3OHlCYkx3a3gy?=
 =?utf-8?B?R3cwZmlmdk4rUkVOdUxRYWdpVFpYa0VEVDJNbUx3azJNSVcyWEZNZ2FVcGlV?=
 =?utf-8?B?NTFVaTBNSU5VcTFISTFxdDJPSDBEUDI0aEtYbm9PR0lRaEU2dHdLSW1uRnpR?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a626b04-a733-487e-70fa-08dc2d9add4b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 20:23:54.6355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H68fmAgI365o/d6RC2D+mEi/1SrapETfvHlb9YG+Ir6tmswPjZtXhweBMx7rjOhlqUlDPeEbQG799R1J5e74wUxjJmzFB3j9TFYraY825/E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6794
X-OriginatorOrg: intel.com


On 2/11/2024 5:48 PM, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
> 
> We had a number of short comings:
> 
> - EEE must be re-evaluated whenever the state machine detects a link
>   change as wight be switching from a link partner with EEE
>   enabled/disabled
> 
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
>   transmit path, which applies to the TBUF block
> 
> - We do not need to forcibly enable EEE upon system resume, as the PHY
>   state machine will trigger a link event that will do that, too
> 
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Changes in v2:
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>