Received-SPF: pass (google.com: domain of linux-kernel+bounces-65933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a9f22838-e90d-4013-be24-127610d64d42@intel.com>
Date: Wed, 14 Feb 2024 12:24:12 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH stable 5.15 v3] net: bcmgenet: Fix EEE implementation
Content-Language: en-US
To: Florian Fainelli <florian.fainelli@broadcom.com>, <stable@vger.kernel.org>
CC: Russell King <rmk+kernel@armlinux.org.uk>, Jakub Kicinski
	<kuba@kernel.org>, Doug Berger <opendmb@gmail.com>, Florian Fainelli
	<f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net>, "open
 list:BROADCOM GENET ETHERNET DRIVER" <bcm-kernel-feedback-list@broadcom.com>,
	"open list:BROADCOM GENET ETHERNET DRIVER" <netdev@vger.kernel.org>, "open
 list" <linux-kernel@vger.kernel.org>
References: <20240212014859.3860032-1-florian.fainelli@broadcom.com>
 <20240212014859.3860032-2-florian.fainelli@broadcom.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240212014859.3860032-2-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnNjaXFmbG0yZlZ1ZGdWeDVDU2RISG1yMjgvMDJGT2pnd2FFRG9QbTBZUEE2?=
 =?utf-8?B?K3Y1b2FYbVRJbklCSkdhUTJEQ040QVRkZzJSYWgzYkJ2UURacHhWYlgrR3l5?=
 =?utf-8?B?UmFtOWlKMVVMNXFBUUp5Qm03cHRzMnY1Q0Rqa011emJBN3dleVRMcTNLZlpE?=
 =?utf-8?B?Y2pRY0U2c3MrSk5leGRIR3UwRlI1Z25oeEs1QmlXdnpBbE1PSG02UnF1QmJn?=
 =?utf-8?B?eWZ4MjFWei9YUkZjWWc2NStoZmk3STlrNjEvY1UwYXFsb3ptTm9Yd3h2Mkgy?=
 =?utf-8?B?ckFiRnJDcmdlSDRWU2N4S1lhNFBDUmdnTTh4a1dmNmtUcWlWWVRIZEpWbWYw?=
 =?utf-8?B?RGFrRHVaOU4vMmo1RVpxTU1Edy9NVzlvZHYxdmY5bUZrY3Y0bS9hUit2ZnJJ?=
 =?utf-8?B?UWNiSGFqam5SZGVNbmp5eHJLRGZKd3kvdlQ3OElZL29UZTJZQjV3OUpVVmsx?=
 =?utf-8?B?YloyNE5Fd3ZLRllZZlk4SFpzTWpVa2lTVmt5RTR0aWRJdFQyRWMvdlZpdXE3?=
 =?utf-8?B?cU1rWjJueUE4UGpYVGpmelA3QWQzSXUyK0xaeGI5eXRDbUFxNTZqV1NpMzl5?=
 =?utf-8?B?OUJnbEw5YkFlMkFwZmVXYnIyVlZiMCtqL3BjYVRJWm4yajRnNFhKTGluUUZJ?=
 =?utf-8?B?NWIwb2x5YkplWGFFdlhuOXhvWVVVT1JVZHM4aHZUbG82NzNvSXJacUZwdE42?=
 =?utf-8?B?ZDlSMjJnZUtRQ29OUUJtRVM0YVhRVmtnMlhjYzg1cFQyTUFvU2ZyV0l6Mk1I?=
 =?utf-8?B?cTBqOXhGOUpFNWpJNlY3SXVUQVk1enRCQ3o4SWJpU0F6SVorNWhDTmZtMkt5?=
 =?utf-8?B?V2pucjNmSHRYT3U0VDdEc2tMTEF5YzdHMExaaHRBSUdOUDRxQTNGTVMybnF6?=
 =?utf-8?B?b0dVbnNrZndSSkNsazBJdEY4U0I5SVZzbWxxREpFM3gyVVJmdUJYN2FnWXNH?=
 =?utf-8?B?NEJndHduVTRQQW8yZ0FaTVVsQzFmVFE0aVJKRkRUa0pVMlhBNVQ5UzI4RU42?=
 =?utf-8?B?WnE5SXVxZW1qdGNvV1hoR2t6UThnWnh1TWd5U2VWRkxlUHdwdlM0azRzOHVI?=
 =?utf-8?B?U2lqV1ljbURNMkJiRmFpNU12b0VUa0Y4dmNyMmRZSHBwREVmd01WWktmaDgy?=
 =?utf-8?B?Wm9JRDEyTkRxcjhtek9zOUVzdmJvb016VE1ETWo3ZFgvM1FkbElpSGpuK0NT?=
 =?utf-8?B?Y3F6anlaa3d6T3BSNjFSTEhlVytLUVc3RUdobnlmc1ltakgyRXFZYkYrWm5x?=
 =?utf-8?B?ZGZFNm5JN0RzUlhJd0puNnNIbXpkU25CMm1pbTRZenc5SENaYXY5c0hsVS9q?=
 =?utf-8?B?UWZxYnM1amN4WmpIQzFQYlpBZzRXYVlEcFNVSEpmRzByd3djcXhaYUJ6ZTNv?=
 =?utf-8?B?OHpjQlVLQ3ZRWnpycHZOSUw5TkZkc3dYZmJCTzVXUFlRSXJ4bWtEZ3lCSTQ0?=
 =?utf-8?B?ZTFRZzBKTzZXczBqTytMZGpPWVc0NERVSEE5eUF5U29lM0N2dW5PU1picUVy?=
 =?utf-8?B?VzA5YVNrZ1h1LzBqaEJxdUR1OUhmOTllbUNULzd5MlNzVDMyL1YveXpPMkt1?=
 =?utf-8?B?YTRJeTRlMmNoL29KQnpmb0FhUlJtY244Q0VHY2xUaDhhZEdFS0ZNcVpSL21n?=
 =?utf-8?B?SndrdWFxTXdmOVBQWm1TODYwOGFEVnFEMENMN285ZjBMTVNBdXo4RTB1YzV6?=
 =?utf-8?B?c2s5K3RFTnE2OHlIN3pra2hEQ2s4YnJFODFKMGxGNk4zakRtSXRadWJIb0pH?=
 =?utf-8?B?WUZ2OUpXeXlhYUZKT3psMjNPU3F1Z0pHWFlaWm93bU1ZaEQvNnlUT1A3UG1y?=
 =?utf-8?B?ZUQ0dXE4VXduMWhGWTl0OFJwM3FzNUgrWXJxRVlrOG5qTWhqVVd3YjRMYjZG?=
 =?utf-8?B?NHFWaFpkUEYzK1NhN2NDUlVpbzVaYlRhaVh6TjBmSU9KWDkybzFuVlZVNXJ4?=
 =?utf-8?B?SmxYNlBYSitOY0pKVnJtbkc4MGlRS2tGMmd0UmVrd2FDV1RFN1JFa3BRZ1ht?=
 =?utf-8?B?M0t6dVBFSGJ6a2NNS2kybzByTTU2VjNobmwzYXlZb1BtZmZldnJFQVpSNkxK?=
 =?utf-8?B?Q1R1dlM5M0RWcFB6SkRWL3RaQ3RsdmhRV01ZNlNtQXRHN093OS95aFVDM20x?=
 =?utf-8?B?VmN6bWk4QThVek5TSCtDc0Z1eHI0dHFqaDFxajYvWW40OFpnQmlwYzBJN0JH?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8961048c-f57e-4422-3358-08dc2d9aeb05
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 20:24:17.3263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AFLt0g/zArWkRMucfS0qJhvbTg5Sb4wOknuszRn2RlZ5bGeHxUCgtBHReHzj8qsPvhyly/fEJwiCXA8DyZWBQRKugNXMK7bv64t5uqLbHa0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6794
X-OriginatorOrg: intel.com


On 2/11/2024 5:48 PM, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
> 
> We had a number of short comings:
> 
> - EEE must be re-evaluated whenever the state machine detects a link
>   change as wight be switching from a link partner with EEE
>   enabled/disabled
> 
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
>   transmit path, which applies to the TBUF block
> 
> - We do not need to forcibly enable EEE upon system resume, as the PHY
>   state machine will trigger a link event that will do that, too
> 
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>