Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp56369rdb; Wed, 14 Feb 2024 12:31:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXYEgSYZUfBgamuthAR343u0aKYtD74ISgHMYMKI0U5RlLp5F3q7bM9VISJCxFToQ1BeTbrzJ9hRGAI6BUP7uSt1YJdMjRg4Mq0hAul9w== X-Google-Smtp-Source: AGHT+IEbjSGSzLPhbaR6oGXVfuxxo+8zO2Qp1PQ9IbMpmosxvTWe5oXw9HQh4+d5mgZdP0gyDhdG X-Received: by 2002:a17:906:3490:b0:a3c:940:af14 with SMTP id g16-20020a170906349000b00a3c0940af14mr3189828ejb.55.1707942715405; Wed, 14 Feb 2024 12:31:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707942715; cv=pass; d=google.com; s=arc-20160816; b=IYkpMeIaY8JU3lrk4dQ4cp5NRrrq2bDUhzG2NrrTGpHeu+Rw5PZcV18q0gCQyxJBp2 2vx6SG1ODo3DMCCJvzVIAE97+TFP0b5R9WMDyZu+IBMYZfQ57O2UX3DtKrt5XYx3hoNN ChCXsJnBXPr8Q5T8ZkJva+L0ji9rqN9n8E8CJu6k7XyBrbSAxDw0g1+05gbj9nspbhyK Fjc8ZjGmfCYTg9G4a/7ulILUgyueINrGrF9RhIfcL4Er/DV/0eB/Pfx5dQ8r0o9Yhu3d o9WBHl5q+a3S7xIpNA2SnofgPz2OEhf0ser/7evhMaNwCS6SPetPOhlSzTrTey0CGpks lpFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=OOE6vt476PlmlGOjjyu2jp1tt8pY8ReZfaGTrtpilkk=; fh=DX/Arq1Fs2wCdhOz3xFapcR3JzHbN0jFpH8NwP4pQD8=; b=CzAcwdExIzEhpvUyJMyiDZfTR8PsD27tWab7mUzNHWV73eIl33uwGmUamJ5viLYtAK 7LZVsHQ0Nk//ItBQkTivFJu0sY9qsXokCsFp3sdJFtC+EG2jMt7RUD7fdZwa1ant/5E2 8EC1jJFIP3SOeT8FrjiqgfkK3POv0jE+X1iqEcXHy6yl2Albf47VLz5j6dCLwPamas67 GN62hD/jGkssqcB3gHY2DlytjfJQNdO9p+8awLeMShZJbIc1C/J5qsAX5rHuxwjY8PWr rgbXDsCJIqvmMi7ZtDloSnnrj9UHzv/+JGjHwLMGFVowrhsIixf7GzJRYC7PftnCebYr IS4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O7FM46Ti; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-65937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXHJUz7tsRXPuBHORodCWe03LpxGGONfXmWQek6ZA60QkFCRS3z+knwQTtroPwm5oEIwEJL1GTirrlUSbwKYOycyMp0eTOpQGrQfW/T+g== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v24-20020a170906489800b00a3d784f1d97si180637ejq.940.2024.02.14.12.31.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 12:31:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O7FM46Ti; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-65937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CC3ED1F29AE8 for ; Wed, 14 Feb 2024 20:31:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D1DF5465D; Wed, 14 Feb 2024 20:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O7FM46Ti" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6353D18E0C; Wed, 14 Feb 2024 20:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707942691; cv=none; b=qxnxYrAGIJJiBNxuPwIsy/29EWfirX1GyBcq+bNpwQNhFGJpICGZJw/23VzQrrsqiSONHzbVZt1ZzzDXEtQleNpurd2Z84JLZb73ciaI6Dhx+v9M5kQ+iVDuyNdponA51K8D48qBC8HZETHIGmhfCPL+RioOHZqVtuWa6WfE42U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707942691; c=relaxed/simple; bh=pKXGXg37t5AZ3wpBT4EKvFu9rFHUojjY1rpSd8vUaP4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=erIS6BMKizkcc/BCfOndAO2BCnu5BIcFw4qx9914ixGmb4gsoEv512nhVXSfIbzCUT4fTP8nx6soNXhQA3xmdn4R8bc0CXPKoi8QQYaTVV1M1BTJrm5YRi5tKOqk+jhdA8wex/k3k3SRiaaQZjnOXhLqy76W4Wb9nlUtzShWDRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O7FM46Ti; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39418C433C7; Wed, 14 Feb 2024 20:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707942690; bh=pKXGXg37t5AZ3wpBT4EKvFu9rFHUojjY1rpSd8vUaP4=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=O7FM46TiMYmxpWdUBQJy04jbMWRFfTfstTvW3nWqZLicSR7Yir/VEwdiIj6ItZrWp ib/C5Sb4u+oWBJ5T+eT/8iEMAFsGCtC91isQDWH3M8xoggoSDUFeHJzfgeYXp4bRvA RE5MToo8sqlASmGty1RczCW8ENOS0+a5+gQnlkpd3zALDDcXAajpPKDjCXZac/scjB YgaErLaGI4tbiQbeOl8GzP5iLwKTJUP/bUId0s96F7eQMFxqGVT0+X9+nEIZ8WsmZN naxo58tfvapuUZx+zTNNYrqMHi+h+TASDKSRwmEAP7QiGzC/SW3tOEmjYs0CCnRl8J lQUmV+RPUNGQA== Message-ID: <0daa6f37-8c50-4051-873a-4e8cd4e6cc58@kernel.org> Date: Wed, 14 Feb 2024 13:31:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver Content-Language: en-US From: David Ahern To: Jakub Kicinski , Greg Kroah-Hartman Cc: Saeed Mahameed , Arnd Bergmann , Leon Romanovsky , Jason Gunthorpe , Jiri Pirko , Leonid Bloch , Itay Avraham , Saeed Mahameed , Aron Silverton , Christoph Hellwig , andrew.gospodarek@broadcom.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20240207072435.14182-1-saeed@kernel.org> <20240207070342.21ad3e51@kernel.org> <20240208181555.22d35b61@kernel.org> <2bdc5510-801a-4601-87a3-56eb941d661a@kernel.org> <20240209145828.30e1d000@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/9/24 10:01 PM, David Ahern wrote: > Maybe my bigger question is should drivers that can do different > physical layers, or can operate without a netdev, should they be split > into different drivers? drivers/misc for the PCI interface, drivers/net > for ethernet interfaces and its APIs and drivers/infiniband for IB and > its APIs? Generic capabilities like this debugging interface belong to > the PCI device since it is generic to the device hence drivers/misc. > I do not recall seeing a response to this line of questions. We are considering splitting our driver along these lines to upstream it given the independent nature of the capabilities and need to interact with different S/W APIs and hence different maintainers. Any reason new drivers should not be split along these lines? If the answer is no, then where is the best home for the PCI device driver piece of it? drivers/misc or drivers/accel or create a new drivers/multifcn/?