Received-SPF: pass (google.com: domain of linux-kernel+bounces-65938-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <44c29a45-86fa-4e41-b4b5-e69187f0712e@intel.com>
Date: Wed, 14 Feb 2024 12:31:35 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net: stmmac: xgmac: fix initializer element is not
 constant error
Content-Language: en-US
To: Mark O'Donovan <shiftee@posteo.net>, <linux-kernel@vger.kernel.org>
CC: <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <mcoquelin.stm32@gmail.com>, <netdev@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
References: <20240212154319.907447-1-shiftee@posteo.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240212154319.907447-1-shiftee@posteo.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzZmM1VWSDZQYkJpbmxYQXdTTExhR0FoU0xZVjgzRXRqYXZ3NkpMMmxnclpI?=
 =?utf-8?B?NlFzaVNhcmdoMjJVUVlyY3lrSHR5V2Nwcy80YmtuUnJSSjNqQk9nU0NmaXBG?=
 =?utf-8?B?ZnRZN1BSR3lLSnh0VVk2Sk9hOUpZVUFsZmxPZUNKQWw3UDFjN01QSFowMGY0?=
 =?utf-8?B?N2pzT3RnWTdVb3lPcXhlaWQ3WXErakFYeng0UUV5b2dqemUyL25OYzFsVXJC?=
 =?utf-8?B?WWJqZ1ViRHVLZm5teXFLc0pZcThzVEMvcXhoSmhxaUxLa3RreEM0NG1KQVpB?=
 =?utf-8?B?U2FFWDBQcGZ6YXoyYUFqS201MjMvcndsNGpiekllY3ZxQTZ1b21ZT3lYRmNo?=
 =?utf-8?B?bnhzYk5NbWFXVWs4eXltWjJDRVRQRHZ5U01zcXhFblowUXBXb0Q0UGdVM2N4?=
 =?utf-8?B?bHpWTEVLMjRrYzRod1hBK0Evd1BOQzVjTnloRFdtNVRaU0d2NDM3UGtqVHpO?=
 =?utf-8?B?MlhzNml1VXlrV2xtZ0g0aHBKa3RuVXczNDhvVFY0TjlPL1JDVHoxdWdkdEYv?=
 =?utf-8?B?U3dyeTFiYXZWM0VuMEFpYUQyYTV0ZXFqMjh3a2VHd21JanBHTlZpRTJtNElP?=
 =?utf-8?B?a2h0K3NxWEFqQko1ZndkMGwzeHNuMVh6K3gzOEtSYXArN3VPMmtOSVpVNXg3?=
 =?utf-8?B?TktyKzd3UWw4OWNWQTcwZDZWQ0ZGUEFZZE9OWm8zVnl0YmNiZmFic2lDU2I2?=
 =?utf-8?B?YlJjUENpVlpUZHFITzRMMlFMUFpXVUlnRWwxQ2U1MTd0Ukp6Z0FXVjlncUVF?=
 =?utf-8?B?K2dtWEFXRE9zdEpWYWhyUHN6bnhXUkUyeXVKTkQxdkRGSFU1WEE1eFNhY2pG?=
 =?utf-8?B?M3ltbVpNK1Z4OEVrbkZZbWVzVFJtaU9mbU9IR1pnbmNTOExycnhUMm5HckFJ?=
 =?utf-8?B?NjkrL0lPblZiTUwzVnNSVFdtK01kYjN3Nm1ZUlBTb1d3cUZqSGVLYWZkYUQ2?=
 =?utf-8?B?MXhZVXNWcTYxc3ZtYTh5aG84bmkwQkd1NXhYejdJQmc0Wnd1VmU2V2ZKaXhp?=
 =?utf-8?B?dFJkVTJ5UVRHcm9lVi9nc1U5L3RBcE96OUZjWGZlc1NWYUhFZXhMQWUySGtz?=
 =?utf-8?B?RnpmWjdmeDZsRXFaK1BHaGU0U1plQkdWTGllczJHSGZmQTQxUmx3ajZSYXJv?=
 =?utf-8?B?V29MWmxubTdESE8xVVpxaEUyRUh2OTNERzZncWVYWXBHeHk0YXd1bE85RzJB?=
 =?utf-8?B?d3p3SlJFVkpCaDJSdlkyOXpvb0xydlFJSndUMEFHcG1rSWdIY1Bjc2tMTFZD?=
 =?utf-8?B?TTRlTHBPeENwV2JpR0FpU2ZCNWhndzl4alA0QzhwV2pkK0M4bnN4dDJaQ3Fz?=
 =?utf-8?B?aUZob1piOGNhY21INmo1WXhhVnZkb0xxeGQveDg3MjFWR3Fha2ZiQkh2bjFm?=
 =?utf-8?B?SE9ic2FTc1ZDNHFJb3ljYU9iMWx0Y3hjOWZHaTFlbEN3U0FYZm9TRUNJUyt4?=
 =?utf-8?B?bjhrQWRjUnFCWHUxWXBhKzBram5MZDA4TFlXZUVUYVZQbzJHYXBNNE9tZVlS?=
 =?utf-8?B?b3VqbFJreiszQTFrZHJmNGwxZmpCRFYxRmdOYXRZYzEvQjN0blptaUlrRkk1?=
 =?utf-8?B?K3pFcFJmTmdBR0w2Y1A0ZVJMUHNYSjBSQk5KeFhUa0FPamM4QlZOSFFkblh1?=
 =?utf-8?B?eEk2SUs2TndnMitYOUkrTHVPV0FkbjhpemdiT2YrbWtTS2tXTnlJcjUwSWtX?=
 =?utf-8?B?MWs3Ykk1dkh0cURXYU96eDJZVDNUWDEvcko3UFNrSHBnNWtSYVdxNXZiM0xY?=
 =?utf-8?B?bWFQRTlDRUsrb3BTdVYxUHZLODVGWHlVQ2F4aG5ONjhFd1dIVWNtTHVSdDdS?=
 =?utf-8?B?VXNJbS9iaHI4NkJpUHJFODErdCtLMWx2U0EwUC9DekovTUduY20zWTdNaTB2?=
 =?utf-8?B?M0VXdXcxTVpXTlZIUG9NU2w2ZjBwUHMwUkpqRDUvV0RibFp5dUd1Qi9reUtv?=
 =?utf-8?B?MldtY3JxVlhzdktvVmhNRXlZTHpCVk1mYWZWUFowT0JPa3l0MERyUWZvemNq?=
 =?utf-8?B?U3c3eXFjNnhYT1p1Mko1V3dsbkl5RW9iU0E1N3hGWDFBNUNlRHN3dGhnSEtF?=
 =?utf-8?B?NlhDS1NsNlp0QUFFVmw5czBsUjYwSUNWNURHbXE2bURrWFF6ME9ubm4xTWYv?=
 =?utf-8?B?TkFYV1VuSlhwQTRVM1FSNkRkVjZ3a3lBTDI5aEdOMGNXUnh5K010a1F0UHkw?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01a67577-d697-4c7a-f42a-08dc2d9bf256
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 20:31:39.0263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OkHbytudFQkdPMeD+1l/OZmBjOqUEqmpp2m8Z3REyhp4noDf6NcymaOWOoRbDPHfPTvOy3W6j9jN+YU2/3ngaFEVnb6LXWVobzr062BjYNs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8673
X-OriginatorOrg: intel.com


On 2/12/2024 7:43 AM, Mark O'Donovan wrote:
> GCC prior to 8.x gives an "initializer element is not constant"
> error for the uses of dpp_tx_err in dwxgmac3_dma_dpp_errors.
> Newer compilers accept either version.
> 
> More info here:
> https://lore.kernel.org/all/20240103-fix-bq24190_charger-vbus_desc-non-const-v1-1-115ddf798c70@kernel.org
> 
> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
> ---

I'm not sure whether the Linux kernel project has an explicit cutoff for
what versions of GCC (or other compilers) are supported. GCC 8 was first
released in 2018.

The fix provided here is fairly straight forward, and while I do think
the benefit of using builtin types vs using the macros is nice, I don't
see that as a strong enough reason to hold up supporting the older compiler.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> index 323c57f03c93..c02c035b81c0 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> @@ -830,8 +830,8 @@ static const struct dwxgmac3_error_desc dwxgmac3_dma_errors[32]= {
>  	{ false, "UNKNOWN", "Unknown Error" }, /* 31 */
>  };
>  
> -static const char * const dpp_rx_err = "Read Rx Descriptor Parity checker Error";
> -static const char * const dpp_tx_err = "Read Tx Descriptor Parity checker Error";
> +#define dpp_rx_err "Read Rx Descriptor Parity checker Error"
> +#define dpp_tx_err "Read Tx Descriptor Parity checker Error"
>  static const struct dwxgmac3_error_desc dwxgmac3_dma_dpp_errors[32] = {
>  	{ true, "TDPES0", dpp_tx_err },
>  	{ true, "TDPES1", dpp_tx_err },
> 
> base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de