Received-SPF: pass (google.com: domain of linux-kernel+bounces-65960-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20231215124449.317597-1-mpe@ellerman.id.au>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Gal
 Pressman <gal@nvidia.com>
Subject: Re: [PATCH] powerpc/64s: Increase default stack size to 32KB
Date: Wed, 14 Feb 2024 12:47:39 -0800
In-reply-to: <20231215124449.317597-1-mpe@ellerman.id.au>
Message-ID: <87ttmau5mg.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1T4mhS79BNoBLAzAoKtgfguAxcI0Om9tm2HAI9WZk5mwirlQC1SrX2AT3zcM?=
 =?us-ascii?Q?ym/aK9Lrb1OlUgeBUTNkdupc8QIu6V1eaaid+wCZYPgCgXsr6kYEvq8hFvEG?=
 =?us-ascii?Q?4P7+8hUcXqi4PTM70Wdft1gPrMgHezEC0KTk+dxfYitYbQxMZo8tjUHBmrrJ?=
 =?us-ascii?Q?1xgHSTSPS/MngnsxgRqp3nJCyoQ8iDSVzSXGWXMrDCxDHMvMfC9hIGAs29NS?=
 =?us-ascii?Q?ws0YU6DgbFiKNJ5EheWFoss7c6fhnS2QNKPlrwkTrUjPffPL2fRX/dZUUfOj?=
 =?us-ascii?Q?88S4Npp9drjaMSecOcAFZb5mc51eYEBd7WRrkMyBErU33Y/3Jye8CtLnlfMV?=
 =?us-ascii?Q?xnqo/lhn0f7oaIZsZlci2WvMOOYIBZdm5kyspFKHEoC+aiB9Xr1Uu3fr2c3K?=
 =?us-ascii?Q?A1nHFDStkxrn0jkeqdVx1eFqyRyym3GVA+2R6Hn0Q5Xl3+GztPPhBYfPIB49?=
 =?us-ascii?Q?UkOZjqEVfPvR/qSxt7hAU7jEEzYnleNqVOh+61n9WCvFK7qwEDHiVai2d/Li?=
 =?us-ascii?Q?+JpDa86WXdTd43QCzLkyS13al47OVfFS4hWWPt+KixIPaUC3EaV0V0cumTiE?=
 =?us-ascii?Q?WdeAo6qOHplDly3bT6xskoNnQGwjZojLlGMZiAgkpBPAEUp27ZEstQc32l1Q?=
 =?us-ascii?Q?QT+wSF73vWajU5jVHYZ+9KEkgkY7vkvVUhvVz6kB2pP0jFQX38zJF3ZS3f30?=
 =?us-ascii?Q?ojHmzP+gjNpD7C0TCI5fCwqo6YZQ6vkQSRqqGzJYbeEYFivuZrVCpKQugJ7r?=
 =?us-ascii?Q?gDfKMdBrYRAw8YyDUgmCCnpwJf+IfGeEMJJBq0XRIEr/Mi6Z6waRXUr8NDHV?=
 =?us-ascii?Q?g40fcTQIXsY4QVBmZAPTl1xZ+TEKOaMGFHiAJsy7jq8KHRu4GuFzLAeZysr+?=
 =?us-ascii?Q?os3bgZj5Y8qFhPMQ+5of75g5uVmFTn1WOFncKhvdNQEYzzGriKLZDVwXsGpK?=
 =?us-ascii?Q?pOIrVuuojX8APcvFMY1+tGETzs6eKDvWi8hicqHKRvd1z+uS4W5B+Vs9xNs7?=
 =?us-ascii?Q?ocoLia+ufAOb0Nq1FLBGS2B9qwO6PcYNg+cQYR4GNPgMk8mKecbIkx30ALyN?=
 =?us-ascii?Q?oE2iH9e7s1vfdfLy6DGC+rFFakzm2VxSnudH9HfAFSiSALU7LahY09V5fwkM?=
 =?us-ascii?Q?TY+6JbotIjWDlJ4Pt/prUQdG3X5s7JDeCuRCifITslZoa+b+oFaK+0hXxZlo?=
 =?us-ascii?Q?JIhHCmyRZD+4d1ChddwnandqR7newtfexo9/ukwFCGyIGKejHpkfScouiCOf?=
 =?us-ascii?Q?OKZ/lTNHWsjPG2QieL18H0KZuLeTnHCitvGLdw91xYBO3hMZkg03MvSGkU2Q?=
 =?us-ascii?Q?UPHrSl9Mv6/pG2OlH7SFzZMI5qQbnPrpj4lJovfLbdzzGtc0iPzXd1z+pFxp?=
 =?us-ascii?Q?TScMCa8hX1otK4zGROhhii3fZrVtZSsX/yNFD6f9IDUCB9tpmV9YlDfecXHb?=
 =?us-ascii?Q?t1iGCYzBFgGPi6FH59X3ibpw09LTjHRSzYbKRzOIwGmKowpnSwjidJkTKgRe?=
 =?us-ascii?Q?ukkVaihe/JQ2g+sAIsN51i8GPSpec3t4zDuTi4p6c00SDoj83N5DeVO0ByXa?=
 =?us-ascii?Q?I3Hv3cTKBUGuMgWY+zo6j0+Sp2gGmIdNX3/uvowhoapcDNi8CttWP2mtjgjZ?=
 =?us-ascii?Q?jw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c37e8175-53c2-414a-cdd9-08dc2d9f70e3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 20:56:39.7852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: squ7KroZS/trb7EWjx9ydVrweylK8RmPtATiBi90j9apBCYBW0MWQSjdYXK377DjKEh79ysiRVmW3KAOfo2pmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6522

On Fri, 15 Dec, 2023 23:44:49 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
> There are reports of kernels crashing due to stack overflow while
> running OpenShift (Kubernetes). The primary contributor to the stack
> usage seems to be openvswitch, which is used by OVN-Kubernetes (based on
> OVN (Open Virtual Network)), but NFS also contributes in some stack
> traces.
>
> There may be some opportunities to reduce stack usage in the openvswitch
> code, but doing so potentially require tradeoffs vs performance, and
> also requires testing across architectures.
>
> Looking at stack usage across the kernel (using -fstack-usage), shows
> that ppc64le stack frames are on average 50-100% larger than the
> equivalent function built for x86-64. Which is not surprising given the
> minimum stack frame size is 32 bytes on ppc64le vs 16 bytes on x86-64.
>
> So increase the default stack size to 32KB for the modern 64-bit Book3S
> platforms, ie. pseries (virtualised) and powernv (bare metal). That
> leaves the older systems like G5s, and the AmigaOne (pasemi) with a 16KB
> stack which should be sufficient on those machines.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---

We noticed this change is causing assembler issues for us when building
the kernel.

  make ARCH=powerpc KERNELRELEASE=6.8.0-rc2_for_upstream_debug_2024_02_06_20_01 KBUILD_BUILD_VERSION=1
  arch/powerpc/kernel/switch.S: Assembler messages:
  arch/powerpc/kernel/switch.S:249: Error: operand out of range (0x000000000000fe50 is not between 0xffffffffffff8000 and 0x0000000000007fff)
  make[6]: *** [scripts/Makefile.build:361: arch/powerpc/kernel/switch.o] Error 1
  make[5]: *** [scripts/Makefile.build:481: arch/powerpc/kernel] Error 2
  make[5]: *** Waiting for unfinished jobs....
  make[4]: *** [scripts/Makefile.build:481: arch/powerpc] Error 2
  make[4]: *** Waiting for unfinished jobs....
  make[3]: *** [Makefile:1921: .] Error 2

The issue lies with the do_switch_64 macro.

--
Thanks,

Rahul Rameshbabu