Received-SPF: pass (google.com: domain of linux-kernel+bounces-65978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 14 Feb 2024 13:22:25 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Steven Rostedt
	<rostedt@goodmis.org>
CC: Ira Weiny <ira.weiny@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, <linux-acpi@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Dan Carpenter
	<dan.carpenter@linaro.org>, Masami Hiramatsu <mhiramat@kernel.org>, "Mathieu
 Desnoyers" <mathieu.desnoyers@efficios.com>,
	<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held
Message-ID: <65cd2f116a887_d4f2d29445@iweiny-mobl.notmuch>
References: <20240206-cxl-cper-smatch-v2-1-84ed07563c31@intel.com>
 <20240214121153.00005c97@huawei.com>
 <20240214102310.7ba53f3a@gandalf.local.home>
 <20240214181200.0000500b@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240214181200.0000500b@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0tpUSNCr8tYMGgZHEm6f4Y0SGJVob5tqokAKviI63guwqHcT9ORIyOAC9sOD?=
 =?us-ascii?Q?E1IdpuJhHBQXEdZbDMEwwAt46LFk7NCNmi2Z7rZO8zpHuym5UyNJLRgV6U2d?=
 =?us-ascii?Q?9zFgllyuVLbXe9m/jsloO1cfTiiwtn9uRBXmUbmsHJgjBIFmrbo8xc2JgkW3?=
 =?us-ascii?Q?A09d18fXWABp1uyX6dr0J6Jv5P2F8oH7jQ4bE1/QglyvyMEGInBeAAHz/Gz/?=
 =?us-ascii?Q?i96fO/Zw20kwcF1AjHHdIK6GfDRwALGvv3bjaxUmqhjvSXLasto4NmzcSuo4?=
 =?us-ascii?Q?80J3s9seISyx0njpygfw499jjk4kugS6d3rvQjzWZncnZT8N2WBHzdjmRg2e?=
 =?us-ascii?Q?ZMYG2hD7D61Xh3l+1yQOTGr8FBtqIq9Dm9NiN+UPjO0GD2Z5Xbfkn3LnKzyc?=
 =?us-ascii?Q?KmADea0OS6BB3XgvGjS3WUufRoEutnXRtzaDldexhJFvhCgcjHoMoKNa0LL8?=
 =?us-ascii?Q?uLRwKh1QvfOi875208FLGOypRmQjI42DlDQN6bCEuMkShgFfPZByznrdpGMt?=
 =?us-ascii?Q?CmqIiH7ADJgtfDXvQRr/FPtwJ3C8sTbHVeT+TurIA4qjsCJ18HQtTAGkJbuP?=
 =?us-ascii?Q?k0+cDw1fVbeI11MZh5G1j7+sTKleDMfyWJ0kNIcBDlKDzRsoyY7N27XuQno8?=
 =?us-ascii?Q?r7J0alcr7MI9RG/4Q+dpFdT5/J9uIywq54gQNuFMXjK5VsA6vzgZYmF0IsZ8?=
 =?us-ascii?Q?cvhKBZMtFP9amTdbfM4S3SVyaPwhvKo6q/9xu1I8yVMcxY/tO3iuPqi1mWTn?=
 =?us-ascii?Q?ATHc/x6M01xzkliWqL35Xb4Lxa9O6iWxSSNLfAvmfTRVCB/pqgs8P1BZBi3A?=
 =?us-ascii?Q?qWzoK87TyG/Cn9g2AiH46hiMSTozVGaz3oKwGWoKt/yzPcmraZhOyjnA3Jdh?=
 =?us-ascii?Q?yGJ1R8y5fGuFH5PRNJ/DAAp8GdLHS2e/gFPrjDCACF52ViBDvsllmkKzWcjM?=
 =?us-ascii?Q?GMo60PanvX3l7hQ2YDYjwho/2Fu3dzeMOryhDXhSc7IhsEX2A+sQ4kzLvPM4?=
 =?us-ascii?Q?Fyuxk89KW0KMdFsBEd0l5hYTOZEzxjzk0Rj+mREZZaVLiGRyfni90K3SfB+I?=
 =?us-ascii?Q?kc8Wn86n1jc5NvsXq0bG/9CsSx0Qt7XOSMoKy7dIXScGAmE+SSzFE1nyTV/Q?=
 =?us-ascii?Q?d9V62svDRJjyxacadQKhflQtg9putD1mmAcQ6WWSAO6BRjoDe+hdzbnFr69k?=
 =?us-ascii?Q?L2xv918hX5jahSuRiNXZ8KKwWAV8VEMZD9AL+yw44t5jfuvwOFwahdQRWWvY?=
 =?us-ascii?Q?fc+dP86RwgOJ7fdCuKjLLYcz/NlT21EpukusTB3yZGa+eVOeT+4x2rmaoT7Y?=
 =?us-ascii?Q?Z28K/5j9uE279zhWi1HqpM9pN0IEhtEXsKy/PH7CW3AmlczOYILkQORDSkkP?=
 =?us-ascii?Q?FcrfYyixtwpHW1S+XzjtCmC5ePp8CmfgZdsBAn0v/J/OxecedeSw1/IFZXro?=
 =?us-ascii?Q?tiASQhuPPwjUiaNuakjdh2r9Ey665oC4AHURifMxgiPyCWPrCZnUGb/K7Fcy?=
 =?us-ascii?Q?4vk4g53wtp8kD3d9RAH7gVdBn1DtmCShxTHtaPL3ImEt+XyUJTGisTTM25vx?=
 =?us-ascii?Q?NF+X0vIFLmBmcgJApJPDZPQMUy/qbCzUZXbHwQw2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 51d55f58-b8e5-47ee-e663-08dc2da30bf3
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 21:22:28.4742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZpAyu6aWSVPzz8P0mw6DN2VUEJiUi8Urjw2cJqvLPBfLoATokpCBoeUmqSrxXeetDPyZTkh5iITpNqHPLev/Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7638
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 10:23:10 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Wed, 14 Feb 2024 12:11:53 +0000
> > Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> > 
> > > So I'm thinking this is a won't fix - wait for the printk rework to land and
> > > assume this will be resolved as well?  
> > 
> > That pretty much sums up what I was about to say ;-)
> > 
> > tp_printk is more of a hack and not to be used sparingly. With the right
> > trace events it can hang the machine.
> > 
> > So, you can use your internal patch locally, but I would recommend waiting
> > for the new printk changes to land. I'm really hoping that will be soon!
> > 
> > -- Steve
> 
> Thanks Steve,
> 
> Ira's fix is needed for other valid locking reasons - this was 'just another'
> lock debugging report that came up whilst testing it.
> 
> For this patch (not a potential additional one that we aren't going to do ;)
> 
> Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks Jonathan!  I really appreciate the testing,
Ira