Received-SPF: pass (google.com: domain of linux-kernel+bounces-66080-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
References: <20240214202055.77776-1-sidhartha.kumar@oracle.com>
 <20240214202055.77776-2-sidhartha.kumar@oracle.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 akpm@linux-foundation.org, willy@infradead.org
Subject: Re: [PATCH 2/2] mm/migrate_device: further convert
 migrate_device_finalize() to folios
Date: Thu, 15 Feb 2024 09:45:16 +1100
In-reply-to: <20240214202055.77776-2-sidhartha.kumar@oracle.com>
Message-ID: <8734tu7jbe.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Uf8vkbjYqk5h8VdCyyx+ZNhFDirsek9hqLca0E138nL1Jm4DARVC4trwYNih?=
 =?us-ascii?Q?T5z7VtM2nuaZU/yxdOuD6Ixpit6CLNFfZg3XhRZP3ZjuIHrfGfsYTn5PS661?=
 =?us-ascii?Q?106QUfCBPljvEJ7evkMct+/snM4P7spw5qdBhGf4pePnLa/FkBYQB15XaoKh?=
 =?us-ascii?Q?2yfY/XuQvcV+wIYQSHzUgkV64WtagoS4hjcDzEps5S3+gP38rQdUqe6jF6QJ?=
 =?us-ascii?Q?tGKlpCwWomYOX5zQtBr7mmmMydW4Er2Z08OUiAA/B97qx+Owu9wXDob9i1EF?=
 =?us-ascii?Q?GM1O2a8/sJgBM+6FEVAaCH3e253l74E8JTRacvHci2Kbh+2aHUJctllDWT/V?=
 =?us-ascii?Q?AwjaU26QkzLLxu2Ju3ncxh9rfqf1yIMdMfuX2z8KEWyEIiE8XNGuS23W8C1Z?=
 =?us-ascii?Q?oG6IZA2NZTD+2K+FL4vOMMMR+bceCIuzDEzVdceWP87FMGN1CB3XZCgimWyt?=
 =?us-ascii?Q?+hi6Hn8OYnmY7X3bl6jNx12aN2P432l7xdrwgBLX7b1XU12+SN398eNu9wP9?=
 =?us-ascii?Q?cofZVNGDbDEZfKZpFemucTB00IU2nkru4XsmJGx8ofg3/H+1wAAuh8LI7JVX?=
 =?us-ascii?Q?FHi8l7uK0GPk83BfO4yF8vRI0JpYdMWYCKtf6jCnyHkAeU7bEecNHfWpmJE4?=
 =?us-ascii?Q?dL7lHPi871343k3mLymu/UITjVe+gfcjXmda25NXXd+nUXuGOsu++PR8Eie/?=
 =?us-ascii?Q?PVIQSMf1fNbdMLvCjdR5EN/FH8dILIi09n3s48AlGKnp3KlNn7LHLUu+KEzC?=
 =?us-ascii?Q?lFlcb4lNJ3hm9cFOJ5CmVohbhuQBs/6NeKkJjALFzIc0DrmvJ65qOhUcQI/T?=
 =?us-ascii?Q?qfsjYk87sGyLaSsCGuVmXHJGRaRtOSuYPF+WQgrW/rYsfMLczhcETsgbBKPG?=
 =?us-ascii?Q?MdDcJfVZzck/61SSINoZdF1ijAFk7EEdE9bBC19mA9LsHmHXWitiTtHjhoXh?=
 =?us-ascii?Q?gErT90jPqyjLeEaZHM6gsXYcPSkXPrNQ+ONAPUSt279g+GRh0sgbTgtjf/O4?=
 =?us-ascii?Q?3ieCMD+cCNwORyATbdzWnRJwz1hkCiGkEXGneVG+gDFPW/0gLVAodNY06wXd?=
 =?us-ascii?Q?JfA6CSq25tcMwbQHaAU5INHMvZ1O6eLgFzny465BiEzFcad/Ntn5HvT3kgKn?=
 =?us-ascii?Q?9zxAX8o7DEjuN5HsMBDirAchkVX9/oRS2lbXDfDWQJoDvRjngBbCnZz+sNX6?=
 =?us-ascii?Q?MC3d3pjJccT7D9IbxHq583C69nPJfGNqcyjpk8vlR/cBFGjfgBRs5gfFESBG?=
 =?us-ascii?Q?QQFpgCQhztvq3nrij91dK3R3ec3BnQ/qpOjg9XrGGFqS8l0gQJnABcm7Rr+d?=
 =?us-ascii?Q?H5ANQaaUp74muyaSTtsaH9UBVALeRNIBL3qRr60RVXJ8EWg4BuNNGOKn6Icl?=
 =?us-ascii?Q?dqt3cbwv5SkfbEy0LjH9TDr7RQW/t/KnOdhtnpeChTu296oDiDgtc3meNQjp?=
 =?us-ascii?Q?c6T5rBawaBFmJxejz0B2FwMYeYsDSFzsbYfImVvEEOmJuQqsLFaTynpUyGX4?=
 =?us-ascii?Q?42FqqB075yNRBZw85LxmzyR60xqsxmE4e8lvqnoNpgR4NyC3PC2xx3pHXQQk?=
 =?us-ascii?Q?FVovyDEfOoenQeChWRGncIZioCB4vUhpym1YQ8GS?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39074dc0-e532-431a-a4a2-08dc2daf3412
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 22:49:29.8659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tCVbZ2EnfzEQnQ6NqUWylvky2Pa7gSOIGxh5lAD42npOoFDGGQUtj5RUxXm9OrBLcSCamf7XQiMe4C4gF7AkXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8995


Sidhartha Kumar <sidhartha.kumar@oracle.com> writes:

> Use folio api functions from the already defined src and dst folio
> variables.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  mm/migrate_device.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
> index 9152a329b0a68..a48d5cdb28553 100644
> --- a/mm/migrate_device.c
> +++ b/mm/migrate_device.c
> @@ -843,17 +843,17 @@ void migrate_device_finalize(unsigned long *src_pfns,
>  		remove_migration_ptes(src, dst, false);
>  		folio_unlock(src);
>  
> -		if (is_zone_device_page(page))
> -			put_page(page);
> +		if (folio_is_zone_device(src))
> +			folio_put(src);
>  		else
> -			putback_lru_page(page);
> +			folio_putback_lru(src);
>  
>  		if (newpage != page) {
> -			unlock_page(newpage);
> -			if (is_zone_device_page(newpage))
> -				put_page(newpage);

Defining migrate_pfn_to_folio() would also allow the removal of the
newpage and page variables entirely which I think would make this
clearer.

As an aside is there any motivation for making these changes other than
as a general cleanup? I ask only because I have been looking at allowing
device pages with order > 0 so have some of these clean-ups in a local
tree as they're a pre-requisite for that.

 - Alistair

> +			folio_unlock(dst);
> +			if (folio_is_zone_device(dst))
> +				folio_put(dst);
>  			else
> -				putback_lru_page(newpage);
> +				folio_putback_lru(dst);
>  		}
>  	}
>  }