Received-SPF: pass (google.com: domain of linux-kernel+bounces-66099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ecec5590-1a96-9363-1209-342b4735096c@quicinc.com>
Date: Wed, 14 Feb 2024 15:04:45 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v15 18/50] ASoC: Add SOC USB APIs for adding an USB
 backend
Content-Language: en-US
To: Takashi Iwai <tiwai@suse.de>
CC: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
        <perex@perex.cz>, <conor+dt@kernel.org>, <corbet@lwn.net>,
        <lgirdwood@gmail.com>, <andersson@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
        <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
        <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
        <konrad.dybcio@linaro.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-sound@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <alsa-devel@alsa-project.org>
References: <20240213005422.3121-1-quic_wcheng@quicinc.com>
 <20240213005422.3121-19-quic_wcheng@quicinc.com>
 <87zfw4y717.wl-tiwai@suse.de>
From: Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <87zfw4y717.wl-tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Takashi,

On 2/13/2024 2:48 AM, Takashi Iwai wrote:
> On Tue, 13 Feb 2024 01:53:50 +0100,
> Wesley Cheng wrote:
>>
>> --- a/sound/soc/Kconfig
>> +++ b/sound/soc/Kconfig
>> @@ -76,6 +76,15 @@ config SND_SOC_UTILS_KUNIT_TEST
>>   config SND_SOC_ACPI
>>   	tristate
>>   
>> +config SND_SOC_USB
>> +	bool "SoC based USB audio offloading"
>> +	help
>> +	  Enable this option if an ASoC platform card has support to handle
>> +	  USB audio offloading.  This enables the SoC USB layer, which will
>> +	  notifies the ASoC USB DPCM backend DAI link about available USB audio
>> +	  devices.  Based on the notifications, sequences to enable the audio
>> +	  stream can be taken based on the design.
> 
> This should be tristate, and...
> 
>> --- a/sound/soc/Makefile
>> +++ b/sound/soc/Makefile
>> @@ -31,6 +31,10 @@ endif
>>   
>>   obj-$(CONFIG_SND_SOC_ACPI) += snd-soc-acpi.o
>>   
>> +ifneq ($(CONFIG_SND_SOC_USB),)
>> +snd-soc-core-objs += soc-usb.o
>> +endif
> 
> ... split it to an individual module, i.e.:
> 
> snd-soc-usb-objs := soc-usb.o
> obj-$(CONFIG_SND_SOC_USB) += snd-soc-usb.o
> 
> Otherwise it'll lead to a hard-dependency to snd-soc-core on
> snd-usb-audio, which is utterly unnecessary for most of other
> devices.
> 

Got it...getting this to compile as its own separate module also 
required some changes to the other layers I had.  Anyway, I've reworked 
some of the dependencies with other drivers and is working fine now.

Thanks
Wesley Cheng