Received-SPF: pass (google.com: domain of linux-kernel+bounces-66170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7c5fb62b-1414-4547-bbb2-93d0ca866c89@intel.com>
Date: Wed, 14 Feb 2024 16:00:10 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc:
 Remove setting Autoneg in EEE capabilities
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Ariel Elior <aelior@marvell.com>, Manish Chopra
	<manishc@marvell.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, "Tony
 Nguyen" <anthony.l.nguyen@intel.com>
CC: <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20240214-keee-u32-cleanup-v2-0-4ac534b83d66@lunn.ch>
 <20240214-keee-u32-cleanup-v2-5-4ac534b83d66@lunn.ch>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240214-keee-u32-cleanup-v2-5-4ac534b83d66@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QklJc0NlOHcrQk1ENVlHSllVVmNnTmh5UkNWUGYyc2xXZldsZDZxV2krbnpi?=
 =?utf-8?B?NjE4aTE0NGZhbnBMNnVXbGxicjNUbjBseEtMQmd5SGZ6UENUQnMxL29pTXFR?=
 =?utf-8?B?WEZUUUVlOXluOHlTbWVVa0k0YXFlYXNGSEpQRyttVm9pQkh6M1hhVEtDSmlj?=
 =?utf-8?B?WVhKcm54a3MzUmtlSVhKS0FBZnk4V3RHVmpuaWZGK1BxVkJERndkYTY2aWVv?=
 =?utf-8?B?R2FNSENhMTRjWGM4TXBrQ2pmMlgyd2Y0dEJQa0p5aWRBRVQzYWUyVmNmT3Nq?=
 =?utf-8?B?REtsQmRQOTBLbTZaWXJFSzU1akFwUnNtRC9xQ1NUdWFNYXB6eU9WcXZDazdF?=
 =?utf-8?B?clpNWHd1SXR5OEFVdGxQUFljanNHWU5ucUdWREw5V0xyZW5ORmZzcEdteUQw?=
 =?utf-8?B?L2tucGFCcFdiU0wydVhFb0hqMmlEWjQ4T2F2QWxmZmduQm1TSUp5SW90SzRp?=
 =?utf-8?B?blJYMHB3Vk5wT2NQbENOMC91V0o4bkMrZzhDa3ZKSmtDRDFkVjNsbEF4aTJV?=
 =?utf-8?B?YlkwTjFONGVXRGdLaXVqYjVqbkwwS3RXUEpCakttT1JRRUExSW9FWTE4aVZN?=
 =?utf-8?B?S3JsQ1NqRmwwYjhvTktRRytNWkhab0wrNjJFd282RERkcENjUTNnRmRIWmdk?=
 =?utf-8?B?UExmU3FTTVlFL3BSc09GbC95SnZlemtxUFNwZ21uTFRMYk03QlhFUjVOeUxu?=
 =?utf-8?B?elk2L2VWRHRrN09nRDMvRlVKay8vd1NCb1N0TUVQZEhzVU5KSkViWXYwREsz?=
 =?utf-8?B?WEFJMjRKa0JsQjl1SGhzRFUvWTVGRU5vazVkQlIzRDlyUzZHVnJZQkY5cjBZ?=
 =?utf-8?B?bFdnVk5RTEY4aDMwZE85U2duME9TUTJlWEw1SFMzOW9kdEhqeFZPd015dXY0?=
 =?utf-8?B?emFQcGROVlhKY25TOHZPaENrSWFMNHltdVI1Tk85Yk5SSWN2V1JPZDBNeW9o?=
 =?utf-8?B?YlVBaVNpUXhnQW9vWEhsRDBoM0RNTWUwUVNFei91d2w3K2lQTVhRaHBIVEdw?=
 =?utf-8?B?WDBNV3VEbDJUalRwaFludmdVejRUcUoxVDlJclFLVzYweURmRUlSaGsvQU03?=
 =?utf-8?B?UndTaFVkL1dLeU9NNjFhQ2JLMmtlRzBhMlo5MlgyNmlhYXlNT2I4QXRUTlMx?=
 =?utf-8?B?TVowd2pjL1pnTFZlTzRZYStxUVJ5L0FBTkljdDRFUGpRSFpIajVmQkJRdXBN?=
 =?utf-8?B?Uk5ESXJPOGVNR05vZlhtS3NIZnZqVXJwN2hSUllpUDcrY3VKN3p6VWV2UmdT?=
 =?utf-8?B?N3BSa2kraXUzQWlyS211N2Z6c0lXbXh1K211VFREN2JQajF1WnU2MEhPbU9y?=
 =?utf-8?B?NFRPbTFDREpyMVJvUVg4SjkzUkladTBOWVduR01NcjVvZnUyUk1GaXhhc3NG?=
 =?utf-8?B?bDQ0dkVxNHpQQy80Yk80bGU3dm9DTm82clViOWJrR2NaQ1RQVnZTVUE2RlBs?=
 =?utf-8?B?ZTB5N2JLMkdmTlpuSWMxSTBkZXFCY2ZaMjAxZ1lCTUd2dHBicW1rOVkwL0JB?=
 =?utf-8?B?ZkF0NEI5aENBTjVUeDIxaFRPK0xnS210VmZyalhxVU1LaC9mUjYxOC82T3Np?=
 =?utf-8?B?Sk9wMlJaU1lMWlBhYTNkR0s1TmVoc0J2S0JibWhOYjFQbzBhV050M0oxalRj?=
 =?utf-8?B?ZVcrWmd5bUl1VmtGQUNUbjAxT1R4SThINSs0V3BOZmduZlJ6and3MFdrWHU2?=
 =?utf-8?B?azlTQmVEYVJjYkJBQ1B6d0VtV3RQbndFejkxMzlsZmpRTSsvcjJaY0J4dTV0?=
 =?utf-8?B?c2tHSDBxYmVjaGtrRDNicXRSSm5VdHdkcUYrOUcxd3NrSEtDdGlteGdRK3lG?=
 =?utf-8?B?aHFGa0libWxRZnRXQzlNQ2JtUUVsV0YxVTNQK3UwbU1zMWR3WWhicys0ZDRS?=
 =?utf-8?B?QStUY2UvSGR4SVFLNXl3Z3lpTzdVcTBqWS9IV0FNdFNGSk5sTjZPVjJYYmpv?=
 =?utf-8?B?S2lWTzJONXBGdm9HdFpZY1RBb1FrdXR5MWpicmxMVDgvNmNuVzFIdWJabmsy?=
 =?utf-8?B?blpPRXZrcnBzNm11YmFTOHJFK2N6WitjVjV6Vmk0Y2JoN3Q1QmduR3BCZHYx?=
 =?utf-8?B?TjU5dHFMQVpsbUx1MkFxUU9iOHlZdTMxTW9CWVhxdk9ZUkJhWTdjMDAwYis4?=
 =?utf-8?B?dml1bGg0VDd5M2FuamFXdEEwMkdkb0ErMWRCMXBLbFltVWVCRGpZWTFWaXNN?=
 =?utf-8?B?aGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7394d845-b639-445b-e475-08dc2db91506
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 00:00:12.5560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: voZ9Vku3W1doGz48pVbT7eq1ZRDRJsHAUGEMDVHk6hXovRm/EdhKeSnDHhNUxIHyUQGSzAQacAlyj4UbCEzq3tQDa5Ql584Aix2BVdK/plA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7058
X-OriginatorOrg: intel.com


On 2/14/2024 3:13 PM, Andrew Lunn wrote:
> Energy Efficient Ethernet should always be negotiated with the link
> peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
> supported, advertised or lp_advertised, since it is
> assumed. Additionally, ethtool(1) ignores the set bit, and no other
> driver sets this.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---

I checked the git blame for both igc, and i40e both in-tree and in our
out-of-tree drivers which have this code. There is no explanation given
and it was just part of the original commits for implementing EEE
support for these two drivers.

I can't find any trace of a justification for this.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>