Received-SPF: pass (google.com: domain of linux-kernel+bounces-66209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240214202055.77776-1-sidhartha.kumar@oracle.com>
 <20240214202055.77776-2-sidhartha.kumar@oracle.com>
 <8734tu7jbe.fsf@nvdebian.thelocal>
 <df59f5e3-6c16-e371-f987-7776f2d24f15@oracle.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 akpm@linux-foundation.org, willy@infradead.org
Subject: Re: [PATCH 2/2] mm/migrate_device: further convert
 migrate_device_finalize() to folios
Date: Thu, 15 Feb 2024 11:58:54 +1100
In-reply-to: <df59f5e3-6c16-e371-f987-7776f2d24f15@oracle.com>
Message-ID: <87wmr6a6bu.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/pmM3/FtiiZr/L/gLLZvuydIdh6VDT2QR8pVcoype8v8QEYKJDiIrV47tHR5?=
 =?us-ascii?Q?A6Q6/F+BnTzteVOnBY1UP3YoQV4YEH4A4JN2FUTZZg3zzS23xTUIKaFZVQpE?=
 =?us-ascii?Q?zmfNCcOaFvj0Dzyr8/lx5xsvB001G+hGpRCjJcaUPCkKoZ4xy1T75Vgj5lk7?=
 =?us-ascii?Q?saL28lodHz5nFrdfgVS/4QpvEtTuPXjx6I2W/K3R5z6gfyQYSRNUPovaFkZo?=
 =?us-ascii?Q?6fd8FR+pg7dlQs0mzL9BvOP6eDvRGhGMESNjYDRfa8jnB9dMhsHTswul0fdF?=
 =?us-ascii?Q?wVNET/1JT0wsJcp3uY750jSxBPUUAW9VmT+TQ+jHl7RwVfxFXhmlkbBzEdkk?=
 =?us-ascii?Q?x3FaO1a4lLbbqIFQkBrSXMjTEyXtS7LFfe7L2qh2C2kpYbRHC7U5N4wnde/w?=
 =?us-ascii?Q?+UEjw4k+4P35Yi05HAu0aBV5MO8lt0TLH+qG3DZebMT1Uwwemkv5txN3Se2r?=
 =?us-ascii?Q?1OXFX/r9cICXqEKbiOGuyPv4zJI3ZUekavnVSHcm1pcolWOQLHsbcU67Klx9?=
 =?us-ascii?Q?vom32+qjkGHjCJKDDCrBpzU8hn/HHohoURT7/9OzQ1WyAAWmhgHu5RUgbTps?=
 =?us-ascii?Q?34KIOB5vV+ZayObkWWadoCz1KIuUlUZJMkeg2ZZwZfR/yyWMzwF/o+pvn0IU?=
 =?us-ascii?Q?FKUOh/L8AjSlPfgR4My6EDvK4MQcuDxVauQRTd5JEh/NnFRcFL8BNPRZ0bjM?=
 =?us-ascii?Q?ZxhJNy4pxq6a4qT5W4MpSbABvc7E5OwD7e76CIWb+CipbFUyEgeUt9LPYtnU?=
 =?us-ascii?Q?NTtX0EC7nNSiDwatS2uz50nV2NKYiTHT09Qhs+aKcLCnPiaURiNFOO5kYvuB?=
 =?us-ascii?Q?mjv/lkHfjzy7oNMnqbZJG0YaqpC+g63HOADqoCjH46c+lRH7zXxhOyWUvsP/?=
 =?us-ascii?Q?sxDqJv0ZFSkp3suKKlqNh8UHnE6s5TI8p2v4iRk2Jxn35fERRECxdwpQUOif?=
 =?us-ascii?Q?PPwKPGkpipn/VdPRhcuwUZtoCVNyyRHtT+VhPC/hXRoVDLk0a4189zycno4/?=
 =?us-ascii?Q?EvQ/AP3dr5/xX6L5WpxdOe8yEZKQUMArtbtDT5wsJm43ZfjZaHx3MGrkq5On?=
 =?us-ascii?Q?6RqUgqk0oXW+z6Ck75hwgnsu4olFZieXtGWOwgp3f5E/g9bWMO9wUsTlMr2v?=
 =?us-ascii?Q?8cs+WlNSVmvwYlNluX5fc3sb0XbVKotHi5FS2f4auAE4AUgh28C9kW21YAMG?=
 =?us-ascii?Q?SELtR0M/EDPyrPJQp1D93XlYAn5jrC4AgLh1V+NJtcAMQrC6FK04YW0y9mNR?=
 =?us-ascii?Q?CZnjOmmOECB3QM8Pxh+PnmJTSg3E5de9TYc1ZTgEeqwzAZooGfamlJjbYskF?=
 =?us-ascii?Q?jU68/sQw0w0Lugfs847rfWhcpYbK2l52ToZMX7qitmZCYZz5DxGO68dHDEj5?=
 =?us-ascii?Q?fQblGzqbwlt/VJ41DlmthzVhiNPtk+3SLF3nwZLwoxHhbJhBkDKXKl7hEJNv?=
 =?us-ascii?Q?BgKud/T8TWRhiy30JzmT+VudT8rvjQhjl3vCIbge/d4D1BxsjmHpbpZxL3T3?=
 =?us-ascii?Q?m0rveHl24eFdfLMHOU5V57OTTvcWIgDiahNLh9cjbmkb8pYbdnaagYccNvOG?=
 =?us-ascii?Q?Z9DCZuDqltIXtUkmlj+WkxWIpJ8hE2exgAk7WkzD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53a2e91f-f4a4-43bc-8ddb-08dc2dc1ae69
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 01:01:45.9032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i+ddOjOswFFtKpX/9ahybGPVsbh57+9DxLo4+Zy0peR5zZkrI4n8LLmbdmuo/XRfLR7b3p9c1rqKl2GfvAJgXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7436


Sidhartha Kumar <sidhartha.kumar@oracle.com> writes:

> On 2/14/24 2:45 PM, Alistair Popple wrote:
>> Sidhartha Kumar <sidhartha.kumar@oracle.com> writes:
>> 
>>> Use folio api functions from the already defined src and dst folio
>>> variables.
>>>
>>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>>> ---
>>>   mm/migrate_device.c | 14 +++++++-------
>>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
>>> index 9152a329b0a68..a48d5cdb28553 100644
>>> --- a/mm/migrate_device.c
>>> +++ b/mm/migrate_device.c
>>> @@ -843,17 +843,17 @@ void migrate_device_finalize(unsigned long *src_pfns,
>>>   		remove_migration_ptes(src, dst, false);
>>>   		folio_unlock(src);
>>>   -		if (is_zone_device_page(page))
>>> -			put_page(page);
>>> +		if (folio_is_zone_device(src))
>>> +			folio_put(src);
>>>   		else
>>> -			putback_lru_page(page);
>>> +			folio_putback_lru(src);
>>>     		if (newpage != page) {
>>> -			unlock_page(newpage);
>>> -			if (is_zone_device_page(newpage))
>>> -				put_page(newpage);
>> Defining migrate_pfn_to_folio() would also allow the removal of the
>> newpage and page variables entirely which I think would make this
>> clearer.
>> As an aside is there any motivation for making these changes other
>> than
>> as a general cleanup? I ask only because I have been looking at allowing
>> device pages with order > 0 so have some of these clean-ups in a local
>> tree as they're a pre-requisite for that.
>>   - Alistair
>> 
>
> Hello,
>
> The motivation is just general cleanup. In folio-compat.c I saw that
> putback_lru_page() does not have much users left so I could convert
> them and then just get rid of putback_lru_page(). Should I still
> continue with a v2 that will include defining a migrate_pfn_to_folio()
> or wait for your clean-ups?

No, don't wait for mine. Please continue with defining
migrate_pfn_to_folio() for v2, I was just curious in case you had some
larger goal in mind.

Thanks.

 - Alistair

> Thanks,
> Sid
>
>>> +			folio_unlock(dst);
>>> +			if (folio_is_zone_device(dst))
>>> +				folio_put(dst);
>>>   			else
>>> -				putback_lru_page(newpage);
>>> +				folio_putback_lru(dst);
>>>   		}
>>>   	}
>>>   }
>>