Received-SPF: pass (google.com: domain of linux-kernel+bounces-66216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?utf-8?B?7J207Iq57Z2s?= <sh043.lee@samsung.com>
To: "'Ulf Hansson'" <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<gregkh@linuxfoundation.org>, <avri.altman@wdc.com>,
	<grant.jung@samsung.com>, <jt77.jang@samsung.com>,
	<dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
	<jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
	<sh8267.baek@samsung.com>, <wkon.kim@samsung.com>, <sh043.lee@samsung.com>
In-Reply-To: <CAPDyKFrjZ4jRHAfXsvrEvezuHTxbA3SAniF8CuObyLuW=AUoeA@mail.gmail.com>
Subject: RE: [PATCH] mmc: sd: Add a variable to check a faulty device
Date: Thu, 15 Feb 2024 10:03:45 +0900
Message-ID: <000001da5faa$d34e1600$79ea4200$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI2QrZr/hQwBfLmGOt++EZEApv72gJjevE2AeL7/EiwMJcOEA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20240213051332epcas1p1f45d02dc34d1b95ea5608ab779d6b6cc@epcas1p1.samsung.com>
	<20240213051716.6596-1-sh043.lee@samsung.com>
	<CAPDyKFrjZ4jRHAfXsvrEvezuHTxbA3SAniF8CuObyLuW=AUoeA@mail.gmail.com>

> -----Original Message-----
> From: Ulf Hansson <ulf.hansson=40linaro.org>
> Sent: Wednesday, February 14, 2024 8:27 PM
> To: Seunghui Lee <sh043.lee=40samsung.com>
> Cc: linux-mmc=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> gregkh=40linuxfoundation.org; avri.altman=40wdc.com; grant.jung=40samsung=
com;
> jt77.jang=40samsung.com; dh0421.hwang=40samsung.com; junwoo80.lee=40samsu=
ng.com;
> jangsub.yi=40samsung.com; cw9316.lee=40samsung.com; sh8267.baek=40samsung=
com;
> wkon.kim=40samsung.com
> Subject: Re: =5BPATCH=5D mmc: sd: Add a variable to check a faulty device
>=20
> On Tue, 13 Feb 2024 at 06:13, Seunghui Lee <sh043.lee=40samsung.com> wrot=
e:
> >
> > In mobile devices, suspend/resume situations are frequent.
> > In the case of a defective SD card in which initialization fails,
> > unnecessary initialization time is consumed for each resume.
> > A field is needed to check that SD card initialization has failed on
> > the host. It could be used to remove unnecessary initialization.
>=20
> It's not clear to me, under what circumstance you want to optimize for.
>=20
> Is the SD card ever getting properly initialized during boot?
>=20
> Kind regards
> Uffe
>=20
We receive a lot of reports about SD card issues in the market.
There was no problem with the first time at the time of use, and there are =
many cases where people recognize that it is not recognized later on. In mo=
st cases, this is a problem with the SD card itself.

SD card users cannot determine whether or not an SD card is a problem, so t=
hey should be guided in this regard.
It is necessary to distinguish whether the SD card is inserted but unrecogn=
ized or the SD card itself is not inserted, and if there is a field that ca=
n check for initialization failure, it will facilitate guidance, so we cons=
idered the patch.

The variable's usage is expected to be used through the sysfs node in the v=
endor module.
> >
> > Signed-off-by: Seunghui Lee <sh043.lee=40samsung.com>
> > ---
> >  drivers/mmc/core/sd.c        =7C 12 +++++++++++-
> >  drivers/mmc/core/slot-gpio.c =7C  1 +
> >  include/linux/mmc/host.h     =7C  1 +
> >  3 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index
> > c3e554344c99..f0eb3864dc24 100644
> > --- a/drivers/mmc/core/sd.c
> > +++ b/drivers/mmc/core/sd.c
> > =40=40 -1410,6 +1410,7 =40=40 static int mmc_sd_init_card(struct mmc_ho=
st *host,
> u32 ocr,
> >         bool v18_fixup_failed =3D false;
> >
> >         WARN_ON(=21host->claimed);
> > +       host->init_failed =3D false;
> >  retry:
> >         err =3D mmc_sd_get_cid(host, ocr, cid, &rocr);
> >         if (err)
> > =40=40 -1752,6 +1753,8 =40=40 static int _mmc_sd_resume(struct mmc_host=
 *host)
> >
> >         mmc_power_up(host, host->card->ocr);
> >         err =3D mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       if (err)
> > +               host->init_failed =3D true;
> >         mmc_card_clr_suspended(host->card);
> >
> >  out:
> > =40=40 -1803,8 +1806,12 =40=40 static int mmc_sd_runtime_resume(struct
> > mmc_host *host)
> >
> >  static int mmc_sd_hw_reset(struct mmc_host *host)  =7B
> > +       int err;
> >         mmc_power_cycle(host, host->card->ocr);
> > -       return mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       err =3D mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       if (err)
> > +               host->init_failed =3D true;
> > +       return err;
> >  =7D
> >
> >  static const struct mmc_bus_ops mmc_sd_ops =3D =7B =40=40 -1891,5 +189=
8,8 =40=40
> > int mmc_attach_sd(struct mmc_host *host)
> >         pr_err(=22%s: error %d whilst initialising SD card=5Cn=22,
> >                 mmc_hostname(host), err);
> >
> > +       if (err)
> > +               host->init_failed =3D true;
> > +
> >         return err;
> >  =7D
> > diff --git a/drivers/mmc/core/slot-gpio.c
> > b/drivers/mmc/core/slot-gpio.c index 2a2d949a9344..93d081c7dd53 100644
> > --- a/drivers/mmc/core/slot-gpio.c
> > +++ b/drivers/mmc/core/slot-gpio.c
> > =40=40 -33,6 +33,7 =40=40 static irqreturn_t mmc_gpio_cd_irqt(int irq, =
void
> *dev_id)
> >         struct mmc_gpio *ctx =3D host->slot.handler_priv;
> >
> >         host->trigger_card_event =3D true;
> > +       host->init_failed =3D false;
> >         mmc_detect_change(host,
> > msecs_to_jiffies(ctx->cd_debounce_delay_ms));
> >
> >         return IRQ_HANDLED;
> > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index
> > 2f445c651742..1d75cfdbf981 100644
> > --- a/include/linux/mmc/host.h
> > +++ b/include/linux/mmc/host.h
> > =40=40 -467,6 +467,7 =40=40 struct mmc_host =7B
> >         struct timer_list       retune_timer;   /* for periodic re-tuni=
ng */
> >
> >         bool                    trigger_card_event; /* card_event neces=
sary */
> > +       bool                    init_failed;    /* check if failed to
> initialize */
> >
> >         struct mmc_card         *card;          /* device attached to t=
his host
> */
> >
> > --
> > 2.29.0
> >