Received-SPF: pass (google.com: domain of linux-kernel+bounces-66217-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: SeongJae Park <sj@kernel.org>
To: shuah@kernel.org
Cc: "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>,
	SeongJae Park <sj@kernel.org>,
	keescook@chromium.org,
	linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Vijaikumar_Kanagarajan@mentor.com,
	brauner@kernel.org,
	jlayton@kernel.org,
	jack@suse.cz
Subject: Re: [PATCH] selftests/mqueue: Set timeout to 100 seconds
Date: Wed, 14 Feb 2024 17:13:09 -0800
Message-Id: <20240215011309.73168-1-sj@kernel.org>
In-Reply-To: <20240209174243.74220-1-sj@kernel.org>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A gentle reminder.


Thanks,
SJ

On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <sj@kernel.org> wrote:

> On Fri, 9 Feb 2024 10:30:38 +0000 "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com> wrote:
> 
> > On 08/02/2024 21:29, SeongJae Park wrote:
> > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> > > 
> > > 
> > > 
> > > While mq_perf_tests runs with the default kselftest timeout limit, which
> > > is 45 seconds, the test takes about 60 seconds to complete on i3.metal
> > > AWS instances.  Hence, the test always times out.  Increase the timeout
> > > to 100 seconds.
> > > 
> > > Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
> > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > Signed-off-by: SeongJae Park <sj@kernel.org>
> > > ---
> > >   tools/testing/selftests/mqueue/setting | 1 +
> > >   1 file changed, 1 insertion(+)
> > >   create mode 100644 tools/testing/selftests/mqueue/setting
> > > 
> > > diff --git a/tools/testing/selftests/mqueue/setting b/tools/testing/selftests/mqueue/setting
> > > new file mode 100644
> > > index 000000000000..54dc12287839
> > > --- /dev/null
> > > +++ b/tools/testing/selftests/mqueue/setting
> > > @@ -0,0 +1 @@
> > > +timeout=100
> > > --
> > > 2.39.2
> > > 
> > >
> > 
> > Added Vijai Kumar to CC
> > 
> > This looks similar to [PATCH] kselftest: mqueue: increase timeout 
> > https://lore.kernel.org/lkml/20220622085911.2292509-1-Vijaikumar_Kanagarajan@mentor.com/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7 
> > which was increasing the timeout to 180 however it's not clear why this 
> > hasn't been merged yet.
> 
> Thank you.  I don't care who's patch would be picked, but hope any of those be
> merged.  For more eyes, I'm Cc-ing contacts from
> `./scripts/get_maintainer.pl ipc/mqueue.c` output.
> 
> > I have seen the same issue on v5.15.y so it's 
> > very likely that we will need to apply this on all LTS branches not just 
> > 5.4 as mentioned in Cc: <stable@vger.kernel.org> # 5.4.x
> 
> Yes, that's the intent of the Fixes: and Cc: <stable@vger.kernel.org> lines.  I
> hope the lines to be added to Vijai's patch if it is picked instead of this.
> 
> 
> Thanks,
> SJ
> 
> > 
> > Hazem
> >