Received-SPF: pass (google.com: domain of linux-kernel+bounces-66236-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <20240213055554.1802415-5-ankur.a.arora@oracle.com>
 <ZczKQceazAevmNtL@FVFF77S0Q05N>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Ankur Arora <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, peterz@infradead.org,
        torvalds@linux-foundation.org, paulmck@kernel.org,
        akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
        mgorman@suse.de, jpoimboe@kernel.org, jgross@suse.com,
        andrew.cooper3@citrix.com, bristot@kernel.org,
        mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
        glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
        mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
Subject: Re: [PATCH 04/30] sched: make test_*_tsk_thread_flag() return bool
In-reply-to: <ZczKQceazAevmNtL@FVFF77S0Q05N>
Date: Wed, 14 Feb 2024 18:04:00 -0800
Message-ID: <87frxupjov.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Bgfqc9QyqPukgLuXRQ3EGw7oMeZKZMVxa0zkmI9QCqXs/SueGmei2OcPi1Db?=
 =?us-ascii?Q?66JpcLgHk8AVnSi6LaWx+0WJdl4uAWh6f5h1EvxTu6ndKZ6QAW/+Vju5oXwd?=
 =?us-ascii?Q?+friRSlFuMc9mQFz0zcnMJXjeJ55ljgt2HtsICc81KKE5m9YdW3zVVystVDb?=
 =?us-ascii?Q?5AUeYa0NiWaJhWZGzGDM6jL1x6zdpJNtRXEdX7nZ6shURGf81/OcH1xoN21z?=
 =?us-ascii?Q?sHgQdg5ww/pFWoCwKMPsvEnfb0bi5SdqFdRXffVn4fZkxtvFHBRj0bq3ap6e?=
 =?us-ascii?Q?sC18yMtfQW6RelYVMJfh6AosZADSWtL61tZXL6027wmesgy95dyz1e4Vyh8/?=
 =?us-ascii?Q?H33RBIPfkLOf2XDP250HNPy+2fBCyIJ8Sh/kkRdHTJHdp03nILf4wzA3TA9L?=
 =?us-ascii?Q?DDrRMj0cDhInNtlrfp0/PHORKoo1EBh+pgN0hul2vSawF9c2A1QDgQCZwUb5?=
 =?us-ascii?Q?Skwm78VtwFkiY98AiHL9IgKeVDPTGaC2rRW30cUwBwBdzxv+7CWFL6SZTsxr?=
 =?us-ascii?Q?XOFkmk3r/Ss8DWIySM4tQmtjGmjDa7R3TlIisLYCNt7mkpMBtDsU0aE/OLiR?=
 =?us-ascii?Q?ycwdsDxLGq5sQvdzl2tvaT3QBb+m5lkGg+x9oUItA7AvG4NmFQdWJfhXc2RO?=
 =?us-ascii?Q?CsDa4DfuCr3z7ffeFg92l6gwuWG7ktOiYY5eDfQJBleXYTXv2wBb2mDwU0Vs?=
 =?us-ascii?Q?Kcncqb+xj7Z8qiFveCZGQ4O1+2XkT514FNtKiqkBoDPQvhIKMJXYWVtxfsvJ?=
 =?us-ascii?Q?gKKzsuna7E9WcaZf5Ehtv/OAUFMp8GrkBfWCgMd0klWRwWoMKFaue2GvNAwf?=
 =?us-ascii?Q?NuBlY3RK5GQQ7SP6iGybNDTsJlUXlZd5p6hNHjKWa6CdNGpMNIbgYqnHvRyH?=
 =?us-ascii?Q?CBU7mQbpnwS3PN9O82quiP16raP/2ZlxX0HJjWu7rjPejmsKGEUBm4GLtw7W?=
 =?us-ascii?Q?n0BozgJrjiFRFuAIxfKUkJ9o/hy3UhirMpNzBUdr1AojePAWhFHPsMpO54c6?=
 =?us-ascii?Q?mB+Qp0cAve3GAV3G3XwMp3y5TKnw8OtXzkiFImcNeYPS57ugfTk85B5LGyJo?=
 =?us-ascii?Q?mxWnbl+ta8xgXv3Q6IhupU2wY/JxQUm9Dsl3NdJdZfBz5nbFwp848tBsb4Yf?=
 =?us-ascii?Q?0ulcmcvdmlLYxl89FofBqcpSV81gg7ftvCfCDPcM+pZZp86BysVdmToj3uCC?=
 =?us-ascii?Q?1UrIWx+gGPAVrc7WtlkMtyf64Wcitgr5P71fq6gSGOHGl9+Bl8vgyAXFaEzd?=
 =?us-ascii?Q?RPbZ4XYXHRTkVcbNBPP+e9GkegwWuhDMGHN9NG4+QM5HhEKPHsP5uSKKgvv5?=
 =?us-ascii?Q?/TY43b0ZDGxq9gEzMiDowW1mir1WG1vuUFXV85I7QrPGKcxxddRO+bqTj6gk?=
 =?us-ascii?Q?XGzinV/Dv0SrX3TKLw2px+bbQ0fnqF/pz0GLLu6SfwI1cmctwtDSQjJkPEmG?=
 =?us-ascii?Q?kgoFMf6WWnLlNE1vEXxVmk9UbNeK2dxhVxojt4JGTV15EUGU9lduSIngKmBQ?=
 =?us-ascii?Q?xqzk4OF3TecaeOO1MtA7CHoU7LpwvLZh+/4kO3LIipm2Jc/v9jvYMOnYRI1a?=
 =?us-ascii?Q?AzEzdOjjc8h+YaBwkkypeP+v2IGTi1nQ5TD1c75Ll5fEOqE/+MYKR/xPLMlh?=
 =?us-ascii?Q?OA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	QkMdI4ovn93aiwXasHGjv4zs5F3E3+QHycuX5cVnMAxH1GAJEOe9YWUftySYB1NMUqnGXJ+xaTf/hOcPwDtfunsdXjDD4WT3zpZlueccTy3Lbw9uMgw69O81hW5Hwgd3sRBAZHU1UqM2kx8l4yyCA5h3AHIaIJg2jfp4/csArkTaHMsy32YUs/auzs1efh4mNNxi7DsFyXVMAR29PGIwG/2OXQd0tgQ3wzMp8vuTdHNfigdZraW+UnTGAWb1lbtvO2CDEwPYSKXnnEg9TFn1L/8pIO3Sw1oa7MF6TrmYcZsULcZGyyKLDCzt2Z6ESsoIrub/3JwdN2q7QTA8igzcAaM4sph2kV6Vb+XHoVOCm9SFNNpyO5hD7iyUaq7VBvjw3yuC7dnjCQdECKNMDwK8XMnTNqYT3qN8Lf8gDPmncrr5bolf0//6l6Us+5b5bL4+uoUov5/5f5gS3D89CaFBwtHGltcS9SR0R1WuxVu3SC++ZONHaL4dpU1PIT/uJ+iMN83ZIRxaBWr0xGuDR6/nVjlNRsT72PvTXFpF3KDaGBJVUlNr6Br7xyUJ6EsQAfhNBUzbfp97UiY7KygurpOph6DluaLI2ghQ3J2tL3Tcqes=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8911b70-0360-4bb1-aceb-08dc2dca56e3
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 02:03:44.5277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K4Fnlw3/9MMiz63VdhJjHoaXdYt2xwONzmLv8gqkutTx2a5r7cP9FnKrnrozbRudGFVR2FJhYmeCWEpiGDfTRywSOPXx8wmLBdXzuHn70a0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5680
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_02,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0
 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=909 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402150015
X-Proofpoint-ORIG-GUID: I26_ZiUrkLNwPRfXrzW-P3Xqh1Ilqs8Y
X-Proofpoint-GUID: I26_ZiUrkLNwPRfXrzW-P3Xqh1Ilqs8Y


Mark Rutland <mark.rutland@arm.com> writes:

> On Mon, Feb 12, 2024 at 09:55:28PM -0800, Ankur Arora wrote:
>> All users of test_*_tsk_thread_flag() treat the result as boolean.
>> This is also true for the underlying test_and_*_bit() operations.
>>
>> Change the return type to bool.
>>
>> Cc: Peter Ziljstra <peterz@infradead.org>
>> Originally-by: Thomas Gleixner <tglx@linutronix.de>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks.

> I think this makes sense on its own regardless of the rest of the series; it
> might make sense to move it to the start of the series so that it can easily be
> picked up even if the rest needs work.

Yeah that makes sense. Will do.

--
ankur