Received-SPF: pass (google.com: domain of linux-kernel+bounces-66272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 15 Feb 2024 14:47:36 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Oscar Salvador <osalvador@suse.de>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the mm tree
Message-ID: <20240215144736.21e8c19f@canb.auug.org.au>
In-Reply-To: <20240214071938.f8ca072c08e618b483bae1c7@linux-foundation.org>
References: <20240214145719.1cc4f320@canb.auug.org.au>
	<20240214071938.f8ca072c08e618b483bae1c7@linux-foundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/KDdd4i5c=QStkA6TAQbhr9v";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/KDdd4i5c=QStkA6TAQbhr9v
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Andrew,

On Wed, 14 Feb 2024 07:19:38 -0800 Andrew Morton <akpm@linux-foundation.org=
> wrote:
>
> On Wed, 14 Feb 2024 14:57:19 +1100 Stephen Rothwell <sfr@canb.auug.org.au=
> wrote:
>=20
> > After merging the mm tree, today's linux-next build (sparc defconfig)
> > failed like this:
> >=20
> > In file included from include/linux/page_ext.h:7,
> >                  from include/linux/mm.h:22,
> >                  from fs/sysfs/file.c:18:
> > include/linux/stackdepot.h:59:39: error: 'CONFIG_STACKDEPOT_MAX_FRAMES'=
 undeclared here (not in a function)
> >    59 |                 unsigned long entries[CONFIG_STACKDEPOT_MAX_FRA=
MES];    /* Frames */
> >       |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~=
~~~
> >=20
> > (and many more)
> >=20
> > Caused by commit
> >=20
> >   18d4230bb372 ("lib/stackdepot: move stack_record struct definition in=
to the header") =20
>=20
> Thanks, I'll try this.
>=20
>=20
> --- a/include/linux/stackdepot.h~lib-stackdepot-move-stack_record-struct-=
definition-into-the-header-fix
> +++ a/include/linux/stackdepot.h
> @@ -39,6 +39,7 @@ typedef u32 depot_stack_handle_t;
>  #define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \
>  			       STACK_DEPOT_EXTRA_BITS)
> =20
> +#ifdef CONFIG_STACKDEPOT
>  /* Compact structure that stores a reference to a stack. */
>  union handle_parts {
>  	depot_stack_handle_t handle;
> @@ -73,6 +74,7 @@ struct stack_record {
>  		};
>  	};
>  };
> +#endif
> =20
>  typedef u32 depot_flags_t;
> =20
> _
>=20

Works for me.

--=20
Cheers,
Stephen Rothwell

--Sig_/KDdd4i5c=QStkA6TAQbhr9v
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXNiVgACgkQAVBC80lX
0GxrVgf7B3HdXv1Cvhvc8iVm301x25+WCxOcamW3CCVVZLLdWO0xuuJutjqXNwdU
wQ9zecGtrsKz2GU4CmNrthDTzSqCkvLOiFhfArd47GlOX9exzrUQ9IiwWD71bjps
6aNin3cbTQ2kZFF5U1hBMLzdMJyWYrLK8eOHeIwCIaL9rw68SfcNFBAhpmLVIhd8
14LeyV2RSxCRt94tVbFxXOYQhuIl4euFMtLlkEcUiyGZ1U43UdIk1U1swZ7XgtKV
NwMgkf3Hh7HZC/cacs55jzD6lQAEfKyNfOOSa5NiijrUmmjNfIHziPkmepMXN58b
wtAH73G9UUjllelV5mLx+pllOJHByg==
=l3Fb
-----END PGP SIGNATURE-----

--Sig_/KDdd4i5c=QStkA6TAQbhr9v--