Received-SPF: pass (google.com: domain of linux-kernel+bounces-66276-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 14 Feb 2024 23:04:48 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
        Kees Cook <keescook@chromium.org>,
        Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
        mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev,
        mgorman@suse.de, dave@stgolabs.net, willy@infradead.org,
        corbet@lwn.net, void@manifault.com, peterz@infradead.org,
        juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org,
        arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com,
        david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org,
        masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org,
        tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org,
        paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com,
        yuzhao@google.com, dhowells@redhat.com, hughd@google.com,
        andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com,
        gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com,
        vschneid@redhat.com, cl@linux.com, penberg@kernel.org,
        iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com,
        elver@google.com, dvyukov@google.com, shakeelb@google.com,
        songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com,
        minchan@google.com, kaleshsingh@google.com, kernel-team@android.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev, linux-arch@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-modules@vger.kernel.org, kasan-dev@googlegroups.com,
        cgroups@vger.kernel.org
Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook()
 __always_inline
Message-ID: <20240215040448.ycfrrqbv6chjeysy@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	Kees Cook <keescook@chromium.org>,
	Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
	mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev,
	mgorman@suse.de, dave@stgolabs.net, willy@infradead.org,
	corbet@lwn.net, void@manifault.com, peterz@infradead.org,
	juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org,
	arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com,
	dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com,
	david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org,
	masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org,
	tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org,
	paulmck@kernel.org, pasha.tatashin@soleen.com,
	yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com,
	hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com,
	vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com,
	ytcoode@gmail.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
	bristot@redhat.com, vschneid@redhat.com, cl@linux.com,
	penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com,
	glider@google.com, elver@google.com, dvyukov@google.com,
	shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com,
	rientjes@google.com, minchan@google.com, kaleshsingh@google.com,
	kernel-team@android.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-modules@vger.kernel.org,
	kasan-dev@googlegroups.com, cgroups@vger.kernel.org
References: <20240212213922.783301-1-surenb@google.com>
 <20240212213922.783301-24-surenb@google.com>
 <202402121631.5954CFB@keescook>
 <3xhfgmrlktq55aggiy2beupy6hby33voxl65hqqxz55tivdbbi@j66oaehpauhz>
 <6370b20f-96fb-4918-bef0-7555563c9ce2@suse.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6370b20f-96fb-4918-bef0-7555563c9ce2@suse.cz>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?gYLFJ8fk4kEAKbBsM7PU3Fx9HcRMAOf2K2KfqiRVu5H2EXh656UVyGQD3AKX?=
 =?us-ascii?Q?QKZT+LYbYApmFNAaz5gqF1qw3zb5xHls+H/NgQz1JrpT6NomDnN+ZyESFMST?=
 =?us-ascii?Q?ULkjbEQcf8iaUmbxSTrCTo4QkQL18mG82T31tS5V4BndQCVVXHyPq5fM0tUq?=
 =?us-ascii?Q?jQELAio5VgSoGrPj1Wo1vg9uKup+LHeMXFjAJ2g+AcatwsLk9aHzaCdLIN21?=
 =?us-ascii?Q?fGK1KGKQCeFUL7lcGCPp8J7kFBCwdGr1OFymdoticBg7Pd6OGd1jQtEvtEhO?=
 =?us-ascii?Q?bj0/x/FNSBCe+FLAow0Ce7Cugh/Z9FMvxaO16nhxh9PGk7WevJiGFx1awQ7t?=
 =?us-ascii?Q?7U+Q76iR6f/e7uxTBB8iTGbccq6bWYzyGWJTYExoXfTHHQTjtBimCou5IoWx?=
 =?us-ascii?Q?ZhH7IzUXJhYy9jG29lgKQyKTrbPaCoXiMiqkXvKzCKA0O6SI5TBNYt0AQNbK?=
 =?us-ascii?Q?4vDX+ClVTZKIcbgefAoe6B54ja1lmFQN+Ys0QzS2fR+RNv2YmzVai1RvS1SP?=
 =?us-ascii?Q?/D+bH1gkvqJWojNwZSebG76nPNYlze1f/qqPOBhKX2aeDTzUjSP3SJ4lc/7y?=
 =?us-ascii?Q?xuGwL8HaNE9lPHwxjd2uHRC7Fhc2nL5Lmxh3I+JR9yEbOizgECoZ9g3Hl2DJ?=
 =?us-ascii?Q?xCr9FyrbegDB7WBHkQ8JNbBkMlYN4aLHO5aAfWEo2vq5GezDadI5peoULyO1?=
 =?us-ascii?Q?KJNUTNGA1ILG4tOvONpuoXNIisoEQKPrEZybVQ295s8KmEVexUpT5AaVKpm1?=
 =?us-ascii?Q?CMYYbv/5x5eazKxv7Seadg1kZ0FyBjkEFko/17Hr81/NMcHoH1SfM8cvr4uO?=
 =?us-ascii?Q?ftCSdkZpRXnNaA6vi8UuCfNyWOsGhrJC8sbwPm6OqZhwBm4Glalb1tT/UB7/?=
 =?us-ascii?Q?XJ97kPw24tm3BaVd6hXPzIZFkGrfCNywcmjU6u9j0qecXKPoMmiRlHgvt1XY?=
 =?us-ascii?Q?cP4fetV3C/t++XqhAwbeZ2q+zJ2sBb1xtuF//dPQlzC+vXjpMnc55TXTah0r?=
 =?us-ascii?Q?8+ZL4MZs+b/vpp6a94j/h6bMtJnW+CUuL1roJ3scaY/UQdsDVnCSoYdWa+zf?=
 =?us-ascii?Q?aIwWSU2niqj6NPyMv4I3IOffivp4IExwKwQ8dkRa78Tidy6bGv40oXctG5FK?=
 =?us-ascii?Q?OtYqxu91PgTt+KMbPUNQPa6N0RIwqfeOxICkcP/5JA12ypgxl3xG4ScUvvMy?=
 =?us-ascii?Q?ZLXbmGXZ9E6ttr0xTLZ59K3Hg1uX7fo7IKNFAs09CQ3OXVmeSa0/U71rb8RI?=
 =?us-ascii?Q?XEIqeQeX9nj/udZl9T/weML9NRmeMTIS5N7qL18V9LTb/Xz+cg6jYB/vrbW8?=
 =?us-ascii?Q?TLDDt4PVSJUU1dM2skZ2fSVUDxAxIjhkk8HUnBpIZhzvdxTAXfRBNIOzcu51?=
 =?us-ascii?Q?1b+M9fULp1Sq50A8pZzrT+c3sk7HzPI9gGzvYPDKTsqnu8OftkaFSB1bzIvK?=
 =?us-ascii?Q?YJjFBfopP6QeW5C4kH3xoJoX6IArf4aemMSg+qUaNH1Jd/yngZpvEV/LDXyB?=
 =?us-ascii?Q?rhPYPRS0X28DHb0F9oxhB7ThKBa1h5l7N4t2c15L3Yno81OPMhXQn5/x+s5O?=
 =?us-ascii?Q?HyEx3zvyUbz0KvV2lgYY9nRe1jydQIvVZZpd10GF?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	aCh0UgjHDkw1eoodF+Q5GMZmH3K79/rYuhMSZww3lHo2b3Ix91YkBnH+0hLAXJ1v4D+CIxcNTTZIICO4e9nvcZ+hkmJUgLwSyHrhf1uATUHMA3tSHkCNr5NJyKT0bqTmBp2jpUNmaqHcZc54Vm9IQJhCraktNv9oHOFO8xa8xSgf6TdgxOrsLkEjLgTs6wDuN6DpImW/TfIkvK7XnyKaY14cM2aj2TzmsdzlYEOW2t7YlsE/yBl83/3Td2Z/F4yIpuwqMQ76tQlW8c/92jYSFs6/q+C9GSZKCwHpYUmRyfxQIOIIdI1C8058EydK/YZkC2C0vZOSfIHqTJ+Hv67olj9r4dUYm31gwoR0r+zunm2xB/KlNKXJwKhLWFj2S3bxg3kS2TSuBs6DTI4xCykzdjqjfbNZNf5y8hm+IP6jDelVbbhvmCRslRDgCZKkxN+goNEcQHSAKyyKI7cQE+4z5xOPlePPRbYYmhPdJqIVHBy6dLO+XFLBKKMKTTIXnXGWPRX/ghbZdVUnx0GyC54K/iE5FDGJyfJEa9WXyAlwOF+EqK76uE3a+JfcEBaFoEQpFJdntmfhb+RVwMh5hd9AvYbOJ42evjTGZdedaHZw3VM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 800219b6-fba5-47d2-f819-08dc2ddb432c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 04:04:52.9241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: skO/ZvETsKv2WqmI4QSeg5xxW3ssM2Zyx3oYI3xOHW//mGziaWvxRh+mvAC7JyK56HtVHu09Dz0JXkdEGWmx9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5300
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_04,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=729 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402150029
X-Proofpoint-GUID: G9oKB4bg4kvAxjy2khAzR0ABob2OYZ42
X-Proofpoint-ORIG-GUID: G9oKB4bg4kvAxjy2khAzR0ABob2OYZ42

* Vlastimil Babka <vbabka@suse.cz> [240214 10:14]:
> On 2/13/24 03:08, Kent Overstreet wrote:
> > On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote:
> >> On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote:
> >> > From: Kent Overstreet <kent.overstreet@linux.dev>
> >> > 
> >> > It seems we need to be more forceful with the compiler on this one.
> >> 
> >> Sure, but why?
> > 
> > Wasn't getting inlined without it, and that's one we do want inlined -
> > it's only called in one place.
> 
> It would be better to mention this in the changelog so it's clear this is
> for performance and not e.g. needed for the code tagging to work as expected.

Since it's not needed specifically for this set, can we take this patch
out of the set (and any others) and get them upstream first?

My hope is to reduce the count of 35 patches.  Less patches might get
more reviews and small things like this (should be, are?) easy enough to
get out of the way.  But also, it sounds worth doing on its own.