Received-SPF: pass (google.com: domain of linux-kernel+bounces-66311-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <6a8d100c-57a5-4c92-b744-453c106352ad@amd.com>
Date: Thu, 15 Feb 2024 11:13:45 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/3] net: macb: queue tie-off or disable during
 WOL suspend
To: claudiu beznea <claudiu.beznea@tuxon.dev>, nicolas.ferre@microchip.com,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240130104845.3995341-1-vineeth.karumanchi@amd.com>
 <20240130104845.3995341-2-vineeth.karumanchi@amd.com>
 <d8c48839-8b22-47ad-b270-e96a1ad1adee@tuxon.dev>
From: "Karumanchi, Vineeth" <vineeth.karumanchi@amd.com>
Content-Language: en-US
In-Reply-To: <d8c48839-8b22-47ad-b270-e96a1ad1adee@tuxon.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Tnlnc3FxRXZ0RFpXU3YwaTFTTitWWG9tb0Zpbml2Ymo3eXpVQ1VtQjdUVTQr?=
 =?utf-8?B?azZ6dVFFenFQY0ppdVRXY0o1NDgyU2ZPYU1iUERaMU91YzQrcnliSXlOZTdx?=
 =?utf-8?B?cFBiMFNVQjRkWkYrcDMreGZvZy96cjFNNENRbXl4RDErWCtYYzlOTlJvN1hG?=
 =?utf-8?B?ZUZnSUN6MlJEdlkvZnpYSHp5a0l4M3JWUkpyNmRlbDFvT2x2K05HS01DbFdn?=
 =?utf-8?B?YXFNTExrNk1vZEwvYVN6RGE5aDJUZFJpbTNJaThBYXFlZGRwQm13ZFNNbGJz?=
 =?utf-8?B?TnNSUlViQWJ6OGtuZjFpUnBJVWQwenYwcy9mUzR6Zk1xblBNQ1pJMHZvdDRV?=
 =?utf-8?B?bGhFcnAzRTVudlNyK1BkeXY4TFcyOVpFdWpXRDB1VTc4cUpqRnhSS2wxVlow?=
 =?utf-8?B?dUJBSm1SUjRlVDdDclpZMVYzWm9QWXc3VWpXeGc2dFZUbk1DVW1nQ2VaTERz?=
 =?utf-8?B?M3hBZFJVSGNmc1FTMTFLbUJqNktHSnRMamlKNmZhTGV0UEh2U1pxYjZwSHRX?=
 =?utf-8?B?RE4zVjJNK0wwTnZNa3lPMjRiK0g1eURySVYvZzdUTjdRRHpvSmtBakQ1L2w5?=
 =?utf-8?B?NzNTSU9TWXhJTklXSFd5MDE0Wk0zZEV0RUk5MXFhMS9GQUh1bzE5S3ZEMjNO?=
 =?utf-8?B?WlFaR2ZmSWxaaHVyM2E1YnFSUGp4MG84WUwxN3hmNlNmZURLZ3VmdVZaNFJC?=
 =?utf-8?B?TTFQNUlIMkhkV0JjM0hTajBrL0hPcHl0L1EwTDhXSTF0eWRNbUlWTkNDeFYx?=
 =?utf-8?B?d2ZwakthWjdmbXkybnJFSzF0bi9RTWMyV01TVlYxQ1JrajFtcmtGdEZXUjI2?=
 =?utf-8?B?NGlDRjVaa09RYWhqQkMwUXhUVXB6Zllrcmx5MHFzOVJjNWcwQUhDcFI3bDBU?=
 =?utf-8?B?MmZSRmg4UGhMRXMyQm1KSE1qa25QS0c2NG9hR1RIS0lWRnFSbTh5K0pWM0ZV?=
 =?utf-8?B?aUxhL3VOVFVGVTZJNC9JR1Q1Ukdob21MUnhkUEtWeEsrZCt3ZUVvQUVBTkV3?=
 =?utf-8?B?amhKWDNMQThzSlVHVncxNXBhZzk2SzBHUzd6WDVQcU1mc0FCc1ZuenRMS3FI?=
 =?utf-8?B?YnNqWHZHRzVnY21zZVdqaDlIUG9Rc2pEUmZMYWxqL1Yra3RpN3QwaW80ZUV2?=
 =?utf-8?B?L1ZRSXhKZUh0S2g2SEVaRktUZUJzdjk2YUt2N1hxSXFoWXRCczB3ekFYWHVO?=
 =?utf-8?B?WWI2Rmk0QmJJYkdNN3dBcE5YaFhUcDdCMHJIeld0N2xEWitmaHhUcUdQTEVT?=
 =?utf-8?B?NFFMcHMwK0lvWjhtVXdPOTcvRk9aSVRLc0VIZzhXME1vUWM3VVFxc2RhSkI4?=
 =?utf-8?B?S1pFTjU4TFdTUitXTGxuNDFsMnFFd01qNlBSbCtXNjJjOGRiYU9QS2JFTnQw?=
 =?utf-8?B?ZnJ2eHU1N3hoQTV1VXFXVEVLZ2VOQ25vOHQ4b2dWOWVkczlFUkQwdUp2OEgz?=
 =?utf-8?B?bG9uekRmWERMdTNWN2NWbERWRWJYTUZRWE42Zk9QMFlqa1FtVnNUa2VQdVRu?=
 =?utf-8?B?S0lRVllXd0ZiMUhvWXJ2WHRFK2lQZG0wS0poNHN4eWtkSldnZzJtWVdYcDh4?=
 =?utf-8?B?QkNYd1pVMFBiSENhYTNOdjlqWlIvcnNHVHRSMThDb0ZtN1hHcHQzUEtUZ0ww?=
 =?utf-8?B?T2xnQzJkdDVnaVI2czc3akwwVDVCMVBpUnAzRnRqenpqTFhSSEVTUks1UEZx?=
 =?utf-8?B?b2hlMWhDdXZWeE1VOVJxbUxzL3ZTYWJPUW1OQ0dCZ3lIMDV4QVdSaEgwRFBE?=
 =?utf-8?B?VCsxQ05zdmVtQzJRZUM4QjZWcFBUYk03QytEVkordGFkWUJuNEI0SkY2M3ln?=
 =?utf-8?B?bG1ncEM2T3hQaFkzMDlDdmpLVis2SFJyekJiTmpUQ3BrTDNBblRFV0hQTGJs?=
 =?utf-8?B?NVZrUkJIREpkdkRycEhuVEFSZHl4MTB4YUN4dXQwZjdQRnRseUVESUhNTkNG?=
 =?utf-8?B?ODBPbW1sUnJyRWRLdmxPalBkeXJ3WTZLTWFLZHZ0blVMRW8zNVp3aHNJQzRP?=
 =?utf-8?B?eUlRcG91V1ZMbW4zOUg0MzdBUy8zaE82UTN5cEUvSlpGblpIK0ZtV0VzOGFD?=
 =?utf-8?B?TlpuZ0lEcmg2clZ4N3krUHIwRkV6d29jb1lXTnlqNWNiWUhieWgvam9Sa1lv?=
 =?utf-8?Q?KoYtzqhKcYwdqFIIOwtjMVfpS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b7cd3e-a0ff-4dc3-731e-08dc2de91a26
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 05:43:57.0235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FaDz5HdRDvUKvmJZHow2QbK5iLXe7X/6CwbAtGHc49WDRIRqSnd9aKvhItSKeXjH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4326

Hi Claudiu,

On 2/3/2024 9:08 PM, claudiu beznea wrote:
<...>
>>   		queue->tx_skb = NULL;
>> @@ -2568,6 +2574,16 @@ static int macb_alloc_consistent(struct macb *bp)
>>   	if (bp->macbgem_ops.mog_alloc_rx_buffers(bp))
>>   		goto out_err;
>>   
>> +	/* Required for tie off descriptor for PM cases */
>> +	if (!(bp->caps & MACB_CAPS_QUEUE_DISABLE)) {
>> +		bp->rx_ring_tieoff = dma_alloc_coherent(&bp->pdev->dev,
>> +							macb_dma_desc_get_size(bp),
>> +							&bp->rx_ring_tieoff_dma,
>> +							GFP_KERNEL);
>> +		if (!bp->rx_ring_tieoff)
>> +			goto out_err;
> You also need to free the previously allocated rx buffers.

Are you referring to (bp->macbgem_ops.mog_alloc_rx_buffers(bp)) allocation ?
It was freed in macb_free_consistent():
			 ...
			 bp->macbgem_ops.mog_free_rx_buffers(bp);
			 ...

Please let me know if you are referring to different buffers.


> 
>> +	}
>> +
>>   	return 0;
>>   

-- 
???? vineeth