Received-SPF: pass (google.com: domain of linux-kernel+bounces-66378-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Andre Werner <andre.werner@systec-electronic.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.krueger@systec-electronic.com, Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH net-next] net: smsc95xx: add support for SYS TEC USB-SPEmodule1
Date: Thu, 15 Feb 2024 08:50:00 +0100
Message-ID: <13454529.uLZWGnKmhe@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240214132507.28072-1-andre.werner@systec-electronic.com>
References: <20240214132507.28072-1-andre.werner@systec-electronic.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi Andre,

Am Mittwoch, 14. Februar 2024, 14:25:07 CET schrieb Andre Werner:
> This patch adds support for the SYS TEC USB-SPEmodule1 10Base-T1L
> ethernet device to the existing smsc95xx driver by adding the new
> USB VID/PID pair.
>=20
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
>  drivers/net/usb/smsc95xx.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index a530f20ee257..bb4e62a93d96 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -2109,6 +2109,11 @@ static const struct usb_device_id products[] =3D {
>  		USB_DEVICE(0x184F, 0x0051),
>  		.driver_info =3D (unsigned long)&smsc95xx_info,
>  	},
> +	{
> +		/* SYSTEC USB-SPEmodule1 10BASE-T1L Ethernet Device */
> +		USB_DEVICE(0x0878, 0x1400),
> +		.driver_info =3D (unsigned long)&smsc95xx_info,
> +	},

IMHO entries should be sorted by USB Vendor ID. So this goes before=20
Microchip's EVB-LAN8670-USB.

Best regards,
Alexander

>  	{ },		/* END */
>  };
>  MODULE_DEVICE_TABLE(usb, products);


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/