Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp308511rdb; Thu, 15 Feb 2024 00:10:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWXfSQ5vVU+rYpzdEd4GVe1u0t0XOA0SlSZ/8TI4JcVRPJAc0DSAOerCBSqjxQicmM2kAYk1tM1Un9PeqazboeLWtx2lF8TnRpBn4ID0w== X-Google-Smtp-Source: AGHT+IHArVz1TSLbK8LUYbPijexfxU3ZYCxWIqd2k9/eGJhmcwOIrKBJLGGORcclqDmAjqc8M474 X-Received: by 2002:a17:906:799:b0:a38:7015:fc01 with SMTP id l25-20020a170906079900b00a387015fc01mr711414ejc.2.1707984603123; Thu, 15 Feb 2024 00:10:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707984603; cv=pass; d=google.com; s=arc-20160816; b=c45TBDCwruNB44YvX6IeKWxJq71HNsQMjMdOLWcz9aSZqQzIdBtTfiniQcEaQQ7sDv cvX0nTBsH3fpr+/N3PwrARRof4zS5Tw5XWasYTiapXB4G+DTOsoDOKd+5YotixInepZK 7XnVBOr4zxivwuvScS1r2AhJJCQ4tLhcXl7Y3iTHFOef9HbESkrizhjB0H95Xv8fuvTH FKeoK5DRuT0EST9Lieg+rebnr9RIGAVNEA5YtfFFTxQDuKTWSrHpIJTGljkPjv2VFOks M5aiMf1kG68FaFtMpArRQJp01fkacAoQvkii2D2ebTSi7dTIUSLaFakgw3EhMXlU8vO5 bBtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=fNfrKgN3kLObdycvA/+kY7RqzkR6TPDMJgFqmqIeLZ8=; fh=rRcOT7A0C0x9XvRQ7pu1uDSQVFv6fK9DUyg4KZTcQT0=; b=ZHzcXdGSIyz7370hrnulISs9SnNgpyt0ubZjn2k4XGwLWiSxDywHKv7DpKS0yHbjwY 5sHBsWMT6YZCbjBalWdLPdxmDTCUSwsgV0Vu/9fD5IzrVrZeai3UBlHkpZPcWD1/JdgU rP6Ecbc3vwvr9rD4uG6hEjaNafCaS60yKPVINfR3Fyg358r7ow6luKu2qgWSPAkBDKAu /FopINcMO/goQZsGB9Xa4tBMrv5Xuav2leyeZvI1deNUG1RXnYMGC7ciyv0kQxhdPYN/ wRsrNgs2wrQ9LQPrtaJa6P1fSXUEbD9A10q6ZZvtqR1mnFS5ZS23tTJe/xb2NOcRwru8 eR1g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@protonic.nl header.s=202111 header.b=ABpf9BJF; arc=pass (i=1 spf=pass spfdomain=protonic.nl dkim=pass dkdomain=protonic.nl); spf=pass (google.com: domain of linux-kernel+bounces-66390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66390-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id d12-20020a1709064c4c00b00a3d9e6b2a25si208929ejw.1020.2024.02.15.00.10.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 00:10:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@protonic.nl header.s=202111 header.b=ABpf9BJF; arc=pass (i=1 spf=pass spfdomain=protonic.nl dkim=pass dkdomain=protonic.nl); spf=pass (google.com: domain of linux-kernel+bounces-66390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66390-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CB9701F2363A for ; Thu, 15 Feb 2024 08:10:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2EE9512B9D; Thu, 15 Feb 2024 08:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonic.nl header.i=@protonic.nl header.b="ABpf9BJF" Received: from smtp28.bhosted.nl (smtp28.bhosted.nl [94.124.121.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F8411702 for ; Thu, 15 Feb 2024 08:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=94.124.121.40 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707984571; cv=none; b=jq4VO6Q4/SrX8XPWldx27Gt41IKEx5LMMzKUpCZB7NvwIQq2M/WPlEN7dKpHPJz+Cch2wNwvTVsasSwAs1ccXdlgPKWbAGl0PZmuzSup839rddHFKq/CMIE0E3jpKPhZmZF0QSJkSsWZgDSMfTwY9Md5ejjgRDT47LunhTTwbh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707984571; c=relaxed/simple; bh=rvQ+BGvz4Ur3Y3yGG6aT2h/S6cdZvcGtvjc69nxLSmg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WrxG2Cd3eug922lBHCfRU1zwx7eZWqszDtCQa132nOCCy0aXqw5uqfNaFz3A+KQL0/A4VQ5ycG8YChdfwbWrJ/hDLNRKOIAApUrbp+UA+n/1GmCRvqVAzS2T3BwrdcbVUi4CSf9zvTrrB3Z8ID+qP82p8ZAxYoaxcfICBiVMnoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=protonic.nl; spf=pass smtp.mailfrom=protonic.nl; dkim=pass (2048-bit key) header.d=protonic.nl header.i=@protonic.nl header.b=ABpf9BJF; arc=none smtp.client-ip=94.124.121.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=protonic.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonic.nl DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonic.nl; s=202111; h=content-transfer-encoding:content-type:mime-version:references:in-reply-to: message-id:subject:cc:to:from:date:from; bh=fNfrKgN3kLObdycvA/+kY7RqzkR6TPDMJgFqmqIeLZ8=; b=ABpf9BJF2XW8rQnAHZShtEsCvWTovWqO9KGW1M9yXTygOEPPe3r++vfHI14nJ3D/QQVCg1E2orsrP MXMjumKRqtFUfK5B56ep4KQJrQE+ZyiXv2WFGsMlUnsjhYQmpE//UIvM93X7RYhZSvuvklSheQYs3z +OC5qEFGNErGqES1VJnCsjA6pUTqeJ1O/YJaIEVp4pn4oYRrUjuFrGHMUAsXNwWm7VRKk1yFJt9FZA KYidvQlhy9MpZLuwHv3w7kHB/7VCjcvE/j+s8OHwAZcTxbvrL7WIdJaSWzPzXS+imhaFZsKRcmPKv7 qilOUfwf1ubeuqZVv4rXg20BLHiazsw== X-MSG-ID: 847ace45-cbd9-11ee-ba6d-0050568164d1 Date: Thu, 15 Feb 2024 09:09:18 +0100 From: Robin van der Gracht To: Andy Shevchenko Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Burton Subject: Re: [PATCH v2 11/15] auxdisplay: ht16k33: Move ht16k33_linedisp_ops down Message-ID: <20240215090918.31ac2006@ERD993> In-Reply-To: <20240212170423.2860895-12-andriy.shevchenko@linux.intel.com> References: <20240212170423.2860895-1-andriy.shevchenko@linux.intel.com> <20240212170423.2860895-12-andriy.shevchenko@linux.intel.com> Organization: Protonic Holland X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 Feb 2024 19:01:44 +0200 Andy Shevchenko wrote: > We will need the update functions to be defined before > ht16k33_linedisp_ops. Move the latter down in the code. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > drivers/auxdisplay/ht16k33.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index 0cdf3fbdf81e..75c4a8d31642 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -440,18 +440,6 @@ static void ht16k33_keypad_stop(struct input_dev *dev) > disable_irq(keypad->client->irq); > } Acked-by: Robin van der Gracht