Received-SPF: pass (google.com: domain of linux-kernel+bounces-66393-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <be512dfd907d3d0a30aac8d055605d519d7c7613.camel@gmail.com>
Subject: Re: [PATCH] net: ethernet: adi: requires PHYLIB support
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>, Lennart Franzen
 <lennart@lfdomain.com>,  Alexandru Tachici <alexandru.tachici@analog.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, netdev@vger.kernel.org
Date: Thu, 15 Feb 2024 09:10:33 +0100
In-Reply-To: <20240215070050.2389-1-rdunlap@infradead.org>
References: <20240215070050.2389-1-rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-02-14 at 23:00 -0800, Randy Dunlap wrote:
> This driver uses functions that are supplied by the Kconfig symbol
> PHYLIB, so select it to ensure that they are built as needed.
>=20
> When CONFIG_ADIN1110=3Dy and CONFIG_PHYLIB=3Dm, there are multiple build
> (linker) errors that are resolved by this Kconfig change:
>=20
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_net_open':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:933: undefined reference=
 to `phy_start'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_probe_netdevs':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:1603: undefined referenc=
e to
> `get_phy_device'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.c:1609: undefined refe=
rence to
> `phy_connect'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_disconnect_phy':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:1226: undefined referenc=
e to
> `phy_disconnect'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `devm_m=
diobus_alloc':
> =C2=A0=C2=A0 include/linux/phy.h:455: undefined reference to `devm_mdiobu=
s_alloc_size'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function
> `adin1110_register_mdiobus':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:529: undefined reference=
 to
> `__devm_mdiobus_register'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_net_stop':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:958: undefined reference=
 to `phy_stop'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_disconnect_phy':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:1226: undefined referenc=
e to
> `phy_disconnect'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_adjust_link':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:1077: undefined referenc=
e to
> `phy_print_status'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o: in function `adin11=
10_ioctl':
> =C2=A0=C2=A0 drivers/net/ethernet/adi/adin1110.c:790: undefined reference=
 to `phy_do_ioctl'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o:(.rodata+0xf60): und=
efined reference to
> `phy_ethtool_get_link_ksettings'
> =C2=A0=C2=A0 ld: drivers/net/ethernet/adi/adin1110.o:(.rodata+0xf68): und=
efined reference to
> `phy_ethtool_set_link_ksettings'
>=20
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402070626.eZsfVHG5-lkp@i=
ntel.com/
> Cc: Lennart Franzen <lennart@lfdomain.com>
> Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>


> =C2=A0drivers/net/ethernet/adi/Kconfig |=C2=A0=C2=A0=C2=A0 1 +
> =C2=A01 file changed, 1 insertion(+)
>=20
> diff -- a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kco=
nfig
> --- a/drivers/net/ethernet/adi/Kconfig
> +++ b/drivers/net/ethernet/adi/Kconfig
> @@ -7,6 +7,7 @@ config NET_VENDOR_ADI
> =C2=A0	bool "Analog Devices devices"
> =C2=A0	default y
> =C2=A0	depends on SPI
> +	select PHYLIB
> =C2=A0	help
> =C2=A0	=C2=A0 If you have a network (Ethernet) card belonging to this cla=
ss, say Y.
> =C2=A0