Received-SPF: pass (google.com: domain of linux-kernel+bounces-66368-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 15 Feb 2024 08:38:19 +0100
From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH RFT v2 0/3] Fix up SC8280XP idle states
Message-ID: <Zc2_a9_w1Val6Lz4@hovoldconsulting.com>
References: <20230619-topic-sc8280xp-idle-v2-0-cde50bf02f3c@linaro.org>
 <k7v2qov3m43q7vniqu3w6q64277ea5mf7gvt6fzgj4e3a5uagt@fcsmuu24cfqr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <k7v2qov3m43q7vniqu3w6q64277ea5mf7gvt6fzgj4e3a5uagt@fcsmuu24cfqr>

On Tue, Feb 13, 2024 at 11:35:06PM -0600, Bjorn Andersson wrote:
> On Wed, Dec 20, 2023 at 11:12:53PM +0100, Konrad Dybcio wrote:
> > Comparing the data available in the downstream sources with what's there
> > upstream, it was easy to spot some differences. This series aligns what
> > we have upstream with what is there on the vendor kernel.
> > 
> > The big asterisk there is that the downstream sources for SC8280XP can't
> > always be trusted. A simple test shows that the lower idle states that
> > were previously missing are implemented in the firmware (Linux reports no
> > errors and enters them).
> > 
> > HOWEVER
> > 
> > The only cluster idle state that's been present until now (the deepest
> > one) is now barely used if at all, as the scheduler seems to deem it
> > inefficient or so.
> > 
> > Hence, a request for testing and comments, especially from those who
> > use the X13s daily or have reliable setup to measure the power usage.
> > 
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> What did we conclude on this one? Does the extra state make sense?
> The last patch looks useful...

I asked Konrad a while back to provide some performance numbers to
accompany this change.

I think he said that this series made no difference in either direction,
but IIUC that only after a really quick attempt at evaluating the
impact during a meeting we had.

Johan