Received-SPF: pass (google.com: domain of linux-kernel+bounces-66307-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 14 Feb 2024 21:26:34 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	fuyuanli <fuyuanli@didiglobal.com>
Subject: Re: [PATCH] kernel/hung_task.c: export sysctl_hung_task_timeout_secs
Message-ID: <Zc2giqMeZhxuDSU9@infradead.org>
References: <20240209070935.1529844-1-kent.overstreet@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240209070935.1529844-1-kent.overstreet@linux.dev>

On Fri, Feb 09, 2024 at 02:09:35AM -0500, Kent Overstreet wrote:
> needed for thread_with_file; also rare but not unheard of to need this
> in module code, when blocking on user input.
> 
> one workaround used by some code is wait_event_interruptible() - but
> that can be buggy if the outer context isn't expecting unwinding.

I don't think just exporting the variable ad thus allowing write
access is a good idea.  If we want to keep going down the route of
this hack we should add an accessor function that returns the value.

The cleaner solution would be a new task state that explicitly
marks code than can sleep forever without triggerring the hang
check.  Although this might be a bit invaѕive and take a while.