Received-SPF: pass (google.com: domain of linux-kernel+bounces-66427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9b93b9c0-4b0f-4654-b9e6-4fc045cb6817@linux.ibm.com>
Date: Thu, 15 Feb 2024 09:30:39 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net/iucv: fix the allocation size of iucv_path_table
 array
Content-Language: en-US
To: Alexander Gordeev <agordeev@linux.ibm.com>,
        Thorsten Winkler <twinkler@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240214163240.2537189-1-agordeev@linux.ibm.com>
From: Alexandra Winter <wintera@linux.ibm.com>
In-Reply-To: <20240214163240.2537189-1-agordeev@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 14.02.24 17:32, Alexander Gordeev wrote:
> iucv_path_table is a dynamically allocated array of pointers to
> struct iucv_path items. Yet, its size is calculated as if it was
> an array of struct iucv_path items.
> 
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
>  net/iucv/iucv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
> index 9e62783e6acb..5b56ae6612dd 100644
> --- a/net/iucv/iucv.c
> +++ b/net/iucv/iucv.c
> @@ -156,7 +156,7 @@ static char iucv_error_pathid[16] = "INVALID PATHID";
>  static LIST_HEAD(iucv_handler_list);
>  
>  /*
> - * iucv_path_table: an array of iucv_path structures.
> + * iucv_path_table: array of pointers to iucv_path structures.
>   */
>  static struct iucv_path **iucv_path_table;
>  static unsigned long iucv_max_pathid;
> @@ -545,7 +545,7 @@ static int iucv_enable(void)
>  
>  	cpus_read_lock();
>  	rc = -ENOMEM;
> -	alloc_size = iucv_max_pathid * sizeof(struct iucv_path);
> +	alloc_size = iucv_max_pathid * sizeof(*iucv_path_table);
>  	iucv_path_table = kzalloc(alloc_size, GFP_KERNEL);
>  	if (!iucv_path_table)
>  		goto out;


Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>

Good catch, thank you.
As we allocate a more than we need, I don't this
needs to be backported to stable. Do you agree?