Received-SPF: pass (google.com: domain of linux-kernel+bounces-66428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Pawel Laszczak <pawell@cadence.com>
To: Peter Chen <peter.chen@kernel.org>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: blocked some cdns3 specific code
Thread-Topic: [PATCH] usb: cdnsp: blocked some cdns3 specific code
Thread-Index: AQHaX9+mxT8jO+heF0CzIFXGRuFRqLELAfOg
Date: Thu, 15 Feb 2024 07:36:01 +0000
Message-ID: 
 <BYAPR07MB5381ACBD4E6CAF76D86DB10FDD4D2@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20240215072138.GB1256251@nchen-desktop>
In-Reply-To: <20240215072138.GB1256251@nchen-desktop>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?N7t0immPev90OAOb66iOvMbHRlRd9MRuY4d2ZJfqwto7tqpCBs+AUL7M7RGa?=
 =?us-ascii?Q?wJsyH6VTVN8CCkxVgAvQyALVJIeSWNyYXPlvDCdeXadsdL/OhTRRCaDSfxKN?=
 =?us-ascii?Q?cn6bUeJr+fRyBqq0UEQaJcw7xlDow7tmK4SjFYbSUbQ6/g+9+zPMsVpyoJkZ?=
 =?us-ascii?Q?jM8AjJrE1NgMhgPOzMPFudPThkLE2UQTGIO017NUyd6hihyMGJcLVfA7rZUd?=
 =?us-ascii?Q?BhW2x+shu6ipaWAo/Es/sGHohNyPNDJ/WY7ckDpp7ce8HNQyzN+ktC2DDmcp?=
 =?us-ascii?Q?g+Y6e9LnJbNlm2e8gmQ8g1DVC2ZiDPcOTmA8vfSRCSME/oz5wi8cYp+FFm2N?=
 =?us-ascii?Q?6k65yI+VXo8mYTJk44iWWbcTDw6H9ZUC2Ig+JO/yqczEaTv5aOQuIXb1HKm5?=
 =?us-ascii?Q?rxPsq7bIlYEz9VKc1RzVlfkDu7FogxeEO1QFHNjdDM2bpXeT0tv2n4PK8eAj?=
 =?us-ascii?Q?0z6AXeZLl1ZKFtCBRZ4r45KgBdiUenvpEIShsuvsRGUET8N12fvIAKhd+17Y?=
 =?us-ascii?Q?pVB8YWnHmFeaSklRiYFRdfVGycrZUFlpes8+gKG/sEBWk44HUcU/XUPFEhuz?=
 =?us-ascii?Q?lSkqKuZiVMe519Yc05/dV/UQvx+TV9D97uE7fKtxtXmXGXWTOMBgl6jJZ9Sk?=
 =?us-ascii?Q?MFXO+fPsEUw1ABpJ+95TsV+57CYT33rluEHHWe++3geQU3l62MJcxXJ8Wx3p?=
 =?us-ascii?Q?w6dLMyfD7U62Tip3HofeSDLTIyyVLh+296qN4ZaLDqughrsgS0mzjthKLTDC?=
 =?us-ascii?Q?73EYaMu9Nisnbk9H6QKTBsbm99Wv8EQ8Zm1W/Kclf205sPvHKx1yaXFGVKKS?=
 =?us-ascii?Q?xKQiANypKsH/UK05lm1++2qkQHFTD4+Ao/oqcblZk5h+AWbwQcT5jVoM1Cfo?=
 =?us-ascii?Q?BF/DUq471rwZR1hgPbEKe8nKXUj3c0eyYJUaXOb7V+CDOTZgeMx8HOiiIPDc?=
 =?us-ascii?Q?IAHxW0LNd4qdffPcux3iAK0GO1ceLq7WZ/RvrZUJ/+5TSSAFni2vnv+aVaGh?=
 =?us-ascii?Q?sulmjFMaJvVid/SHLG8w3o6liNPdDvtUgeSaRryi5QZ0CZ5BMCoL0InuBsSV?=
 =?us-ascii?Q?FgYzfda4F02DOhle5c0U+3+mZAoM/aMLxduOqotImlWZXmrkvgSIaLud/QCo?=
 =?us-ascii?Q?ku+HkJzO7sSTZjDRZOdRUdzRY3qPDMNBMImcujc7TD+lm94h2u38hpLsQDOG?=
 =?us-ascii?Q?mGBTF7eTLZ+Vq8lSzD6wRqpWTE3HYN0XzagMkkL07jMivXa+qSL2+z1qt9lw?=
 =?us-ascii?Q?8OAPRdhT8uo2pyNhV/MuJAYyRkGqKlMKGHHUgvZudjxmt85Fkbpts/EuAakU?=
 =?us-ascii?Q?Kve2/qxpBL7S+9/4YusvFzIXnFnzNO6qL394znqn704Klo+NWN7bQyGckv2O?=
 =?us-ascii?Q?5eWbAhVFujFQqY9xXMbWwGVCcLGaBG3DPseFdcno6DJSLtkN77ENaQ7kkU3D?=
 =?us-ascii?Q?FIrIc9n/C44yWFlRsIUjbt0ABkG7ZqUqNktJPDlhZS5BwX2hSXuHxHTPA9GH?=
 =?us-ascii?Q?+a97W5OZKLeeNu0UfQQ/VlrzAOTR9v+IS7b0Jolu0tr6Dg2tPg9ZZU9P4Caf?=
 =?us-ascii?Q?DpaQvgqNNVlZekPANIn5uHZvHvwJc/8LRtzR8trE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c32faf29-c083-4f48-f1f2-08dc2df8c225
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2024 07:36:01.1791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jQ8s42NB+0YWuskDiTXJTFt3mDLaulPmUDWxdiIGKKcHxd9NqdqwURK7ZZwkUTkSpO9vAvz7mq3FB2ZEQf5q6DokABwAikBlh+9kbjp/Mbk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR07MB9767
X-Proofpoint-ORIG-GUID: 2f9G7rUfyaWMsADaFaG-y5kNbJKJ7_-M
X-Proofpoint-GUID: 2f9G7rUfyaWMsADaFaG-y5kNbJKJ7_-M
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-15_07,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0
 clxscore=1015 mlxscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.19.0-2401310000
 definitions=main-2402150058

>
>It is for both cdns3 and cdnsp.
>
>Reply-To:
>In-Reply-To: <20240206104018.48272-1-pawell@cadence.com>
>
>On 24-02-06 11:40:18, Pawel Laszczak wrote:
>> host.c file has some parts of code that were introduced for CDNS3
>> driver and should not be used with CDNSP driver.
>> This patch blocks using these parts of codes by CDNSP driver.
>> These elements include:
>> - xhci_plat_cdns3_xhci object
>> - cdns3 specific XECP_PORT_CAP_REG register
>> - cdns3 specific XECP_AUX_CTRL_REG1 register
>>
>> cc: <stable@vger.kernel.org>
>> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence
>> USBSSP DRD Driver")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/host.c | 16 ++++++++++++++--
>>  1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c index
>> 6164fc4c96a4..ceca4d839dfd 100644
>> --- a/drivers/usb/cdns3/host.c
>> +++ b/drivers/usb/cdns3/host.c
>> @@ -18,6 +18,11 @@
>>  #include "../host/xhci.h"
>>  #include "../host/xhci-plat.h"
>>
>> +/*
>> + * The XECP_PORT_CAP_REG and XECP_AUX_CTRL_REG1 exist only
>> + * in Cadence USB3 dual-role controller, so it can't be used
>> + * with Cadence CDNSP dual-role controller.
>> + */
>>  #define XECP_PORT_CAP_REG	0x8000
>>  #define XECP_AUX_CTRL_REG1	0x8120
>>
>> @@ -57,6 +62,8 @@ static const struct xhci_plat_priv xhci_plat_cdns3_xhc=
i =3D
>{
>>  	.resume_quirk =3D xhci_cdns3_resume_quirk,  };
>>
>> +static const struct xhci_plat_priv xhci_plat_cdnsp_xhci;
>> +
>>  static int __cdns_host_init(struct cdns *cdns)  {
>>  	struct platform_device *xhci;
>> @@ -81,8 +88,13 @@ static int __cdns_host_init(struct cdns *cdns)
>>  		goto err1;
>>  	}
>>
>> -	cdns->xhci_plat_data =3D kmemdup(&xhci_plat_cdns3_xhci,
>> -			sizeof(struct xhci_plat_priv), GFP_KERNEL);
>> +	if (cdns->version < CDNSP_CONTROLLER_V2)
>> +		cdns->xhci_plat_data =3D kmemdup(&xhci_plat_cdns3_xhci,
>> +				sizeof(struct xhci_plat_priv), GFP_KERNEL);
>> +	else
>> +		cdns->xhci_plat_data =3D kmemdup(&xhci_plat_cdnsp_xhci,
>> +				sizeof(struct xhci_plat_priv), GFP_KERNEL);
>> +
>
>You may explain why you duplicate another structure for cdnsp at commit lo=
g.

In my opinion it is more readable. If someone will review the code then eas=
ier to notice the difference between these driver.=20

Thanks
Pawel

>
>>  	if (!cdns->xhci_plat_data) {
>>  		ret =3D -ENOMEM;
>>  		goto err1;
>>
>
>Others are okay for me.
>
>--
>
>Thanks,
>Peter Chen