Received-SPF: pass (google.com: domain of linux-kernel+bounces-66478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID:
 <MA0P287MB2822E03B61DF33B4438833D9FE4D2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 15 Feb 2024 16:59:07 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/4] reset: simple: add support for Sophgo SG2042
To: Chen Wang <unicornxw@gmail.com>, aou@eecs.berkeley.edu,
 chao.wei@sophgo.com, conor@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 palmer@dabbelt.com, paul.walmsley@sifive.com, p.zabel@pengutronix.de,
 robh+dt@kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org,
 jszhang@kernel.org, inochiama@outlook.com
References: <cover.1706577450.git.unicorn_wang@outlook.com>
 <1cfd7b3ba447942784c4f7aa595e962399e9f617.1706577450.git.unicorn_wang@outlook.com>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <1cfd7b3ba447942784c4f7aa595e962399e9f617.1706577450.git.unicorn_wang@outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN2P287MB1645:EE_
X-MS-Office365-Filtering-Correlation-Id: f48ff6ac-8d65-4380-933e-08dc2e0460bb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DPTHHHsjJgDEv3uZ2C/M4WQaD7eRzoqhg74jmyXNkS4SMvfPUByufXO3A5askxZU6IlabNQQZamN0ZSBudIll8bJN3OelCa97IkWOTRS8/VH0O/6U96ajYwloMzkzklQidF0iwkSstF5LuMZHzslsymdrjgdGULF7lLZNAqnAHLFWt8/SVjihUc7vrGCZmS6fcUQct8Yg2r7k8CcRVGJm1VlaJ9HhpyNlbgQnoLOPMHVzukiCZ6S4no4wh3T6W6bz3COB3mo16F/r6VhT+yoth5AF/0EdvXtsF+ze5LK0X697DoqtbIvKqcxTFw/LHSkHnYyeCAXOsXffPkQiwENjuOtAi3uoehxOTSJTmHwAOEqtAT/D7s3hoP0YKcynezTxbv6yC2dTN96uMhUu3L/2JMm8ZcHtt9DcA9oOLDfpSpZhfyBPo9Jqv2Ys3vo8nXpconITu2fC7B3Yiy1fYpDb/b9aeN+DWJmD0U4usV9SkB+E1V73biVKrM5C7xds0n4rfXU3b9M/kqWESk5b5e+kAxjo2upCfQdrHPVkQG3QfCg7xhQcQL/qfBd+rFIBwc+
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bVYrNGswNVd1Y0ZaVWRtVW82WVZxVDM1N1UySHQycmRRaThUTFdEMTNYV2Zh?=
 =?utf-8?B?TmthZEYwQUVZRlZ5R3h3QUlvcWdXalRYK3hFVzNPdSsvTVY0R0pNcWZwYVVs?=
 =?utf-8?B?azNNdDQrckpzU2swWlpZM0VxTFdXYmVlZFlINy9sdnlFamlSVzI0NmhIR0da?=
 =?utf-8?B?MzVsbFp6NDBiNHhtdnZHbWQzTHgwY0hMQm9TNm9MNkhEb044TjZRcVZ5bmdp?=
 =?utf-8?B?Z0lLYTRIS2dBbmpmUHRiWmo5bGplaXYzWGxyUzlSNU1TVzdIY2F2NnZDTkpw?=
 =?utf-8?B?aHRUWlpFR1lCYThlUnBaa00vaW1JUmpFL3VVbEF4eXJWeDBuRjdoeWhDd1ZS?=
 =?utf-8?B?NmcyYmkrQkR2eVlzODdrazVYWVpDSGYwTHFqOGNYT2hXdjFML2d0N2NVcjc1?=
 =?utf-8?B?RUhudkhKMER4bVd6V1NSNVgvWDdRMmVZeHRZaHJUbTU4bHNqcDd0citlU2Uz?=
 =?utf-8?B?cXV6c1lNc2RIR0h6Ym1CMEJESWZzT3ljOWM3TFo1c0tqMHd1eE1zK0JrK3FV?=
 =?utf-8?B?Vm9Od0YyMVFNbXl0Nlh0SldwQ2FMb0FqU3d2b1Iwa2NqUjV2djNlNjVsRGNi?=
 =?utf-8?B?UmlpTm5EVWxnL0dTalR1a3VDWGVwMnRkNktvSnlRbEhzdkptNnJMNW94Z25V?=
 =?utf-8?B?OFRIWkZLTDFvK3JWYnh1eEh0V01UUTRSQlZLV0h3ZXdLOUlkWHJnbk1scVlI?=
 =?utf-8?B?Y3lpS01KS2hrRVNaZk1KR1d2UlpOYjF3WjAzOHphdkVpRUVaOWZTL01IMTFI?=
 =?utf-8?B?aVEvcHk5VDdkUGtDRU1iQkN1ZDBVTE81Tmh4YXQ2anZ3M0FxV083aFliVjBJ?=
 =?utf-8?B?SDFJVGxhK0dJeHZJQ0dhZ3g1UitwLyttaUQzQjF1VHRKamxEY05HZEh6MU9G?=
 =?utf-8?B?OHpDYm9HWnFyVGMrUlpiMjhKa2ZLOXBUZEZvQ0JwRHQreXNxZWdrY0FjYVRD?=
 =?utf-8?B?RjJ6dzdDcUtERjl5YnM5Y3Y2Um9kVFdoTjZFaTVFT2ovTVRUd0Q2WlNqQzlZ?=
 =?utf-8?B?VHlIa3hiVFA3OVFLNTNvbzFXK0ppY256UnRJU1ZkM0pmOW5QM1Nnb0NMZWFu?=
 =?utf-8?B?b3dxTHhyWkw3L3d1MHZkRWJYYzNDTG52Um5WazJYaEE2OVcwVzgvbk1GTWJR?=
 =?utf-8?B?ZUhHaFNwNlZNeHFmWkE2V21DZWpqck5UY2xwZERVZE9UNmEzbGhsMUt1OWtm?=
 =?utf-8?B?R2NJUlE3ZzMwNEtOWnRBYURCVkZMMXVvVWRrSE5ic0RyMWR3VlorWVp3RzZX?=
 =?utf-8?B?TFpRdm5WS1E2SWJxTDNTa3hWdzltS01jS3hWcjBHR3B5Z2FuKzJHeHZjNXd1?=
 =?utf-8?B?cUd1VW94cjV3TUlWQWN2dGNXanpVVk90dW1udmRCK0VuVUlzV2xrSXRJTXlr?=
 =?utf-8?B?VklVNnR1N0FNRTh0ZVo4VG1UMzNMMmVhbmMzR2cwSWFROXFld3FxTGVxS2pa?=
 =?utf-8?B?OTZ1S1k3aUY4bE8yNTBNNUdxc2JkeXpKVFFDRzFRTjFsN1hhc3FmU1lHOFRJ?=
 =?utf-8?B?N2pTQis1TVlTQ1VWaEo2UWRLTG9MLzV0cFZNRmM1RjIwd21SU1ZTOElHcHQz?=
 =?utf-8?B?RURaVlViSEVHWS9qa2pJTEllcXJRU3dSVzg1ZzJSaHVBVFEzdzBMbGZIRmln?=
 =?utf-8?B?clVvWFRWZEx2Vm9LSHEvSDYvYW9Oa2ppZmNOTytYK0JOS3Z0VTFrYWpFKzVO?=
 =?utf-8?Q?JnI7MJz+YUxMhUb+vOxC?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f48ff6ac-8d65-4380-933e-08dc2e0460bb
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 08:59:11.9411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2P287MB1645

ping ~~~

On 2024/1/30 9:50, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> Reuse reset-simple driver for the Sophgo SG2042 reset generator.
>
> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
> ---
>   drivers/reset/Kconfig        | 3 ++-
>   drivers/reset/reset-simple.c | 2 ++
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index ccd59ddd7610..2034f69d5953 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -213,7 +213,7 @@ config RESET_SCMI
>   
>   config RESET_SIMPLE
>   	bool "Simple Reset Controller Driver" if COMPILE_TEST || EXPERT
> -	default ARCH_ASPEED || ARCH_BCMBCA || ARCH_BITMAIN || ARCH_REALTEK || ARCH_STM32 || (ARCH_INTEL_SOCFPGA && ARM64) || ARCH_SUNXI || ARC
> +	default ARCH_ASPEED || ARCH_BCMBCA || ARCH_BITMAIN || ARCH_REALTEK || ARCH_SOPHGO || ARCH_STM32 || (ARCH_INTEL_SOCFPGA && ARM64) || ARCH_SUNXI || ARC
>   	depends on HAS_IOMEM
>   	help
>   	  This enables a simple reset controller driver for reset lines that
> @@ -228,6 +228,7 @@ config RESET_SIMPLE
>   	   - RCC reset controller in STM32 MCUs
>   	   - Allwinner SoCs
>   	   - SiFive FU740 SoCs
> +	   - Sophgo SoCs
>   
>   config RESET_SOCFPGA
>   	bool "SoCFPGA Reset Driver" if COMPILE_TEST && (!ARM || !ARCH_INTEL_SOCFPGA)
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> index 818cabcc9fb7..276067839830 100644
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -151,6 +151,8 @@ static const struct of_device_id reset_simple_dt_ids[] = {
>   	{ .compatible = "snps,dw-high-reset" },
>   	{ .compatible = "snps,dw-low-reset",
>   		.data = &reset_simple_active_low },
> +	{ .compatible = "sophgo,sg2042-reset",
> +		.data = &reset_simple_active_low },
>   	{ /* sentinel */ },
>   };
>   

hello,  Philipp,

Can you please have a look of this, I have fixed the issue you raised in 
last version, any question please feel free let me know.

BTW, will you pick this for v6.9 if it is ok to you.

Thanks,

Chen